metamask-mobile icon indicating copy to clipboard operation
metamask-mobile copied to clipboard

Published 20 hours ago • verified publisher icon MetaMask

Refactor ApproveTransaction Component

Open blackdevelopa opened this issue 3 years ago • 1 comments

Description

Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions, 1. What is the reason for the change? 2. What is the improvement/solution?

Screenshots/Recordings

https://user-images.githubusercontent.com/29962968/184896902-d3e0b7f9-70c5-4551-ad30-f13fd07cce93.mov

Issue

Progresses #???

Checklist

  • [ ] There is a related GitHub issue
  • [ ] Tests are included if applicable
  • [ ] Any added code is fully documented

blackdevelopa avatar Aug 16 '22 13:08 blackdevelopa

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

github-actions[bot] avatar Aug 16 '22 13:08 github-actions[bot]

Goerli, Fuji, Mumbai testnets all look good. I am having issues testing this with BNB testnet. Getting JSON-RPC error.... https://recordit.co/zn0ab4MQ4Y

Hey Chris, thanks for this. Updated now

Network coverage: https://docs.google.com/spreadsheets/d/15hDtscWe9T-1eYgnE0mIB2zZ96ydwMxALXmI7QwTsvo/edit#gid=0

blackdevelopa avatar Oct 25 '22 08:10 blackdevelopa