metamask-mobile icon indicating copy to clipboard operation
metamask-mobile copied to clipboard

Published 20 hours ago • verified publisher icon MetaMask

Refactor SendTransaction Component

Open blackdevelopa opened this issue 3 years ago • 1 comments

Description There is very similar code spread across 5 components. This PR removes the eip1559 gas polling logic away from the send flow (confirm screen). The TransactionReview and EditGasFee screens is able to calculate the gas transaction cost. This logic is abstracted away in the gas polling file. The changes in this PR shouldn't modify existing behaviour when QA'd.

Progresses https://github.com/MetaMask/mobile-planning/issues/272

Screenshots/Recordings

https://user-images.githubusercontent.com/29962968/184000489-af5061ad-f713-4f79-bd0a-33e018eb475b.mov

Issue

Progresses https://github.com/metamask/mobile-planning/issues/269

Checklist

  • [ ] There is a related GitHub issue
  • [ ] Tests are included if applicable
  • [ ] Any added code is fully documented

blackdevelopa avatar Aug 10 '22 19:08 blackdevelopa

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

github-actions[bot] avatar Aug 10 '22 19:08 github-actions[bot]

@blackdevelopa Please resolve conflicts

sethkfman avatar Oct 04 '22 15:10 sethkfman

https://docs.google.com/spreadsheets/d/15hDtscWe9T-1eYgnE0mIB2zZ96ydwMxALXmI7QwTsvo/edit#gid=0

blackdevelopa avatar Oct 10 '22 13:10 blackdevelopa

@blackdevelopa not able to send on Binance testnet. Getting JSON-RPC error... https://recordit.co/HCLAxi2VPp

chrisleewilcox avatar Oct 11 '22 18:10 chrisleewilcox

Send refactor looks good on the following testnets....

  • Goerli (ETH), priority level low
  • Fuji (AVAX), priority level low
  • Mumbai (MATIC), use max, priority level low

chrisleewilcox avatar Oct 11 '22 19:10 chrisleewilcox

@blackdevelopa not able to send on Binance testnet. Getting JSON-RPC error... https://recordit.co/HCLAxi2VPp

resolved. http://recordit.co/1ZkJUCgmb0

blackdevelopa avatar Oct 11 '22 19:10 blackdevelopa

Send is good on BNB testnet now.

chrisleewilcox avatar Oct 11 '22 20:10 chrisleewilcox