metamask-mobile icon indicating copy to clipboard operation
metamask-mobile copied to clipboard

Sent transaction icon changes incorrectly when the language changes

Open tommasini opened this issue 3 years ago • 1 comments

Description The issue was when we change language the icon of a transaction was not consistent, a sent icon was changed for one swipe icon.

Proposed Solution Comparing the action key with lower case and the translation with lower case to have consistent results. [Technical] - When we compare we lower the case of the strings, because the string.include() is case sensitive.

Screenshots/Recordings https://recordit.co/eQPcABRTaA

Issue https://github.com/MetaMask/metamask-mobile/issues/4814 Progresses #4184

Checklist

  • [x] There is a related GitHub issue
  • [ ] Tests are included if applicable
  • [ ] Any added code is fully documented

tommasini avatar Aug 10 '22 15:08 tommasini

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

github-actions[bot] avatar Aug 10 '22 15:08 github-actions[bot]

I'm closing this PR since it's too old

tommasini avatar Jul 06 '23 09:07 tommasini