metamask-mobile icon indicating copy to clipboard operation
metamask-mobile copied to clipboard

Add user agent from Webview property as default in HTTP interceptor (Android)

Open Fatxx opened this issue 3 years ago • 2 comments

Description

The userAgent property provided in the Webview component on Android isn't being properly set in the interceptor, now it should use the provided property value and fallback to the device user agent when this property is not defined.

Screenshots/Recordings

With userAgent property defined in WebView:

Screen Shot 2022-08-10 at 10 46 30

Without userAgent property in WebView:

Screen Shot 2022-08-10 at 10 49 10

Related slack thread: https://consensys.slack.com/archives/CBW7S9FSN/p1659995161910989

Issue

Progresses #4829

Checklist

  • [ ] There is a related GitHub issue
  • [ ] Tests are included if applicable
  • [ ] Any added code is fully documented

Fatxx avatar Aug 10 '22 09:08 Fatxx

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

github-actions[bot] avatar Aug 10 '22 09:08 github-actions[bot]

This is working as expected for the on-ramp requirements 👍

wachunei avatar Aug 10 '22 16:08 wachunei