metamask-mobile icon indicating copy to clipboard operation
metamask-mobile copied to clipboard

Published 20 hours ago • verified publisher icon MetaMask

Refactor UpdateEIP1559Transaction Component

Open blackdevelopa opened this issue 3 years ago • 9 comments

Description There is very similar code spread across 5 components. The aim of this PR is to reduce the components to use as much common shared code as possible. This PR addresses the UpdateEIP1559Transaction screen. The changes in this PR shouldn't modify existing behaviour when QA'd. Check

Issue

Progresses https://github.com/MetaMask/mobile-planning/issues/272

Screenshots/Recordings

https://user-images.githubusercontent.com/29962968/183502389-cd07caf4-d07d-408a-a8e5-9053dcb53dcd.mov

Issue

Progresses https://github.com/metamask/mobile-planning/issues/272

Checklist

  • [ ] There is a related GitHub issue
  • [ ] Tests are included if applicable
  • [ ] Any added code is fully documented

blackdevelopa avatar Aug 04 '22 17:08 blackdevelopa

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

github-actions[bot] avatar Aug 04 '22 17:08 github-actions[bot]

Works for test networks...

  • Rinkeby
  • Groeli

Not able to see transactions for

  • Binance
  • Polygon

https://recordit.co/AOcQTSurhz

UPDATE: Transactions are now showing as of 8/19.

chrisleewilcox avatar Aug 19 '22 14:08 chrisleewilcox

Hey Chris, can we have a sync on this?

blackdevelopa avatar Aug 19 '22 16:08 blackdevelopa

"Submitted" transactions are not updating to "Completed" when blockchain shows success. When transaction is in this stated the "Speed Up" and "Cancel" will always show popup for retry but retry fails because transactions is already completed. https://recordit.co/PrmH6nkGiB

chrisleewilcox avatar Aug 19 '22 17:08 chrisleewilcox

I am working with the stability team (Tomas) on this. It seems to happen on production (bnb network) as well. Eth network is fine and can be tested.

blackdevelopa avatar Aug 22 '22 12:08 blackdevelopa

I am only seeing the submitted transactions to "Speed Up" or "Cancel" on Rinkeby. I am not seeing transactions that are submitted but have not been confirmed and being able to speed up or cancel. I am adjusting the fee's level to "Low" to help increase the delay of the transaction. On other networks the transaction is only displayed when it is "Confirmed".

Expected that we can see submitted transactions on all networks before transactions are completed.

chrisleewilcox avatar Aug 23 '22 16:08 chrisleewilcox

This is not ready for QA. In order to properly test this transactions on all supported blockchain networks need to be working as expected. Currently we have issues with transactions on non-ETH/Rinkeby networks. Removing release label because we cannot plan to release this until transactions are working as expected on all supported networks.

chrisleewilcox avatar Aug 30 '22 17:08 chrisleewilcox

Can you provide a recording for the other networks just like you did for Rinkeby?

chrisleewilcox avatar Sep 13 '22 03:09 chrisleewilcox

Polygon Network https://user-images.githubusercontent.com/29962968/189893719-850c2be6-287d-4e09-b742-0af514204a4d.mov

Mainnet https://recordit.co/T3hPIobr2k

blackdevelopa avatar Sep 13 '22 11:09 blackdevelopa