metamask-mobile icon indicating copy to clipboard operation
metamask-mobile copied to clipboard

[FIX] Reveal SRP or Private Key wrong password error

Open gantunesr opened this issue 3 years ago • 1 comments

Description

Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions,

1. What is the reason for the change? While trying to reveal the SRP or Private Key, if the user enters the wrong password the app would still display the "Hold To Reveal" component.

2. What is the improvement/solution? This PR validates the password before allowing the user to proceed.

Screenshots/Recordings

If applicable, add screenshots and/or recordings to visualize the before and after of your change

https://user-images.githubusercontent.com/17601467/182950360-9889dc69-f36c-4be2-bb2e-35c11df77a78.mov

Issue

Progresses https://github.com/MetaMask/metamask-mobile/issues/4781

Checklist

  • [x] There is a related GitHub issue
  • [ ] Tests are included if applicable
  • [ ] Any added code is fully documented

gantunesr avatar Aug 04 '22 03:08 gantunesr

In reference to https://github.com/MetaMask/metamask-mobile/pull/4799#pullrequestreview-1062591772

You're right @Cal-L, I just added an improvement in 440cfa7

gantunesr avatar Aug 05 '22 14:08 gantunesr