metamask-mobile
metamask-mobile copied to clipboard
MetaMask
When revealing the SRP the "Next" button should only be active with a correct password and the reveal dialog should be tied to the "Next" button.
Describe the bug A clear and concise description of what the bug is There's a couple of problems with the current "hold to reveal" user journey with the SRP.
-
When the incorrect password is inputted a user is still prompted to "hold to reveal". https://user-images.githubusercontent.com/7900773/182242444-46f920df-11e2-429c-ade0-843013084b2f.MP4
-
The "Next" button becomes active even with an incorrect password, even when the user has simply inputted one character. https://user-images.githubusercontent.com/7900773/182243250-63984a5c-0a13-4f28-9409-6f6915a7322b.mov
-
The "Return" button on the keyboard acts the same as the "Next" button, so leads to the "hold to reveal" dialog https://user-images.githubusercontent.com/7900773/182243855-287ab033-314d-4652-977f-dfb784f85942.MP4
Screenshots If applicable, add screenshots or links to help explain your problem
See above.
To Reproduce See above.
Expected behavior A clear and concise description of what you expected to happen
- The "Next" button on the "Reveal Secret Recovery Phrase" should be disabled until a correct password is inputted on the page.
- The "hold to reveal" dialog should only be accessible via tapping an active "Next" button and not via the keyboard or any other mechanism.
These changes should not only improv the user experience of this user journey but also allow us to track this user journey more accurately.
Smartphone (please complete the following information):
- Device: [e.g. iPhone6] 13 pro
- OS: [e.g. iOS8.1] 15.5
- App Version [e.g. 1.0.0] - find version number in app from Settings > About MetaMask 5.3.1
to be added after bug submission by internal support / PM Severity
- How critical is the impact of this bug on a user?
- Add stats if available on % of customers impacted
- Is this visible to all users?
- Is this tech debt?
relates to https://github.com/MetaMask/metamask-mobile/issues/3829
Should we close 3829 @AlexJupiter @gantunesr ??
