metamask-mobile icon indicating copy to clipboard operation
metamask-mobile copied to clipboard

Attempting to reconnect WalletConnect older sessions

Open wsf11 opened this issue 3 years ago • 2 comments

Describe the bug Each time a WC session is initiated, the app tries to reconnect to existing (older sessions). If you have many sessions, this causes many connections to be made. This can cause DDos behavior towards Relay Servers or bad ux as there are many WebSocket connections attempting to be made at once

Screenshots If applicable, add screenshots or links to help explain your problem

To Reproduce Steps to reproduce the behavior

  1. Connect to a DApp
  2. Monitor your application traffic to see the WebSocket connections being made to old connections

Expected behavior Old WC Connections should have a TTL or cleaned up after some time.

Smartphone (please complete the following information):

  • Device: iPhone 12 Pro
  • OS: iOS 15.5
  • App Version 5.4.0

to be added after bug submission by internal support / PM Severity

  • How critical is the impact of this bug on a user?
  • Add stats if available on % of customers impacted
  • Is this visible to all users?
  • Is this tech debt?

wsf11 avatar Jul 29 '22 19:07 wsf11

Cannot find inpagebridgeweb3.js? How to inject Web3?

AdelaDella avatar Jul 31 '22 08:07 AdelaDella

I also am seeing multiple websocket connects for the same topic, with no websocket disconnects. Is this related?

wsf11 avatar Aug 15 '22 16:08 wsf11