metamask-mobile icon indicating copy to clipboard operation
metamask-mobile copied to clipboard

Published 20 hours ago • verified publisher icon MetaMask

Refactoring transaction components

Open blackdevelopa opened this issue 3 years ago • 1 comments

Description There is very similar code spread across 5 components. The aim of this PR is to reduce the components to use as much common shared code as possible. These components are

  1. SendFlow
  2. UpdateEIP1559Tx
  3. Approval
  4. Approve
  5. Swaps

This PR is still in progress and will be updated when all completed.

Screenshots/Recordings

If applicable, add screenshots and/or recordings to visualize the before and after of your change

Issue

Progresses https://app.zenhub.com/workspaces/metamask-mobile-5f984938ddc0e4001d4b79cb/issues/metamask/mobile-planning/269 https://app.zenhub.com/workspaces/metamask-mobile-5f984938ddc0e4001d4b79cb/issues/metamask/mobile-planning/272

Checklist

  • [ ] There is a related GitHub issue
  • [ ] Tests are included if applicable
  • [ ] Any added code is fully documented

blackdevelopa avatar Jul 28 '22 12:07 blackdevelopa

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

github-actions[bot] avatar Jul 28 '22 12:07 github-actions[bot]