metamask-mobile
metamask-mobile copied to clipboard
Android deeplink approve modal changes network and works
Description When deeplink to send funds it's pressed and it's needed to change the network, it would only change the network and do not show the approve modal.
Proposed Solution The approve modal appears Remove unused code
Code impact Low
Screenshots/Recordings Recordings of solution: With two devices (Huawei P30 pro and Samsung A22, both Android 12) https://recordit.co/NpxyGiXbVD With one device: https://user-images.githubusercontent.com/46944231/179568171-cb51ae76-c784-43bb-bedf-8b584cbdd06f.mp4
Test Cases Case1:
- Select ethereum mainnet as your network
- Open this deeplink
- Notice that the network changed and the modal is openning
Issue
Progresses #3880
Checklist
- [ ] There is a related GitHub issue
- [ ] Tests are included if applicable
- [ ] Any added code is fully documented
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.
Tested on two Androids, Samsung and Huawei, both Android 12 (Samsung needed to add the opening links on settings to be working) https://recordit.co/NpxyGiXbVD
Convert this to a draft, still needs development
I'm not able to replicate the issue on this PR issue, it needs to be an Android 12 device
Closing this PR since it doesn't solve the issue