metamask-mobile icon indicating copy to clipboard operation
metamask-mobile copied to clipboard

Android deeplink approve modal changes network and works

Open tommasini opened this issue 3 years ago • 2 comments

Description When deeplink to send funds it's pressed and it's needed to change the network, it would only change the network and do not show the approve modal.

Proposed Solution The approve modal appears Remove unused code

Code impact Low

Screenshots/Recordings Recordings of solution: With two devices (Huawei P30 pro and Samsung A22, both Android 12) https://recordit.co/NpxyGiXbVD With one device: https://user-images.githubusercontent.com/46944231/179568171-cb51ae76-c784-43bb-bedf-8b584cbdd06f.mp4

Test Cases Case1:

  • Select ethereum mainnet as your network
  • Open this deeplink
  • Notice that the network changed and the modal is openning

Issue

Progresses #3880

Checklist

  • [ ] There is a related GitHub issue
  • [ ] Tests are included if applicable
  • [ ] Any added code is fully documented

tommasini avatar Jul 18 '22 17:07 tommasini

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

github-actions[bot] avatar Jul 18 '22 17:07 github-actions[bot]

Tested on two Androids, Samsung and Huawei, both Android 12 (Samsung needed to add the opening links on settings to be working) https://recordit.co/NpxyGiXbVD

tommasini avatar Jul 28 '22 22:07 tommasini

Convert this to a draft, still needs development

tommasini avatar Nov 29 '22 17:11 tommasini

I'm not able to replicate the issue on this PR issue, it needs to be an Android 12 device

tommasini avatar Dec 13 '22 15:12 tommasini

Closing this PR since it doesn't solve the issue

tommasini avatar Mar 02 '23 02:03 tommasini