metamask-mobile icon indicating copy to clipboard operation
metamask-mobile copied to clipboard

[IMPROVEMENT] - Apply Test network prefix to token values to help educate users

Open sethkfman opened this issue 3 years ago • 4 comments

Description

This ticket is for UI improvements to the way we display ETH on testnets. We are prefixing the ETH ticker with the specific testnet.

Screenshots/Recordings

https://user-images.githubusercontent.com/10342624/182242497-c83924b8-e38b-4f04-9178-9c5cefc54d05.mp4

Checklist

  • [X] There is a related GitHub issue
  • [X] Tests are included if applicable
  • [X] Any added code is fully documented

sethkfman avatar Jun 17 '22 20:06 sethkfman

CLA Signature Action:

Thank you for your submission, we really appreciate it. We ask that you all read and sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just by adding a comment to this pull request with this exact sentence:

I have read the CLA Document and I hereby sign the CLA

By commenting with the above message you are agreeing to the terms of the CLA. Your account will be recorded as agreeing to our CLA so you don't need to sign it again for future contributions to this repository.

10 out of 11 committers have signed the CLA. :white_check_mark: @sethkfman :white_check_mark: @Fatxx :white_check_mark: @georgewrmarshall :white_check_mark: @AkshayBhimani :white_check_mark: @tommasini :white_check_mark: @blackdevelopa :white_check_mark: @chrisleewilcox :white_check_mark: @bentobox19 :white_check_mark: @Cal-L :white_check_mark: @jpcloureiro :x: @Seth Kaufman

GitHub can't find an account for Seth Kaufman. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.

github-actions[bot] avatar Jun 17 '22 20:06 github-actions[bot]

I have read the CLA Document and I hereby sign the CLA

sethkfman avatar Aug 01 '22 20:08 sethkfman

CW1: Blockexplorer scan link on test networks show 'undefined'

Activity > scroll to bottom > link "View full history on undefined" Token view > scroll to bottomw > link "View full history on undefined"

UPDATE: this was caused by 4780 and a fix will be provided.

chrisleewilcox avatar Aug 08 '22 21:08 chrisleewilcox

~CW2: Some screens that still show fiat balance...~

  • Wallet view
  • Left nav under account
  • Token view

Based on the original issue the expectation is that we will not show fiat balance or zero for fiat balance on test networks. Recording of Send flow on Goerli test network.

Recording of Receive flow on Goerli test network.

UPDATE: it was mentioned above for these views that they will show the fiat balance for now. Will address in future.

chrisleewilcox avatar Aug 08 '22 21:08 chrisleewilcox