metamask-mobile icon indicating copy to clipboard operation
metamask-mobile copied to clipboard

Swipe to swap/swipe to confirm triggers navigation "go back to previous screen" behaviour

Open mobularay opened this issue 3 years ago • 3 comments

Describe the bug "Swipe to confirm" function is interrupted by "swipe to go back one screen" navigation function. Reported by the head of Coinbase Cloud. Slack thread: https://consensys.slack.com/archives/C0354T27M5M/p1652113374435429

Screenshots swipe to go back

To Reproduce

  1. Go to confirm swap UI
  2. Swipe the button "Swipe to swap"
  3. The swipe movement on the UI screen triggers the "go back previous screen" navigation function

Expected behavior Swiping the "Swipe to swap" button actually does its job of confirming the user's intent to swap!

Smartphone (please complete the following information):

  • Device: tbd
  • OS: tbd
  • App Version [e.g. 1.0.0] - find version number in app from Settings > About MetaMask

to be added after bug submission by internal support / PM Severity

  • How critical is the impact of this bug on a user?
  • Add stats if available on % of customers impacted
  • Is this visible to all users?
  • Is this tech debt?

mobularay avatar May 20 '22 21:05 mobularay

@jakehaugen working on a new design solution for the button

Fatxx avatar Jul 05 '22 14:07 Fatxx

Design file: https://www.figma.com/file/983rUOWGgfg2cPG01DTRG5/Swaps?node-id=1239%3A4517

@Cal-L worked on a prototype of the animation for web but it will need to be recreated for mobile. Exact animation details are in the Figma but may need tweaks once we see it live in code. Happy to review once there is a first draft and we can fine tune as needed.

https://user-images.githubusercontent.com/11967476/178364195-630fe6db-3765-4e2b-a857-43a6cf50f74d.mov

jakehaugen avatar Jul 11 '22 21:07 jakehaugen

We're also using the "hold" interaction to reveal your SRP and Private Key. We should replace those buttons with this new one once it's ready. OR, we could choose to use the same "Hold" interaction we have built for Swap and address this pattern later.

jakehaugen avatar Jul 29 '22 18:07 jakehaugen

This issue has been automatically marked as stale because it has not had recent activity in the last 90 days. It will be closed in 7 days. Thank you for your contributions.

github-actions[bot] avatar Oct 14 '23 07:10 github-actions[bot]

This issue was closed because it has been stalled for 7 days with no activity. If you feel this was closed in error please reopen and provide evidence on the current production app. Thank you for your contributions.

github-actions[bot] avatar Oct 21 '23 07:10 github-actions[bot]