metamask-mobile icon indicating copy to clipboard operation
metamask-mobile copied to clipboard

[WIP] SES lockdown() - LavaMoat Compatibility

Open bentobox19 opened this issue 3 years ago • 5 comments

Compatibility Documentation: https://github.com/LavaMoat/docs/issues/1

  • Add ses dependency
    • Tell babel to ignore its transformation
    • Tell metro to accept a .cjs file as dependency entry point
  • Add SES lockdown() call
  • Modifications required for the application to work
    • Disable default integration in Sentry
    • Add patches
      • React Native to disable Promise polyfill
      • Metro React Native Babel Preset to disable two plugins
      • ethjs dependencies leveraging babel runtime
      • web3 dependency assigning a frozen intrinsic.

Extensive QA required ❗

bentobox19 avatar Feb 22 '22 07:02 bentobox19

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

github-actions[bot] avatar Feb 22 '22 07:02 github-actions[bot]

I have read the CLA Document and I hereby sign the CLA

bentobox19 avatar Feb 22 '22 07:02 bentobox19

Force pushed a shorter and cleaner version of the changes needed to run lockdown().

bentobox19 avatar Mar 19 '22 20:03 bentobox19

New force push

bentobox19 avatar Jun 08 '22 02:06 bentobox19

I have read the CLA Document and I hereby sign the CLA

bentobox19 avatar Aug 01 '22 19:08 bentobox19

Closed per sync with @bentobox19

gantunesr avatar Dec 19 '22 21:12 gantunesr

@bentobox19 @gantunesr Would you be able to share some context on this and the decision to close it?

legobeat avatar May 03 '23 05:05 legobeat