[ENHANCEMENT] Favorite Collectibles

[gantunesr]

Description

This development simplifies the Collectibles Favorite logic by adding a favorites property to the CollectibleMetadata object in the controllers.

⚠️ Blockers

• ~PR #3380~
• ~PR #3638~

Tasks

• [x] Remove previous favorite code.
• [x] Add controllers update
• [x] Update tests
• [x] Update snapshots (if necessary)
• [x] Update controllers version

QA Test Case

1. Upgrade the app from the previous release commit to this version and ensure that the favorites feature behaves as expect.
2. Favorites feature as expected, there should be no changes in the behaviour.

References

• MM Controllers PR

[github-actions[bot]]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[Cal-L]

Let's clear the conflicts

[gantunesr]

@Cal-L addressed your comments in f69c6e0 and de37439

[chrisleewilcox]

Scenario: Upgrade the app from the previous release commit to this version and ensure that the favorites feature behaves as expect.

Given I have multiple NFT's in my MetaMask mobile wallet And I have some NFT's as favorite When I upgrade MetaMask mobile And I navigate to Wallet And I tap NFT's tab Then all my NFT's are displayed And my NFT favorites are the same before upgrade When I add another NFT to favorites Then favorites list is displayed with recently favorited NFT When I remove an NFT from favorites Then favorites list is displayed without recently removed favorite NFT

This scenario is PASSED.

[chrisleewilcox]

NFT's images/content is not displaying. Will write up another issue to deal with it separately.

[chrisleewilcox]

Seeing an error after building and launching app on Android device.

https://recordit.co/JnggvKA6mx

Last time I ran into this issue I updated branch with main, rebuild and launch on android device. Branch is again out of sync with main. Will re-sync branch with main and try again.

UPDATE: updated main branch build to this PR branch and was able to reproduce the error above. This did not seem to cause any further issues. I was able to test the scenario described above and import NFTs on Rinkeby.

[chrisleewilcox]

Does this need to be tested with TestFlight and release apk from Bitrise?

[chrisleewilcox]

Conflict needs to be resolved. Also, we need determine if this can only be tested properly with a TestFlight or Bitrise build. If this can be tested in another way please advise.

[gantunesr]

@chrisleewilcox I'll provide the test bitrise builds today

[cortisiko]

I will remove the needs QA label on this guy for now. @gantunesr can you handle the merge conflicts and update this branch one last time?

cc @sethkfman

[gantunesr]

Stalled