metamask-mobile icon indicating copy to clipboard operation
metamask-mobile copied to clipboard

Fix/phishing-screen-ux-android

Open AugmentedMode opened this issue 1 month ago • 3 comments

Description

Changelog

CHANGELOG entry:

Related issues

Fixes:

Manual testing steps

Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

[!NOTE] Makes the phishing modal full-screen and switches its backdrop color to the background alternative for consistency.

  • UI/Phishing Modal:
    • Apply styles.fullScreenModal (flex: 1, margin: 0) to the modal in MultichainAccountConnect.tsx for full-screen rendering.
    • Change modal backdropColor from colors.error.default to colors.background.alternative.
  • Styles:
    • Add fullScreenModal style to AccountConnect.styles.ts and MultichainAccountConnect.styles.ts.
    • Use consistent background via bottomSheetBackground in AccountConnect.styles.ts (no logic changes).

Written by Cursor Bugbot for commit 11b1e292e3042e8bacf61214a8ae2f406052d0f8. This will update automatically on new commits. Configure here.

AugmentedMode avatar Dec 09 '25 20:12 AugmentedMode

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

github-actions[bot] avatar Dec 09 '25 20:12 github-actions[bot]

🔍 Smart E2E Test Selection

  • Selected E2E tags: None (no tests recommended)
  • Risk Level: low
  • AI Confidence: 90%
click to see 🤖 AI reasoning details

The changes are purely cosmetic - modifying the backdrop color of the phishing modal in two related components (AccountConnect and MultichainAccountConnect) from colors.error.default to colors.background.alternative.

Key observations:

  1. No functional changes: The phishing detection logic, account connection flow, and modal behavior remain completely unchanged
  2. UI-only modification: The backdrop color is a visual styling property that doesn't affect component functionality
  3. E2E tests don't verify colors: E2E tests verify functional behaviors (button clicks, navigation, text visibility), not CSS color values
  4. Isolated change scope: The change is in the renderPhishingModal callback, only affecting the visual appearance when a phishing site is detected
  5. Both files have identical changes: The same color substitution in both AccountConnect.tsx and MultichainAccountConnect.tsx, suggesting a coordinated UI consistency improvement

While these components are involved in account connection flows (which relate to SmokeMultiChainPermissions, SmokeNetworkExpansion tags), the actual change is a minimal styling adjustment that poses no risk to functionality. Running E2E tests for this change would provide no additional validation since they cannot verify color values.

View GitHub Actions results

github-actions[bot] avatar Dec 11 '25 19:12 github-actions[bot]