metamask-mobile icon indicating copy to clipboard operation
metamask-mobile copied to clipboard

[feat]: Solana Signin requests are not reflecting the domain supplied in requests

Open vandan opened this issue 6 months ago • 5 comments

Describe the bug

dapp-triggered signin requests are showing with “Unknown domain” even when the domain is supplied as a parameter in the signIn requests.

Expected behavior

Domain should be reflected in the confirmation for the Signin request.

Screenshots/Recordings

Image

Steps to reproduce

  1. Go to the mobile in-app browser
  2. Navigate to the multichain test dapp in a new tab
  3. Connect a Solana account/network
  4. Navigate to Connected Scopes once successfully connected
  5. Select "signIn" in the "Select a method" dropdown
  6. Trigger the request by choosing "Invoke Method"

Error messages or log output


Detection stage

On a feature branch

Version

7.46.99 (1897)

Build type

Other (please specify exactly where you obtained this build in "Additional Context" section)

Device

iPhone 13

Operating system

iOS

Additional context

Build from this feature branch: https://github.com/MetaMask/metamask-mobile/pull/15824

Severity

No response

vandan avatar Jun 02 '25 23:06 vandan

We are currently working on this, will update you with the progress

aganglada avatar Jun 03 '25 12:06 aganglada

Signin seems to be working from this test dapp: https://anza-xyz.github.io/wallet-adapter/example/ I'm wondering why signin would work differently from the multichain test dapp.

Image

vandan avatar Jun 04 '25 05:06 vandan

@vandan should we close this?

ziedbrini avatar Jun 11 '25 10:06 ziedbrini

I believe @aganglada is actively working on a fix for this

adonesky1 avatar Jun 11 '25 21:06 adonesky1

Yes, we are missing the last cherry pick to get this over the line, but on main should be fine

aganglada avatar Jun 17 '25 14:06 aganglada

Fixed in 7.49.0 (1977)

Image

aganglada avatar Jun 18 '25 15:06 aganglada