[feat]: Solana Signin requests are not reflecting the domain supplied in requests
Describe the bug
dapp-triggered signin requests are showing with “Unknown domain” even when the domain is supplied as a parameter in the signIn requests.
Expected behavior
Domain should be reflected in the confirmation for the Signin request.
Screenshots/Recordings
Steps to reproduce
- Go to the mobile in-app browser
- Navigate to the multichain test dapp in a new tab
- Connect a Solana account/network
- Navigate to Connected Scopes once successfully connected
- Select "signIn" in the "Select a method" dropdown
- Trigger the request by choosing "Invoke Method"
Error messages or log output
Detection stage
On a feature branch
Version
7.46.99 (1897)
Build type
Other (please specify exactly where you obtained this build in "Additional Context" section)
Device
iPhone 13
Operating system
iOS
Additional context
Build from this feature branch: https://github.com/MetaMask/metamask-mobile/pull/15824
Severity
No response
We are currently working on this, will update you with the progress
Signin seems to be working from this test dapp: https://anza-xyz.github.io/wallet-adapter/example/ I'm wondering why signin would work differently from the multichain test dapp.
@vandan should we close this?
I believe @aganglada is actively working on a fix for this
Yes, we are missing the last cherry pick to get this over the line, but on main should be fine
Fixed in 7.49.0 (1977)