metamask-mobile icon indicating copy to clipboard operation
metamask-mobile copied to clipboard

feat(2793): permission UI requirements from figma, avatar groups and other stuff

Open EtherWizard33 opened this issue 4 months ago • 5 comments

Description

This PR connects the avatar group used for account addresses:

  • in the initial connect to the dapp where these avatars represent the accounts the user is granting permission for the dapp to use
  • in the connected flow, where the dapp is already connected and those avatar represents accounts the user has already granted permission for the dapp to use

Related issues

Contributes to solve issue: https://github.com/MetaMask/MetaMask-planning/issues/2796

Manual testing steps

I have added screenshot below to see how it looks.

  1. Go to the in-app brower on the mobile wallet, connect to a dapp like uniswap
  2. Switch netowrk to a network for which permission was not added before
  3. A modal will show up and show have the same margin width on the right side as on the left side.

Screenshots/Recordings

Initial Connection Before Initial Connection After
Screenshot 2024-04-18 at 3 56 43 PM Screenshot 2024-04-18s at 3 56 43 PM
Already Connected Dapp Before Already Connected Dapp After
Screenshot 2024-04-18 at 3 56 43 PM Screenshot 2024-04-18s at 3 56 43 PM

Pre-merge author checklist

Pre-merge reviewer checklist

  • [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

EtherWizard33 avatar Oct 16 '24 20:10 EtherWizard33