fix: Upgrading Appium test failing
Description
Currently, both upgrading Appium test are failing on main. For MultipleAccounts.feature, when the test relogin to the app after upgrading to the app. This is happening because there is a step that execute the Android Back button. We need to remove that step.
For ConnectedTestNetwork.feature, the test are failing because whats new modal is not longer appearing after connected to the test network. We need to remove that step.
Related issues
Fixes:
Manual testing steps
- Go to this page...
Screenshots/Recordings
Before
After
Pre-merge author checklist
- [ ] I’ve followed MetaMask Contributor Docs and MetaMask Mobile Coding Standards.
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using JSDoc format if applicable
- [ ] I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
Pre-merge reviewer checklist
- [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
Bitrise
✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅
Commit hash: 0a99effc5b9d3e368ff23e4ba0ea0e649b4ad1e4 Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/d53babfd-e874-4cbf-9396-5c49281a1075
[!NOTE]
- You can kick off another
pr_smoke_e2e_pipelineon Bitrise by removing and re-applying theRun Smoke E2Elabel on the pull request
Could we run an upgrade test again this branch to verify this fix?
Bitrise
❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌
Commit hash: 18605e8e0cc407a14a7e7ff0c23aa57915010903 Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/628d8108-6d00-451d-b006-61508bfb6a28
[!NOTE]
- You can kick off another
pr_smoke_e2e_pipelineon Bitrise by removing and re-applying theRun Smoke E2Elabel on the pull request
Could we run an upgrade test again this branch to verify this fix?
@Cal-L the upgrading appium test passed, but the test run failed because of the core ios test suite failed. Apparently it was some setup issue Error: Unable to update lock within the stale threshold. I'll rerun it once again.
Bitrise
✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅
Commit hash: c4f3568058b5646c648597a4ca12298a78755097 Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/2dcfb59d-e042-4787-bbd8-b6dcc761d2ba
[!NOTE]
- You can kick off another
pr_smoke_e2e_pipelineon Bitrise by removing and re-applying theRun Smoke E2Elabel on the pull request
@Cal-L just passed the smoke test
@Cal-L https://app.bitrise.io/build/6d4eb117-a80c-4d7f-99f6-46354741a811 upgrade appium test
Quality Gate passed
Issues
0 New issues
0 Accepted issues
Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code