metamask-mobile icon indicating copy to clipboard operation
metamask-mobile copied to clipboard

[Refactor] Remove ListItemMultiSelectButton and Update CellMultiSelectWithMenu to be built off of CellMultiSelect

Open brianacnguyen opened this issue 8 months ago • 0 comments

What is this about?

This PR was merged without an approval from DS. Specifically, there were changes that needed to happen before the PR can be approved

  • CellSelectWithMenu should be named CellMultiSelectWithMenu since Select indicates single select
  • ListItemMultiSelectButton is not needed. CellMultiSelectWithMenu can be built off of CellMultiSelect since CellMultiSelect is built off of CellBase and ListItemMultiSelect, which is what youre doing

Scenario

No response

Design

No response

Technical Details

  • CellSelectWithMenu should be named CellMultiSelectWithMenu since Select indicates single select
  • ListItemMultiSelectButton is not needed. CellMultiSelectWithMenu can be built off of CellMultiSelect since CellMultiSelect is built off of CellBase and ListItemMultiSelect, which is what youre doing

Threat Modeling Framework

No response

Acceptance Criteria

No response

Stakeholder review needed before the work gets merged

  • [X] Engineering (needed in most cases)
  • [ ] Design
  • [ ] Product
  • [ ] QA (automation tests are required to pass before merging PRs but not all changes are covered by automation tests - please review if QA is needed beyond automation tests)
  • [ ] Security
  • [ ] Legal
  • [ ] Marketing
  • [ ] Management (please specify)
  • [ ] Other (please specify)

References

No response

brianacnguyen avatar Jun 27 '24 23:06 brianacnguyen