metamask-filecoin-developer-beta icon indicating copy to clipboard operation
metamask-filecoin-developer-beta copied to clipboard

Fix browser-specific manifest generation

Open MakMuftic opened this issue 3 years ago • 0 comments

Describe the bug Code for merging _base.json manifest and some browser-specific manifest like chrome.json is not working properly when there is property which value is array defined in both manifests.

Steps to reproduce (REQUIRED)

  1. Define one additional permission in the browser-specific manifest, let's say in chrome.json
  2. Run yarn dist
  3. Check generated manifest for chrome, permission in chrome.json override first permissions from _base.json

Expected behavior For upper example, generated manifest for chrome should have all permissions from _base.json and additionally permission defined in chrome.json.

In a broader sense, if the same property (array value) is defined in base and the browser-specific manifest resulting manifest should hold all array elements from both _base.json and browser-specific manifest (also should check for duplicates).

MakMuftic avatar Oct 04 '21 14:10 MakMuftic