metamask-filecoin-developer-beta
metamask-filecoin-developer-beta copied to clipboard
Fix browser-specific manifest generation
Describe the bug
Code for merging _base.json
manifest and some browser-specific manifest like chrome.json
is not working properly when there is property which value is array defined in both manifests.
Steps to reproduce (REQUIRED)
- Define one additional permission in the browser-specific manifest, let's say in
chrome.json
- Run
yarn dist
- Check generated manifest for chrome, permission in
chrome.json
override first permissions from_base.json
Expected behavior
For upper example, generated manifest for chrome should have all permissions from _base.json
and additionally permission defined in chrome.json
.
In a broader sense, if the same property (array value) is defined in base and the browser-specific manifest resulting manifest should hold all array elements from both _base.json
and browser-specific manifest (also should check for duplicates).