metamask-extension icon indicating copy to clipboard operation
metamask-extension copied to clipboard

Implement support for EIP-2831

Open danfinlay opened this issue 4 years ago • 8 comments

Once it's ready, this provider event will notify dapps when a transaction has been cancelled or replaced: https://eips.ethereum.org/EIPS/eip-2831

danfinlay avatar Aug 10 '20 18:08 danfinlay

Since this would be an event that would depend on permitted/connected accounts, it might merit integrating event-awareness into rpc-cap, probably as a dependent permission.

danfinlay avatar Sep 21 '20 23:09 danfinlay

I've made a few changes and revisions since early August, and I think we're add the "test it and break it" phase. For the updated spec you can find it here.

The main changes are that there are 3 transaction types now: tx_replacement (a general case), tx_speedup & tx_cancel.

I'll be tracking progress here, and will have a reference implementation made in web3.js within the next week.

GregTheGreek avatar Sep 21 '20 23:09 GregTheGreek

Hi! Thanks for working on implementation of this EIP. I'm curious whether there are any plans to cover the following scenario:

  1. User sends a transaction via a dapp
  2. User disconnects the wallet (i.e. closes the app)
  3. User speeds up the transaction, when the app is closed

When a user re-opens the app, will MetaMask fire the tx_replacement event about the transaction that the user speeded up when the app was closed?

vladbat00 avatar May 12 '21 12:05 vladbat00

Any chance this might get implemented. I've been chatting with a lot of folks lately who would still find this useful

GregTheGreek avatar Nov 10 '21 17:11 GregTheGreek

Bump: Interested. Would be very useful

0xGizmo avatar Jan 13 '22 01:01 0xGizmo

Bump 👍

JayArrowz avatar Jun 09 '22 22:06 JayArrowz

any update??

karthisriramulu avatar Jul 20 '22 09:07 karthisriramulu

would be great to have it, anyways would be any other way to detect when a transaction is sped up?

davigp avatar Aug 03 '22 13:08 davigp

is EIP-2831 already implemented ? When a user speeds up the transaction multiple times, how can i continually get the new transaction hash?

tiff0000 avatar Oct 28 '22 05:10 tiff0000

hiiiii @rekmarks

GregTheGreek avatar Nov 01 '22 14:11 GregTheGreek