fix: fixed subscription_state value for Subscription Request Metrics

[lwin-kyaw]

Description

Changelog

CHANGELOG entry: fixed shield subscription request metrics

Related issues

Fixes: https://github.com/MetaMask/metamask-extension/issues/38728

Manual testing steps

1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

• [ ] I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
• [ ] I've completed the PR template to the best of my ability
• [ ] I’ve included tests if applicable
• [ ] I’ve documented my code using JSDoc format if applicable
• [ ] I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

---

[!NOTE] Replaces subscription_state with a new enum (new|renew) and updates metrics logic and UI types to use it.

• Shared constants:
  • Add ShieldSubscriptionRequestSubscriptionStateEnum with new and renew.
• Shield metrics (shared/modules/shield/metrics.ts):
  • Update getLatestSubscriptionStatus to return ShieldSubscriptionRequestSubscriptionStateEnum (renew if any prior/current subscription, else new).
  • Wire subscription_state in tracking props to the new enum.
• UI types (ui/hooks/shield/metrics/types.ts):
  • Change CaptureShieldSubscriptionRequestParams.subscriptionState to ShieldSubscriptionRequestSubscriptionStateEnum.

^{Written by Cursor Bugbot for commit dd8835760d5282c8fcf423d3b35270b91eb9eed3. This will update automatically on new commits. Configure here.}

[github-actions[bot]]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[metamaskbot]

Builds ready [dd88357]

• builds: chrome, firefox
• builds (beta): chrome, firefox
• builds (flask): chrome, firefox
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• bundle size: Bundle Size Stats
• user-actions-benchmark: User Actions Stats
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
  • common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15
  • ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18
  • content-script: 0
  • offscreen: 0

UI Startup Metrics (1276 ± 101 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Standard Home	uiStartup	1276	1055	1582	101	1348	1448
			load	1039	869	1310	85	1083	1181
			domContentLoaded	1032	863	1303	85	1076	1173
			domInteractive	26	16	126	22	22	94
			firstPaint	531	94	1323	411	1025	1184
			backgroundConnect	216	197	254	11	224	240
			firstReactRender	40	30	122	11	41	64
			getState	35	18	120	18	38	81
			initialActions	1	0	4	1	1	2
			loadScripts	823	661	1075	82	858	969
			setupStore	10	7	21	3	11	17
			numNetworkReqs	13	6	79	19	6	69
	Browserify	Power User Home	uiStartup	1909	1554	2325	160	1990	2230
			load	1074	880	1383	128	1192	1291
			domContentLoaded	1064	875	1371	128	1176	1281
			domInteractive	31	17	132	24	28	96
			firstPaint	608	105	1403	425	1022	1245
			backgroundConnect	254	202	800	107	230	562
			firstReactRender	47	36	74	5	49	56
			getState	193	145	754	64	205	250
			initialActions	1	0	2	1	1	2
			loadScripts	853	678	1149	125	969	1066
			setupStore	16	6	47	8	14	36
			numNetworkReqs	71	57	148	20	67	132
	Webpack	Standard Home	uiStartup	802	673	1106	74	843	945
			load	646	573	812	65	686	785
			domContentLoaded	640	567	806	65	681	779
			domInteractive	27	14	109	23	22	96
			firstPaint	249	82	784	178	239	686
			backgroundConnect	11	6	33	6	13	29
			firstReactRender	50	32	132	24	61	120
			getState	29	14	62	11	39	49
			initialActions	1	0	5	1	1	3
			loadScripts	637	564	798	64	679	770
			setupStore	12	5	35	6	13	27
			numNetworkReqs	13	6	84	20	6	70
	Webpack	Power User Home	uiStartup	1464	1110	1962	189	1605	1774
			load	757	603	996	108	860	920
			domContentLoaded	748	597	984	107	850	910
			domInteractive	32	16	147	26	27	103
			firstPaint	274	91	828	193	296	749
			backgroundConnect	87	9	629	177	26	559
			firstReactRender	50	41	98	8	52	63
			getState	197	140	373	49	233	313
			initialActions	1	0	3	1	1	2
			loadScripts	745	594	981	106	846	904
			setupStore	18	7	108	13	18	39
			numNetworkReqs	70	57	144	21	66	131
Firefox	Browserify	Standard Home	uiStartup	1361	1132	1936	156	1432	1618
			load	1088	943	1313	85	1140	1247
			domContentLoaded	1088	940	1312	85	1140	1247
			domInteractive	71	34	188	35	92	138
			firstPaint	-	-	-	-	-	-
			backgroundConnect	55	24	229	39	69	152
			firstReactRender	40	31	67	9	43	62
			getState	11	6	34	5	10	24
			initialActions	1	0	3	1	2	2
			loadScripts	1057	927	1232	74	1112	1199
			setupStore	20	6	254	35	13	81
			numNetworkReqs	15	6	80	21	7	75
	Browserify	Power User Home	uiStartup	2645	1608	3958	522	3032	3356
			load	1651	1000	2575	453	2060	2220
			domContentLoaded	1651	1000	2575	453	2060	2220
			domInteractive	193	31	1172	308	152	983
			firstPaint	-	-	-	-	-	-
			backgroundConnect	200	26	1127	229	210	928
			firstReactRender	54	37	118	13	59	84
			getState	135	65	976	95	154	197
			initialActions	3	1	38	5	2	7
			loadScripts	1568	955	2463	441	1979	2191
			setupStore	55	4	1067	149	45	200
			numNetworkReqs	74	57	139	22	74	125
	Webpack	Standard Home	uiStartup	1572	1326	2227	163	1651	1902
			load	1293	1136	1647	106	1326	1539
			domContentLoaded	1293	1136	1646	106	1326	1538
			domInteractive	85	30	290	42	114	149
			firstPaint	-	-	-	-	-	-
			backgroundConnect	59	20	165	38	78	141
			firstReactRender	42	34	93	7	45	52
			getState	16	7	121	20	15	43
			initialActions	1	0	3	1	2	2
			loadScripts	1264	1107	1625	96	1303	1462
			setupStore	19	6	187	23	16	68
			numNetworkReqs	16	6	89	22	8	80
	Webpack	Power User Home	uiStartup	2784	1824	3876	541	3222	3625
			load	1908	1183	2845	523	2365	2687
			domContentLoaded	1907	1182	2845	523	2364	2687
			domInteractive	264	31	1024	362	250	994
			firstPaint	-	-	-	-	-	-
			backgroundConnect	149	27	1036	165	201	296
			firstReactRender	61	41	108	15	67	97
			getState	134	70	307	52	157	253
			initialActions	2	0	8	1	2	4
			loadScripts	1841	1155	2821	505	2287	2621
			setupStore	31	4	374	47	34	107
			numNetworkReqs	75	56	135	24	67	127

📊 Page Load Benchmark Results

Current Commit: dd88357 | Date: 12/10/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

• pageLoadTime-> current mean value: 1.02s (±46ms) 🟡 | historical mean value: 1.03s ⬇️ (historical data)
• domContentLoaded-> current mean value: 715ms (±59ms) 🟢 | historical mean value: 717ms ⬇️ (historical data)
• firstContentfulPaint-> current mean value: 86ms (±125ms) 🟢 | historical mean value: 77ms ⬆️ (historical data)

📈 Detailed Results

Metric	Mean	Std Dev	Min	Max	P95	P99
pageLoadTime	1.02s	46ms	1.00s	1.42s	1.04s	1.42s
domContentLoaded	715ms	59ms	696ms	1.26s	730ms	1.26s
firstPaint	86ms	125ms	56ms	1.33s	80ms	1.33s
firstContentfulPaint	86ms	125ms	56ms	1.33s	80ms	1.33s
largestContentfulPaint	0ms	0ms	0ms	0ms	0ms	0ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]

• background: 58 Bytes (0%)
• ui: 0 Bytes (0%)
• common: 206 Bytes (0%)

[metamaskbot]

✨ Files requiring CODEOWNER review ✨

🔐 @MetaMask/web3auth (4 files, +18 -9)

• 📁 shared/
  • 📁 lib/
    • 📄 shield.ts +2 -2
• 📁 ui/
  • 📁 components/
    • 📁 app/
      • 📁 shield-entry-modal/
        • 📄 shield-entry-modal.tsx +5 -2
  • 📁 hooks/
    • 📁 subscription/
      • 📄 useSubscription.ts +10 -5
  • 📁 pages/
    • 📁 shield-plan/
      • 📄 shield-plan.tsx +1 -0

[metamaskbot]

Builds ready [6ba6227]

• builds: chrome, firefox
• builds (beta): chrome, firefox
• builds (flask): chrome, firefox
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• bundle size: Bundle Size Stats
• user-actions-benchmark: User Actions Stats
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
  • common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15
  • ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18
  • content-script: 0
  • offscreen: 0

UI Startup Metrics (1266 ± 110 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Standard Home	uiStartup	1266	1019	1618	110	1330	1492
			load	1034	859	1315	93	1083	1191
			domContentLoaded	1028	852	1311	92	1077	1185
			domInteractive	26	16	100	20	22	86
			firstPaint	499	76	1251	392	1003	1129
			backgroundConnect	213	194	244	12	218	238
			firstReactRender	48	31	79	13	56	75
			getState	37	16	138	19	42	58
			initialActions	1	0	11	2	1	3
			loadScripts	822	656	1084	89	869	967
			setupStore	12	7	82	8	13	20
			numNetworkReqs	13	6	79	19	6	70
	Browserify	Power User Home	uiStartup	1919	1546	2448	156	2004	2201
			load	1096	876	1530	136	1187	1358
			domContentLoaded	1086	869	1522	135	1181	1336
			domInteractive	31	17	132	24	27	92
			firstPaint	607	133	1564	455	1067	1350
			backgroundConnect	252	200	629	95	235	587
			firstReactRender	47	39	74	5	48	56
			getState	207	144	730	95	206	278
			initialActions	1	0	3	1	1	2
			loadScripts	871	675	1282	133	961	1128
			setupStore	14	7	37	6	14	33
			numNetworkReqs	71	58	132	19	69	128
	Webpack	Standard Home	uiStartup	818	671	1151	92	860	1021
			load	654	562	860	75	712	803
			domContentLoaded	648	557	853	74	706	794
			domInteractive	26	14	103	19	23	78
			firstPaint	270	77	772	189	270	706
			backgroundConnect	12	5	116	12	14	29
			firstReactRender	54	33	212	31	61	128
			getState	28	13	65	13	35	60
			initialActions	1	0	4	1	1	3
			loadScripts	645	552	850	73	703	785
			setupStore	12	6	41	6	14	28
			numNetworkReqs	14	6	83	21	6	78
	Webpack	Power User Home	uiStartup	1393	1052	2060	207	1573	1742
			load	708	566	1068	99	790	882
			domContentLoaded	702	560	1060	98	774	872
			domInteractive	30	17	135	24	26	104
			firstPaint	322	75	1073	241	321	858
			backgroundConnect	74	8	633	136	84	566
			firstReactRender	50	40	74	6	53	59
			getState	197	147	649	57	209	273
			initialActions	1	0	2	0	1	2
			loadScripts	699	558	1051	97	772	870
			setupStore	16	9	50	10	14	37
			numNetworkReqs	71	56	224	27	67	143
Firefox	Browserify	Standard Home	uiStartup	1438	1118	2508	227	1519	1872
			load	1132	941	2143	150	1183	1277
			domContentLoaded	1131	941	2143	150	1182	1277
			domInteractive	69	32	185	36	88	140
			firstPaint	-	-	-	-	-	-
			backgroundConnect	62	22	292	52	76	203
			firstReactRender	42	31	80	9	44	64
			getState	24	7	812	84	13	37
			initialActions	1	0	2	1	2	2
			loadScripts	1101	923	2053	144	1154	1241
			setupStore	15	5	120	17	12	52
			numNetworkReqs	15	6	80	20	8	75
	Browserify	Power User Home	uiStartup	2611	1573	4607	594	3077	3500
			load	1634	945	2730	511	2088	2418
			domContentLoaded	1634	945	2730	511	2087	2418
			domInteractive	182	31	1052	296	99	983
			firstPaint	-	-	-	-	-	-
			backgroundConnect	180	19	1084	206	206	885
			firstReactRender	53	33	184	17	57	77
			getState	149	63	1034	105	164	293
			initialActions	2	0	32	3	2	3
			loadScripts	1569	928	2584	484	1999	2316
			setupStore	54	4	1019	121	49	240
			numNetworkReqs	75	57	134	22	80	127
	Webpack	Standard Home	uiStartup	1581	1328	2165	176	1654	2018
			load	1300	1109	1705	109	1355	1495
			domContentLoaded	1299	1109	1705	109	1355	1495
			domInteractive	69	28	141	34	92	131
			firstPaint	-	-	-	-	-	-
			backgroundConnect	58	21	239	40	62	139
			firstReactRender	43	33	106	10	44	56
			getState	15	7	146	18	13	40
			initialActions	1	0	3	1	2	2
			loadScripts	1272	1089	1588	101	1332	1450
			setupStore	21	6	204	33	14	106
			numNetworkReqs	15	6	81	20	8	73
	Webpack	Power User Home	uiStartup	2709	1661	4766	606	3110	3847
			load	1835	1115	3697	569	2319	2834
			domContentLoaded	1834	1114	3696	569	2319	2834
			domInteractive	232	29	1106	346	174	1007
			firstPaint	-	-	-	-	-	-
			backgroundConnect	199	27	1120	280	205	1002
			firstReactRender	55	36	218	20	58	88
			getState	132	73	476	60	162	240
			initialActions	3	1	136	14	2	3
			loadScripts	1737	1094	3521	524	2204	2640
			setupStore	49	4	1029	123	37	289
			numNetworkReqs	75	55	138	21	82	130

📊 Page Load Benchmark Results

Current Commit: 6ba6227 | Date: 12/11/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

• pageLoadTime-> current mean value: 1.04s (±41ms) 🟡 | historical mean value: 1.03s ⬆️ (historical data)
• domContentLoaded-> current mean value: 723ms (±38ms) 🟢 | historical mean value: 719ms ⬆️ (historical data)
• firstContentfulPaint-> current mean value: 77ms (±14ms) 🟢 | historical mean value: 76ms ⬆️ (historical data)

📈 Detailed Results

Metric	Mean	Std Dev	Min	Max	P95	P99
pageLoadTime	1.04s	41ms	1.01s	1.35s	1.07s	1.35s
domContentLoaded	723ms	38ms	697ms	1.02s	751ms	1.02s
firstPaint	77ms	14ms	60ms	204ms	88ms	204ms
firstContentfulPaint	77ms	14ms	60ms	204ms	88ms	204ms
largestContentfulPaint	0ms	0ms	0ms	0ms	0ms	0ms

Bundle size diffs [🚀 Bundle size reduced!]

• background: -153.48 KiB (-2.91%)
• ui: 3.8 KiB (0.05%)
• common: 2.04 KiB (0.02%)

[metamaskbot]

Builds ready [94e6ad0]

• builds: chrome, firefox
• builds (beta): chrome, firefox
• builds (flask): chrome, firefox
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• bundle size: Bundle Size Stats
• user-actions-benchmark: User Actions Stats
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
  • common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15
  • ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18
  • content-script: 0
  • offscreen: 0

UI Startup Metrics (1276 ± 96 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Standard Home	uiStartup	1276	1057	1512	96	1335	1443
			load	1051	871	1300	86	1107	1195
			domContentLoaded	1044	864	1281	85	1101	1182
			domInteractive	26	15	101	20	22	82
			firstPaint	545	89	1231	420	1052	1148
			backgroundConnect	221	198	260	13	227	247
			firstReactRender	48	31	97	15	53	81
			getState	39	18	110	17	47	75
			initialActions	1	0	7	1	1	4
			loadScripts	830	655	1066	82	879	968
			setupStore	13	6	61	7	14	30
			numNetworkReqs	13	6	74	18	6	67
	Browserify	Power User Home	uiStartup	1951	1593	2638	173	2043	2330
			load	1117	918	1423	120	1211	1349
			domContentLoaded	1105	909	1415	120	1189	1342
			domInteractive	33	18	127	24	29	99
			firstPaint	522	94	1438	402	979	1249
			backgroundConnect	249	208	618	75	247	523
			firstReactRender	49	42	62	5	53	59
			getState	216	156	753	96	220	316
			initialActions	1	0	2	1	1	2
			loadScripts	887	704	1172	116	970	1122
			setupStore	16	11	65	8	15	35
			numNetworkReqs	71	59	140	18	69	125
	Webpack	Standard Home	uiStartup	809	669	1036	87	864	990
			load	652	566	844	74	719	797
			domContentLoaded	647	560	840	73	714	790
			domInteractive	25	15	112	19	21	75
			firstPaint	253	81	839	184	231	707
			backgroundConnect	13	6	96	14	13	29
			firstReactRender	47	31	202	23	51	89
			getState	29	13	71	12	39	51
			initialActions	1	0	2	1	1	2
			loadScripts	644	558	838	72	704	788
			setupStore	11	5	38	6	12	26
			numNetworkReqs	13	6	80	19	6	72
	Webpack	Power User Home	uiStartup	1421	1090	1958	192	1615	1721
			load	744	593	1011	104	847	919
			domContentLoaded	736	588	1003	103	841	907
			domInteractive	30	16	113	22	26	98
			firstPaint	299	93	913	222	289	856
			backgroundConnect	86	8	642	161	84	569
			firstReactRender	49	40	79	6	50	62
			getState	206	142	711	95	217	332
			initialActions	1	0	4	1	1	1
			loadScripts	733	586	995	103	835	904
			setupStore	14	7	46	7	14	33
			numNetworkReqs	71	57	216	24	66	127
Firefox	Browserify	Standard Home	uiStartup	1314	1063	2234	222	1420	1763
			load	1049	902	1824	126	1109	1234
			domContentLoaded	1048	897	1824	126	1108	1234
			domInteractive	59	27	247	40	81	127
			firstPaint	-	-	-	-	-	-
			backgroundConnect	53	18	321	49	67	179
			firstReactRender	39	30	71	10	44	63
			getState	15	6	171	22	10	39
			initialActions	5	0	437	43	1	2
			loadScripts	1020	887	1802	118	1081	1200
			setupStore	16	6	175	23	11	63
			numNetworkReqs	15	6	85	21	8	76
	Browserify	Power User Home	uiStartup	2627	1636	3787	540	3043	3265
			load	1651	965	2684	499	2070	2348
			domContentLoaded	1651	962	2683	499	2070	2348
			domInteractive	102	30	972	164	75	367
			firstPaint	-	-	-	-	-	-
			backgroundConnect	190	23	1270	209	243	578
			firstReactRender	57	37	175	18	60	93
			getState	128	58	265	44	159	216
			initialActions	3	0	39	5	2	6
			loadScripts	1561	949	2487	459	1954	2244
			setupStore	53	4	1083	126	45	287
			numNetworkReqs	74	53	122	18	89	114
	Webpack	Standard Home	uiStartup	1536	1302	2124	156	1590	1892
			load	1268	1124	1605	95	1319	1469
			domContentLoaded	1268	1119	1605	95	1319	1469
			domInteractive	75	28	141	33	88	132
			firstPaint	-	-	-	-	-	-
			backgroundConnect	56	19	200	39	64	142
			firstReactRender	41	32	87	8	45	52
			getState	15	7	190	23	13	39
			initialActions	1	0	3	1	2	3
			loadScripts	1237	1101	1580	89	1286	1436
			setupStore	17	5	271	32	11	41
			numNetworkReqs	15	6	88	21	8	75
	Webpack	Power User Home	uiStartup	2609	1707	4147	534	2977	3519
			load	1838	1147	3364	496	2286	2570
			domContentLoaded	1838	1147	3364	496	2285	2570
			domInteractive	230	29	1138	342	170	1006
			firstPaint	-	-	-	-	-	-
			backgroundConnect	170	25	1078	225	192	958
			firstReactRender	54	36	127	14	58	85
			getState	128	72	357	49	160	222
			initialActions	3	0	40	6	2	7
			loadScripts	1753	1121	2576	455	2211	2458
			setupStore	30	4	272	46	26	169
			numNetworkReqs	74	56	133	22	80	129

📊 Page Load Benchmark Results

Current Commit: 94e6ad0 | Date: 12/11/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

• pageLoadTime-> current mean value: 1.05s (±41ms) 🟡 | historical mean value: 1.04s ⬆️ (historical data)
• domContentLoaded-> current mean value: 732ms (±38ms) 🟢 | historical mean value: 724ms ⬆️ (historical data)
• firstContentfulPaint-> current mean value: 78ms (±11ms) 🟢 | historical mean value: 77ms ⬆️ (historical data)

📈 Detailed Results

Metric	Mean	Std Dev	Min	Max	P95	P99
pageLoadTime	1.05s	41ms	1.02s	1.35s	1.08s	1.35s
domContentLoaded	732ms	38ms	706ms	1.01s	761ms	1.01s
firstPaint	78ms	11ms	60ms	168ms	88ms	168ms
firstContentfulPaint	78ms	11ms	60ms	168ms	88ms	168ms
largestContentfulPaint	0ms	0ms	0ms	0ms	0ms	0ms

Bundle size diffs [🚀 Bundle size reduced!]

• background: -153.46 KiB (-2.91%)
• ui: 3.8 KiB (0.05%)
• common: 2.04 KiB (0.02%)