metamask-extension icon indicating copy to clipboard operation
metamask-extension copied to clipboard

fix: import token design fixes

Open bergarces opened this issue 1 month ago • 3 comments

Description

  • Bolder text for an import token header
  • Fixed display of scam warning link

Open in GitHub Codespaces

Changelog

CHANGELOG entry: Fixed minor display issues with the import token dialog

Related issues

Fixes: https://consensyssoftware.atlassian.net/browse/ASSETS-2067 Fixes: https://consensyssoftware.atlassian.net/browse/ASSETS-2066

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

new-warning-link new-import-text

Pre-merge author checklist

Pre-merge reviewer checklist

  • [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

[!NOTE] Tightens import-tokens modal UI by boldening the confirmation header and fixing the scam warning link using TextButton-wrapped anchor.

  • UI:
    • Increase header emphasis in import-tokens-modal-confirm.js by setting Text fontWeight to Medium.
    • Update scam warning link in import-tokens-modal.js to use TextButton (wrapping an <a>), improving rendering and external link handling to ZENDESK_URLS.TOKEN_SAFETY_PRACTICES.

Written by Cursor Bugbot for commit 7a41450fa193c0d5f1cbbac07da77ce88b0f7455. This will update automatically on new commits. Configure here.

bergarces avatar Dec 10 '25 15:12 bergarces

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

github-actions[bot] avatar Dec 10 '25 15:12 github-actions[bot]

✨ Files requiring CODEOWNER review ✨

👨‍🔧 @MetaMask/core-extension-ux (2 files, +15 -7)
  • 📁 ui/
    • 📁 components/
      • 📁 multichain/
        • 📁 import-tokens-modal/
          • 📄 import-tokens-modal-confirm.js +1 -1
          • 📄 import-tokens-modal.js +14 -6

metamaskbot avatar Dec 10 '25 15:12 metamaskbot

Builds ready [7a41450]
UI Startup Metrics (1227 ± 104 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyStandard HomeuiStartup1227989148510413051366
load100584012058410661150
domContentLoaded99983611938310611146
domInteractive241590172176
firstPaint54183116440810141102
backgroundConnect20618724611213232
firstReactRender453096145474
getState3916120194764
initialActions105112
loadScripts79964898281862931
setupStore1163151321
numNetworkReqs1368420674
BrowserifyPower User HomeuiStartup19051555243616619692251
load1066880162612911241310
domContentLoaded1055872161112711171296
domInteractive3117166262596
firstPaint5398913193889721192
backgroundConnect25019771298231549
firstReactRender48388674961
getState204144768101206274
initialActions102112
loadScripts84467113771259051086
setupStore1674281536
numNetworkReqs71581442068130
WebpackStandard HomeuiStartup8236761567111863961
load65756692573700800
domContentLoaded65156192072692794
domInteractive2516101192288
firstPaint24988826188223746
backgroundConnect1154561328
firstReactRender50322042851118
getState301471123754
initialActions103112
loadScripts64855990971690786
setupStore1264361526
numNetworkReqs1368119672
WebpackPower User HomeuiStartup14791096212321916721852
load7646081073109876941
domContentLoaded7566011059108869929
domInteractive32171242527106
firstPaint313110914230311858
backgroundConnect59766612037225
firstReactRender52429065462
getState19815032340232265
initialActions102012
loadScripts7535991045107861927
setupStore196293291639
numNetworkReqs71571422067130
FirefoxBrowserifyStandard HomeuiStartup13991086245121715051835
load1122924208814011821288
domContentLoaded1122920208714011811288
domInteractive73322454390165
firstPaint------
backgroundConnect64233506273178
firstReactRender38309693949
getState147190191328
initialActions102012
loadScripts1087908199712811311261
setupStore1962303811109
numNetworkReqs1568321976
BrowserifyPower User HomeuiStartup25601525344751829643254
load1594965248248020252313
domContentLoaded1594965248248020182312
domInteractive12329127221192371
firstPaint------
backgroundConnect2302111192902101025
firstReactRender5536121155983
getState13261100995148185
initialActions3033523
loadScripts1478939231744518662263
setupStore35499510229125
numNetworkReqs75571352180124
WebpackStandard HomeuiStartup15471331204116716671938
load12851093175811313551504
domContentLoaded12851093175811313551504
domInteractive742721239100139
firstPaint------
backgroundConnect51171693369124
firstReactRender423290104755
getState177205281456
initialActions103112
loadScripts12561080169210613301435
setupStore174165231353
numNetworkReqs1669122879
WebpackPower User HomeuiStartup26521774384152030583453
load18721124279249923472548
domContentLoaded18711123279149923472547
domInteractive20929996321145967
firstPaint------
backgroundConnect13526938134180262
firstReactRender5836105156490
getState1368229750161240
initialActions207123
loadScripts18091100270347822342493
setupStore2742854823100
numNetworkReqs70451282079118
📊 Page Load Benchmark Results

Current Commit: 7a41450 | Date: 12/10/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

  • pageLoadTime-> current mean value: 1.05s (±63ms) 🟡 | historical mean value: 1.03s ⬆️ (historical data)
  • domContentLoaded-> current mean value: 737ms (±76ms) 🟢 | historical mean value: 720ms ⬆️ (historical data)
  • firstContentfulPaint-> current mean value: 88ms (±126ms) 🟢 | historical mean value: 78ms ⬆️ (historical data)

📈 Detailed Results

Metric Mean Std Dev Min Max P95 P99
pageLoadTime 1.05s 63ms 1.01s 1.34s 1.26s 1.34s
domContentLoaded 737ms 76ms 701ms 1.27s 937ms 1.27s
firstPaint 88ms 126ms 60ms 1.34s 84ms 1.34s
firstContentfulPaint 88ms 126ms 60ms 1.34s 84ms 1.34s
largestContentfulPaint 0ms 0ms 0ms 0ms 0ms 0ms
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 58 Bytes (0%)
  • ui: 170 Bytes (0%)
  • common: 20 Bytes (0%)

metamaskbot avatar Dec 10 '25 16:12 metamaskbot