metamask-extension
metamask-extension copied to clipboard
chore: adds staking tx mappings (non-evm)
Description
Show txs as "Staking Deposit" and "Staking Withdrawal" in the non‑EVM transaction history lists (useMultichainTransactionDisplay).
Changelog
CHANGELOG entry: null
Related issues
Fixes:
Manual testing steps
- Go to this page...
Screenshots/Recordings
Before
After
Pre-merge author checklist
- [ ] I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using JSDoc format if applicable
- [ ] I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
Pre-merge reviewer checklist
- [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
[!NOTE] Map staking deposit/withdraw transaction types in multichain views and add corresponding locale strings.
- Frontend:
- Map
TransactionType.StakeDepositandTransactionType.StakeWithdrawto titles inui/components/app/multichain-transaction-details-modal/multichain-transaction-details-modal.tsxandui/hooks/useMultichainTransactionDisplay.ts.- Localization:
- Add
stakingDepositandstakingWithdrawalstrings toapp/_locales/en/messages.jsonandapp/_locales/en_GB/messages.json.Written by Cursor Bugbot for commit 1a4a3799db391ebd817a3500061a11838060b7fc. This will update automatically on new commits. Configure here.
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.
Builds ready [1a4a379]
- builds: chrome, firefox
- builds (beta): chrome, firefox
- builds (flask): chrome, firefox
- builds (test): chrome, firefox
- builds (test-flask): chrome, firefox
- bundle size: Bundle Size Stats
- user-actions-benchmark: User Actions Stats
- storybook: Storybook
- typescript migration: Dashboard
- all artifacts
UI Startup Metrics (1323 ± 115 ms)
| Platform | BuildType | Page | Metric | Mean (ms) | Min (ms) | Max (ms) | Std Dev (ms) | P 75 (ms) | P 95 (ms) |
|---|---|---|---|---|---|---|---|---|---|
| Chrome | Browserify | Standard Home | uiStartup | 1323 | 1035 | 1691 | 115 | 1395 | 1513 |
| load | 1081 | 875 | 1449 | 101 | 1143 | 1267 | |||
| domContentLoaded | 1073 | 870 | 1438 | 100 | 1136 | 1260 | |||
| domInteractive | 28 | 16 | 124 | 22 | 22 | 91 | |||
| firstPaint | 557 | 84 | 1448 | 434 | 1074 | 1181 | |||
| backgroundConnect | 227 | 200 | 288 | 16 | 232 | 262 | |||
| firstReactRender | 51 | 33 | 151 | 20 | 55 | 91 | |||
| getState | 43 | 17 | 144 | 21 | 50 | 80 | |||
| initialActions | 1 | 0 | 4 | 1 | 1 | 3 | |||
| loadScripts | 855 | 668 | 1180 | 96 | 913 | 1043 | |||
| setupStore | 14 | 7 | 47 | 6 | 16 | 28 | |||
| numNetworkReqs | 13 | 6 | 71 | 18 | 6 | 70 | |||
| Browserify | Power User Home | uiStartup | 1921 | 1570 | 2301 | 151 | 2005 | 2227 | |
| load | 1098 | 897 | 1338 | 125 | 1212 | 1289 | |||
| domContentLoaded | 1088 | 891 | 1333 | 126 | 1203 | 1278 | |||
| domInteractive | 32 | 17 | 254 | 32 | 26 | 92 | |||
| firstPaint | 579 | 99 | 1304 | 440 | 1044 | 1254 | |||
| backgroundConnect | 249 | 204 | 647 | 87 | 234 | 551 | |||
| firstReactRender | 46 | 38 | 60 | 4 | 48 | 57 | |||
| getState | 208 | 146 | 745 | 97 | 213 | 277 | |||
| initialActions | 1 | 0 | 3 | 1 | 1 | 2 | |||
| loadScripts | 871 | 683 | 1118 | 124 | 987 | 1055 | |||
| setupStore | 15 | 10 | 41 | 6 | 14 | 35 | |||
| numNetworkReqs | 70 | 59 | 140 | 17 | 67 | 120 | |||
| Webpack | Standard Home | uiStartup | 819 | 677 | 995 | 81 | 885 | 959 | |
| load | 663 | 573 | 835 | 76 | 720 | 814 | |||
| domContentLoaded | 658 | 568 | 830 | 76 | 715 | 807 | |||
| domInteractive | 27 | 16 | 100 | 20 | 23 | 86 | |||
| firstPaint | 240 | 106 | 749 | 155 | 226 | 651 | |||
| backgroundConnect | 11 | 6 | 56 | 8 | 12 | 31 | |||
| firstReactRender | 55 | 33 | 248 | 43 | 46 | 156 | |||
| getState | 29 | 15 | 95 | 13 | 36 | 50 | |||
| initialActions | 1 | 0 | 4 | 1 | 1 | 2 | |||
| loadScripts | 655 | 566 | 827 | 75 | 713 | 798 | |||
| setupStore | 12 | 6 | 49 | 6 | 14 | 27 | |||
| numNetworkReqs | 13 | 6 | 80 | 19 | 6 | 69 | |||
| Webpack | Power User Home | uiStartup | 1430 | 1068 | 1931 | 185 | 1576 | 1739 | |
| load | 732 | 585 | 994 | 106 | 841 | 903 | |||
| domContentLoaded | 725 | 578 | 986 | 105 | 834 | 893 | |||
| domInteractive | 31 | 16 | 156 | 27 | 27 | 104 | |||
| firstPaint | 313 | 85 | 996 | 246 | 327 | 886 | |||
| backgroundConnect | 97 | 7 | 666 | 189 | 51 | 603 | |||
| firstReactRender | 49 | 40 | 66 | 5 | 50 | 61 | |||
| getState | 184 | 80 | 655 | 56 | 189 | 248 | |||
| initialActions | 1 | 0 | 2 | 0 | 1 | 1 | |||
| loadScripts | 722 | 575 | 983 | 104 | 830 | 890 | |||
| setupStore | 14 | 6 | 39 | 7 | 13 | 34 | |||
| numNetworkReqs | 71 | 58 | 145 | 21 | 68 | 135 | |||
| Firefox | Browserify | Standard Home | uiStartup | 1340 | 1092 | 1790 | 146 | 1418 | 1640 |
| load | 1083 | 934 | 1362 | 91 | 1136 | 1255 | |||
| domContentLoaded | 1082 | 934 | 1362 | 91 | 1136 | 1255 | |||
| domInteractive | 70 | 35 | 203 | 35 | 89 | 138 | |||
| firstPaint | - | - | - | - | - | - | |||
| backgroundConnect | 48 | 20 | 200 | 33 | 56 | 121 | |||
| firstReactRender | 39 | 31 | 77 | 8 | 41 | 55 | |||
| getState | 12 | 6 | 74 | 10 | 12 | 23 | |||
| initialActions | 1 | 0 | 3 | 1 | 2 | 2 | |||
| loadScripts | 1054 | 918 | 1330 | 82 | 1107 | 1192 | |||
| setupStore | 13 | 6 | 158 | 16 | 11 | 29 | |||
| numNetworkReqs | 15 | 6 | 87 | 20 | 7 | 75 | |||
| Browserify | Power User Home | uiStartup | 2668 | 1611 | 3717 | 563 | 3120 | 3401 | |
| load | 1677 | 989 | 2541 | 512 | 2137 | 2419 | |||
| domContentLoaded | 1676 | 989 | 2540 | 512 | 2137 | 2419 | |||
| domInteractive | 145 | 32 | 994 | 239 | 93 | 967 | |||
| firstPaint | - | - | - | - | - | - | |||
| backgroundConnect | 212 | 22 | 1440 | 265 | 222 | 938 | |||
| firstReactRender | 54 | 38 | 92 | 10 | 59 | 67 | |||
| getState | 131 | 63 | 309 | 44 | 154 | 214 | |||
| initialActions | 4 | 1 | 37 | 9 | 2 | 33 | |||
| loadScripts | 1570 | 972 | 2496 | 486 | 2046 | 2302 | |||
| setupStore | 51 | 5 | 1152 | 128 | 43 | 232 | |||
| numNetworkReqs | 75 | 56 | 145 | 23 | 68 | 126 | |||
| Webpack | Standard Home | uiStartup | 1521 | 1295 | 2027 | 125 | 1577 | 1755 | |
| load | 1269 | 1109 | 1504 | 85 | 1301 | 1450 | |||
| domContentLoaded | 1268 | 1109 | 1504 | 85 | 1301 | 1450 | |||
| domInteractive | 74 | 28 | 241 | 41 | 85 | 153 | |||
| firstPaint | - | - | - | - | - | - | |||
| backgroundConnect | 49 | 19 | 166 | 32 | 49 | 140 | |||
| firstReactRender | 40 | 33 | 84 | 7 | 42 | 52 | |||
| getState | 15 | 7 | 136 | 17 | 12 | 38 | |||
| initialActions | 1 | 0 | 2 | 0 | 2 | 2 | |||
| loadScripts | 1241 | 1096 | 1476 | 77 | 1280 | 1403 | |||
| setupStore | 14 | 5 | 128 | 15 | 13 | 46 | |||
| numNetworkReqs | 15 | 6 | 79 | 20 | 9 | 74 | |||
| Webpack | Power User Home | uiStartup | 2675 | 1617 | 4806 | 524 | 3018 | 3346 | |
| load | 1833 | 1120 | 3843 | 465 | 2194 | 2445 | |||
| domContentLoaded | 1832 | 1119 | 3842 | 465 | 2194 | 2445 | |||
| domInteractive | 128 | 32 | 941 | 214 | 90 | 870 | |||
| firstPaint | - | - | - | - | - | - | |||
| backgroundConnect | 150 | 17 | 994 | 151 | 179 | 295 | |||
| firstReactRender | 55 | 37 | 184 | 17 | 59 | 73 | |||
| getState | 124 | 71 | 566 | 63 | 148 | 232 | |||
| initialActions | 4 | 1 | 41 | 8 | 3 | 29 | |||
| loadScripts | 1756 | 1105 | 3680 | 443 | 2112 | 2375 | |||
| setupStore | 45 | 6 | 338 | 72 | 37 | 255 | |||
| numNetworkReqs | 72 | 50 | 130 | 22 | 73 | 125 |
📊 Page Load Benchmark Results
Current Commit: 1a4a379 | Date: 12/10/2025
📄 Localhost MetaMask Test Dapp
Samples: 100
Summary
- pageLoadTime-> current mean value: 1.05s (±65ms) 🟡 | historical mean value: 1.03s ⬆️ (historical data)
- domContentLoaded-> current mean value: 735ms (±89ms) 🟢 | historical mean value: 720ms ⬆️ (historical data)
- firstContentfulPaint-> current mean value: 84ms (±72ms) 🟢 | historical mean value: 78ms ⬆️ (historical data)
📈 Detailed Results
| Metric | Mean | Std Dev | Min | Max | P95 | P99 |
|---|---|---|---|---|---|---|
| pageLoadTime | 1.05s | 65ms | 1.01s | 1.62s | 1.09s | 1.62s |
| domContentLoaded | 735ms | 89ms | 701ms | 1.58s | 767ms | 1.58s |
| firstPaint | 84ms | 72ms | 64ms | 796ms | 84ms | 796ms |
| firstContentfulPaint | 84ms | 72ms | 64ms | 796ms | 84ms | 796ms |
| largestContentfulPaint | 0ms | 0ms | 0ms | 0ms | 0ms | 0ms |
Bundle size diffs [🚨 Warning! Bundle size has increased!]
- background: 58 Bytes (0%)
- ui: 6.21 KiB (0.08%)
- common: 112 Bytes (0%)