metamask-extension icon indicating copy to clipboard operation
metamask-extension copied to clipboard

chore: adds staking tx mappings (non-evm)

Open zone-live opened this issue 2 months ago • 2 comments

Description

Show txs as "Staking Deposit" and "Staking Withdrawal" in the non‑EVM transaction history lists (useMultichainTransactionDisplay).

Changelog

CHANGELOG entry: null

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

[!NOTE] Map staking deposit/withdraw transaction types in multichain views and add corresponding locale strings.

  • Frontend:
    • Map TransactionType.StakeDeposit and TransactionType.StakeWithdraw to titles in ui/components/app/multichain-transaction-details-modal/multichain-transaction-details-modal.tsx and ui/hooks/useMultichainTransactionDisplay.ts.
  • Localization:
    • Add stakingDeposit and stakingWithdrawal strings to app/_locales/en/messages.json and app/_locales/en_GB/messages.json.

Written by Cursor Bugbot for commit 1a4a3799db391ebd817a3500061a11838060b7fc. This will update automatically on new commits. Configure here.

zone-live avatar Dec 10 '25 14:12 zone-live

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

github-actions[bot] avatar Dec 10 '25 14:12 github-actions[bot]

Builds ready [1a4a379]
UI Startup Metrics (1323 ± 115 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyStandard HomeuiStartup13231035169111513951513
load1081875144910111431267
domContentLoaded1073870143810011361260
domInteractive2816124222291
firstPaint55784144843410741181
backgroundConnect22720028816232262
firstReactRender5133151205591
getState4317144215080
initialActions104113
loadScripts8556681180969131043
setupStore1474761628
numNetworkReqs1367118670
BrowserifyPower User HomeuiStartup19211570230115120052227
load1098897133812512121289
domContentLoaded1088891133312612031278
domInteractive3217254322692
firstPaint57999130444010441254
backgroundConnect24920464787234551
firstReactRender46386044857
getState20814674597213277
initialActions103112
loadScripts87168311181249871055
setupStore15104161435
numNetworkReqs70591401767120
WebpackStandard HomeuiStartup81967799581885959
load66357383576720814
domContentLoaded65856883076715807
domInteractive2716100202386
firstPaint240106749155226651
backgroundConnect1165681231
firstReactRender55332484346156
getState291595133650
initialActions104112
loadScripts65556682775713798
setupStore1264961427
numNetworkReqs1368019669
WebpackPower User HomeuiStartup14301068193118515761739
load732585994106841903
domContentLoaded725578986105834893
domInteractive31161562727104
firstPaint31385996246327886
backgroundConnect97766618951603
firstReactRender49406655061
getState1848065556189248
initialActions102011
loadScripts722575983104830890
setupStore1463971334
numNetworkReqs71581452168135
FirefoxBrowserifyStandard HomeuiStartup13401092179014614181640
load108393413629111361255
domContentLoaded108293413629111361255
domInteractive70352033589138
firstPaint------
backgroundConnect48202003356121
firstReactRender39317784155
getState12674101223
initialActions103122
loadScripts105491813308211071192
setupStore136158161129
numNetworkReqs1568720775
BrowserifyPower User HomeuiStartup26681611371756331203401
load1677989254151221372419
domContentLoaded1676989254051221372419
domInteractive1453299423993967
firstPaint------
backgroundConnect212221440265222938
firstReactRender543892105967
getState1316330944154214
initialActions41379233
loadScripts1570972249648620462302
setupStore515115212843232
numNetworkReqs75561452368126
WebpackStandard HomeuiStartup15211295202712515771755
load1269110915048513011450
domContentLoaded1268110915048513011450
domInteractive74282414185153
firstPaint------
backgroundConnect49191663249140
firstReactRender40338474252
getState157136171238
initialActions102022
loadScripts1241109614767712801403
setupStore145128151346
numNetworkReqs1567920974
WebpackPower User HomeuiStartup26751617480652430183346
load18331120384346521942445
domContentLoaded18321119384246521942445
domInteractive1283294121490870
firstPaint------
backgroundConnect15017994151179295
firstReactRender5537184175973
getState1247156663148232
initialActions41418329
loadScripts17561105368044321122375
setupStore4563387237255
numNetworkReqs72501302273125
📊 Page Load Benchmark Results

Current Commit: 1a4a379 | Date: 12/10/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

  • pageLoadTime-> current mean value: 1.05s (±65ms) 🟡 | historical mean value: 1.03s ⬆️ (historical data)
  • domContentLoaded-> current mean value: 735ms (±89ms) 🟢 | historical mean value: 720ms ⬆️ (historical data)
  • firstContentfulPaint-> current mean value: 84ms (±72ms) 🟢 | historical mean value: 78ms ⬆️ (historical data)

📈 Detailed Results

Metric Mean Std Dev Min Max P95 P99
pageLoadTime 1.05s 65ms 1.01s 1.62s 1.09s 1.62s
domContentLoaded 735ms 89ms 701ms 1.58s 767ms 1.58s
firstPaint 84ms 72ms 64ms 796ms 84ms 796ms
firstContentfulPaint 84ms 72ms 64ms 796ms 84ms 796ms
largestContentfulPaint 0ms 0ms 0ms 0ms 0ms 0ms
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 58 Bytes (0%)
  • ui: 6.21 KiB (0.08%)
  • common: 112 Bytes (0%)

metamaskbot avatar Dec 10 '25 15:12 metamaskbot