chore: Remove NFT disclaimer to polish UI
Description
This PR removes the disclaimer at the bottom of NFT details to clean up the UI. It reduces visual noise, allowing users to focus on the relevant data on the screen. This PR is part of the quality initiative.
Changelog
CHANGELOG entry: null
Related issues
Fixes: https://consensyssoftware.atlassian.net/browse/MDP-535?atlOrigin=eyJpIjoiYWM2MDcwNTQ0MGVmNDExMDgyOTcxNTIxYjA1NWQyZjkiLCJwIjoiaiJ9
Manual testing steps
Make sure the disclaimer message does not appear
Screenshots/Recordings
Before
After
Pre-merge author checklist
- [ ] I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using JSDoc format if applicable
- [ ] I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
Pre-merge reviewer checklist
- [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
[!NOTE] Removes the NFT disclaimer from the NFT details UI and deletes the associated i18n strings across locales.
- Frontend:
- NFT Details (
ui/components/app/assets/nfts/nft-details/nft-details.tsx): Remove rendering ofnftDisclaimertext block.- Tests: Update snapshot to reflect disclaimer removal.
- i18n:
- Remove
nftDisclaimerkey fromapp/_locales/*/messages.json(multiple languages).Written by Cursor Bugbot for commit 36c0926ebf9ca7cba43e7eab9701d8e14763b9dc. This will update automatically on new commits. Configure here.
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.
✨ Files requiring CODEOWNER review ✨
💎 @MetaMask/metamask-assets (2 files, +0 -17)
- 📁 ui/
- 📁 components/
- 📁 app/
- 📁 assets/
- 📁 nfts/
- 📁 nft-details/
- 📁 __snapshots__/
- 📄
nft-details.test.js.snap+0 -9 - 📄
nft-details.tsx+0 -8
- 📄
- 📁 __snapshots__/
- 📁 nft-details/
- 📁 nfts/
- 📁 assets/
- 📁 app/
- 📁 components/
Builds ready [36c0926]
- builds: chrome, firefox
- builds (beta): chrome, firefox
- builds (flask): chrome, firefox
- builds (test): chrome, firefox
- builds (test-flask): chrome, firefox
- bundle size: Bundle Size Stats
- user-actions-benchmark: User Actions Stats
- storybook: Storybook
- typescript migration: Dashboard
- all artifacts
UI Startup Metrics (1289 ± 111 ms)
| Platform | BuildType | Page | Metric | Mean (ms) | Min (ms) | Max (ms) | Std Dev (ms) | P 75 (ms) | P 95 (ms) |
|---|---|---|---|---|---|---|---|---|---|
| Chrome | Browserify | Standard Home | uiStartup | 1289 | 1061 | 1652 | 111 | 1356 | 1469 |
| load | 1065 | 871 | 1340 | 95 | 1127 | 1239 | |||
| domContentLoaded | 1058 | 864 | 1318 | 94 | 1120 | 1229 | |||
| domInteractive | 26 | 16 | 97 | 20 | 22 | 86 | |||
| firstPaint | 551 | 97 | 1328 | 422 | 1059 | 1198 | |||
| backgroundConnect | 220 | 197 | 255 | 12 | 226 | 241 | |||
| firstReactRender | 49 | 31 | 94 | 14 | 57 | 80 | |||
| getState | 39 | 14 | 127 | 17 | 47 | 64 | |||
| initialActions | 1 | 0 | 3 | 1 | 1 | 2 | |||
| loadScripts | 846 | 663 | 1106 | 91 | 892 | 1017 | |||
| setupStore | 13 | 7 | 36 | 6 | 15 | 28 | |||
| numNetworkReqs | 13 | 6 | 85 | 19 | 6 | 70 | |||
| Browserify | Power User Home | uiStartup | 1956 | 1592 | 2482 | 160 | 2087 | 2250 | |
| load | 1092 | 905 | 1367 | 115 | 1161 | 1327 | |||
| domContentLoaded | 1081 | 895 | 1354 | 115 | 1152 | 1318 | |||
| domInteractive | 32 | 18 | 121 | 23 | 29 | 101 | |||
| firstPaint | 535 | 98 | 1370 | 418 | 1035 | 1207 | |||
| backgroundConnect | 244 | 205 | 734 | 77 | 240 | 294 | |||
| firstReactRender | 49 | 38 | 75 | 6 | 52 | 62 | |||
| getState | 224 | 146 | 789 | 122 | 214 | 688 | |||
| initialActions | 1 | 0 | 2 | 1 | 1 | 2 | |||
| loadScripts | 863 | 696 | 1149 | 112 | 925 | 1099 | |||
| setupStore | 18 | 7 | 61 | 9 | 17 | 37 | |||
| numNetworkReqs | 73 | 58 | 158 | 21 | 72 | 129 | |||
| Webpack | Standard Home | uiStartup | 825 | 688 | 1070 | 81 | 864 | 988 | |
| load | 666 | 584 | 903 | 74 | 717 | 804 | |||
| domContentLoaded | 660 | 579 | 898 | 73 | 712 | 798 | |||
| domInteractive | 26 | 15 | 104 | 20 | 22 | 83 | |||
| firstPaint | 208 | 89 | 658 | 120 | 212 | 604 | |||
| backgroundConnect | 13 | 6 | 119 | 13 | 13 | 30 | |||
| firstReactRender | 52 | 34 | 204 | 30 | 55 | 124 | |||
| getState | 28 | 14 | 81 | 12 | 37 | 49 | |||
| initialActions | 1 | 0 | 4 | 1 | 1 | 2 | |||
| loadScripts | 657 | 577 | 889 | 72 | 710 | 790 | |||
| setupStore | 12 | 7 | 44 | 6 | 14 | 26 | |||
| numNetworkReqs | 13 | 6 | 91 | 20 | 6 | 74 | |||
| Webpack | Power User Home | uiStartup | 1425 | 1145 | 1971 | 177 | 1522 | 1753 | |
| load | 733 | 590 | 943 | 104 | 839 | 925 | |||
| domContentLoaded | 726 | 582 | 932 | 103 | 833 | 917 | |||
| domInteractive | 33 | 17 | 240 | 33 | 26 | 111 | |||
| firstPaint | 286 | 94 | 901 | 213 | 280 | 794 | |||
| backgroundConnect | 69 | 7 | 556 | 135 | 58 | 528 | |||
| firstReactRender | 49 | 40 | 67 | 5 | 51 | 63 | |||
| getState | 185 | 143 | 784 | 67 | 187 | 267 | |||
| initialActions | 1 | 0 | 2 | 1 | 1 | 2 | |||
| loadScripts | 723 | 579 | 930 | 102 | 825 | 908 | |||
| setupStore | 17 | 6 | 50 | 10 | 15 | 37 | |||
| numNetworkReqs | 71 | 57 | 149 | 21 | 70 | 133 | |||
| Firefox | Browserify | Standard Home | uiStartup | 1315 | 1059 | 1811 | 155 | 1391 | 1650 |
| load | 1057 | 898 | 1274 | 92 | 1116 | 1242 | |||
| domContentLoaded | 1056 | 897 | 1274 | 92 | 1110 | 1242 | |||
| domInteractive | 68 | 30 | 162 | 35 | 86 | 136 | |||
| firstPaint | - | - | - | - | - | - | |||
| backgroundConnect | 51 | 22 | 294 | 43 | 57 | 132 | |||
| firstReactRender | 38 | 30 | 94 | 10 | 38 | 56 | |||
| getState | 12 | 7 | 128 | 13 | 11 | 25 | |||
| initialActions | 1 | 0 | 2 | 0 | 1 | 2 | |||
| loadScripts | 1028 | 880 | 1227 | 81 | 1088 | 1199 | |||
| setupStore | 13 | 6 | 148 | 16 | 11 | 39 | |||
| numNetworkReqs | 15 | 6 | 87 | 21 | 8 | 73 | |||
| Browserify | Power User Home | uiStartup | 2632 | 1575 | 3868 | 547 | 3029 | 3361 | |
| load | 1631 | 960 | 2547 | 489 | 2043 | 2367 | |||
| domContentLoaded | 1630 | 960 | 2546 | 489 | 2043 | 2367 | |||
| domInteractive | 124 | 31 | 1048 | 213 | 78 | 933 | |||
| firstPaint | - | - | - | - | - | - | |||
| backgroundConnect | 193 | 26 | 1045 | 204 | 222 | 909 | |||
| firstReactRender | 55 | 38 | 185 | 17 | 60 | 73 | |||
| getState | 145 | 57 | 986 | 102 | 162 | 247 | |||
| initialActions | 2 | 1 | 32 | 3 | 2 | 7 | |||
| loadScripts | 1552 | 940 | 2523 | 451 | 1951 | 2228 | |||
| setupStore | 45 | 6 | 335 | 70 | 49 | 242 | |||
| numNetworkReqs | 74 | 55 | 127 | 22 | 75 | 124 | |||
| Webpack | Standard Home | uiStartup | 1588 | 1297 | 2022 | 166 | 1703 | 1910 | |
| load | 1291 | 1118 | 1562 | 90 | 1338 | 1470 | |||
| domContentLoaded | 1290 | 1118 | 1562 | 90 | 1338 | 1470 | |||
| domInteractive | 73 | 29 | 200 | 37 | 97 | 131 | |||
| firstPaint | - | - | - | - | - | - | |||
| backgroundConnect | 61 | 20 | 317 | 47 | 63 | 154 | |||
| firstReactRender | 44 | 33 | 96 | 11 | 47 | 59 | |||
| getState | 20 | 7 | 157 | 28 | 15 | 78 | |||
| initialActions | 1 | 0 | 3 | 1 | 2 | 2 | |||
| loadScripts | 1260 | 1101 | 1527 | 82 | 1313 | 1399 | |||
| setupStore | 23 | 6 | 214 | 33 | 15 | 99 | |||
| numNetworkReqs | 15 | 6 | 88 | 21 | 8 | 79 | |||
| Webpack | Power User Home | uiStartup | 2691 | 1716 | 4038 | 553 | 3158 | 3509 | |
| load | 1885 | 1121 | 2794 | 498 | 2330 | 2541 | |||
| domContentLoaded | 1885 | 1120 | 2793 | 498 | 2330 | 2541 | |||
| domInteractive | 283 | 31 | 1113 | 376 | 382 | 1040 | |||
| firstPaint | - | - | - | - | - | - | |||
| backgroundConnect | 123 | 25 | 1129 | 150 | 157 | 265 | |||
| firstReactRender | 57 | 38 | 117 | 12 | 62 | 70 | |||
| getState | 134 | 74 | 279 | 47 | 164 | 221 | |||
| initialActions | 3 | 0 | 41 | 5 | 2 | 7 | |||
| loadScripts | 1822 | 1105 | 2689 | 477 | 2249 | 2523 | |||
| setupStore | 38 | 5 | 337 | 55 | 44 | 155 | |||
| numNetworkReqs | 75 | 54 | 139 | 22 | 82 | 129 |
📊 Page Load Benchmark Results
Current Commit: 36c0926 | Date: 12/10/2025
📄 Localhost MetaMask Test Dapp
Samples: 100
Summary
- pageLoadTime-> current mean value: 1.05s (±40ms) 🟡 | historical mean value: 1.04s ⬆️ (historical data)
- domContentLoaded-> current mean value: 730ms (±38ms) 🟢 | historical mean value: 727ms ⬆️ (historical data)
- firstContentfulPaint-> current mean value: 79ms (±13ms) 🟢 | historical mean value: 83ms ⬇️ (historical data)
📈 Detailed Results
| Metric | Mean | Std Dev | Min | Max | P95 | P99 |
|---|---|---|---|---|---|---|
| pageLoadTime | 1.05s | 40ms | 1.03s | 1.36s | 1.07s | 1.36s |
| domContentLoaded | 730ms | 38ms | 708ms | 1.03s | 750ms | 1.03s |
| firstPaint | 79ms | 13ms | 60ms | 192ms | 92ms | 192ms |
| firstContentfulPaint | 79ms | 13ms | 60ms | 192ms | 92ms | 192ms |
| largestContentfulPaint | 0ms | 0ms | 0ms | 0ms | 0ms | 0ms |
Bundle size diffs [🚀 Bundle size reduced!]
- background: 58 Bytes (0%)
- ui: -153 Bytes (0%)
- common: -149 Bytes (0%)