metamask-extension icon indicating copy to clipboard operation
metamask-extension copied to clipboard

chore: Remove NFT disclaimer to polish UI

Open amandaye0h opened this issue 1 month ago • 3 comments

Description

This PR removes the disclaimer at the bottom of NFT details to clean up the UI. It reduces visual noise, allowing users to focus on the relevant data on the screen. This PR is part of the quality initiative.

Open in GitHub Codespaces

Changelog

CHANGELOG entry: null

Related issues

Fixes: https://consensyssoftware.atlassian.net/browse/MDP-535?atlOrigin=eyJpIjoiYWM2MDcwNTQ0MGVmNDExMDgyOTcxNTIxYjA1NWQyZjkiLCJwIjoiaiJ9

Manual testing steps

Make sure the disclaimer message does not appear

Screenshots/Recordings

Before

After

Screenshot 2025-12-10 at 9 25 09 AM

Pre-merge author checklist

Pre-merge reviewer checklist

  • [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

[!NOTE] Removes the NFT disclaimer from the NFT details UI and deletes the associated i18n strings across locales.

  • Frontend:
    • NFT Details (ui/components/app/assets/nfts/nft-details/nft-details.tsx): Remove rendering of nftDisclaimer text block.
    • Tests: Update snapshot to reflect disclaimer removal.
  • i18n:
    • Remove nftDisclaimer key from app/_locales/*/messages.json (multiple languages).

Written by Cursor Bugbot for commit 36c0926ebf9ca7cba43e7eab9701d8e14763b9dc. This will update automatically on new commits. Configure here.

amandaye0h avatar Dec 10 '25 01:12 amandaye0h

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

github-actions[bot] avatar Dec 10 '25 01:12 github-actions[bot]

✨ Files requiring CODEOWNER review ✨

💎 @MetaMask/metamask-assets (2 files, +0 -17)
  • 📁 ui/
    • 📁 components/
      • 📁 app/
        • 📁 assets/
          • 📁 nfts/
            • 📁 nft-details/
              • 📁 __snapshots__/
                • 📄 nft-details.test.js.snap +0 -9
                • 📄 nft-details.tsx +0 -8

metamaskbot avatar Dec 10 '25 01:12 metamaskbot

Builds ready [36c0926]
UI Startup Metrics (1289 ± 111 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyStandard HomeuiStartup12891061165211113561469
load106587113409511271239
domContentLoaded105886413189411201229
domInteractive261697202286
firstPaint55197132842210591198
backgroundConnect22019725512226241
firstReactRender493194145780
getState3914127174764
initialActions103112
loadScripts8466631106918921017
setupStore1373661528
numNetworkReqs1368519670
BrowserifyPower User HomeuiStartup19561592248216020872250
load1092905136711511611327
domContentLoaded1081895135411511521318
domInteractive32181212329101
firstPaint53598137041810351207
backgroundConnect24420573477240294
firstReactRender49387565262
getState224146789122214688
initialActions102112
loadScripts86369611491129251099
setupStore1876191737
numNetworkReqs73581582172129
WebpackStandard HomeuiStartup825688107081864988
load66658490374717804
domContentLoaded66057989873712798
domInteractive2615104202283
firstPaint20889658120212604
backgroundConnect136119131330
firstReactRender52342043055124
getState281481123749
initialActions104112
loadScripts65757788972710790
setupStore1274461426
numNetworkReqs1369120674
WebpackPower User HomeuiStartup14251145197117715221753
load733590943104839925
domContentLoaded726582932103833917
domInteractive33172403326111
firstPaint28694901213280794
backgroundConnect69755613558528
firstReactRender49406755163
getState18514378467187267
initialActions102112
loadScripts723579930102825908
setupStore17650101537
numNetworkReqs71571492170133
FirefoxBrowserifyStandard HomeuiStartup13151059181115513911650
load105789812749211161242
domContentLoaded105689712749211101242
domInteractive68301623586136
firstPaint------
backgroundConnect51222944357132
firstReactRender383094103856
getState127128131125
initialActions102012
loadScripts102888012278110881199
setupStore136148161139
numNetworkReqs1568721873
BrowserifyPower User HomeuiStartup26321575386854730293361
load1631960254748920432367
domContentLoaded1630960254648920432367
domInteractive12431104821378933
firstPaint------
backgroundConnect193261045204222909
firstReactRender5538185176073
getState14557986102162247
initialActions2132327
loadScripts1552940252345119512228
setupStore4563357049242
numNetworkReqs74551272275124
WebpackStandard HomeuiStartup15881297202216617031910
load1291111815629013381470
domContentLoaded1290111815629013381470
domInteractive73292003797131
firstPaint------
backgroundConnect61203174763154
firstReactRender443396114759
getState207157281578
initialActions103122
loadScripts1260110115278213131399
setupStore236214331599
numNetworkReqs1568821879
WebpackPower User HomeuiStartup26911716403855331583509
load18851121279449823302541
domContentLoaded18851120279349823302541
domInteractive2833111133763821040
firstPaint------
backgroundConnect123251129150157265
firstReactRender5738117126270
getState1347427947164221
initialActions3041527
loadScripts18221105268947722492523
setupStore3853375544155
numNetworkReqs75541392282129
📊 Page Load Benchmark Results

Current Commit: 36c0926 | Date: 12/10/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

  • pageLoadTime-> current mean value: 1.05s (±40ms) 🟡 | historical mean value: 1.04s ⬆️ (historical data)
  • domContentLoaded-> current mean value: 730ms (±38ms) 🟢 | historical mean value: 727ms ⬆️ (historical data)
  • firstContentfulPaint-> current mean value: 79ms (±13ms) 🟢 | historical mean value: 83ms ⬇️ (historical data)

📈 Detailed Results

Metric Mean Std Dev Min Max P95 P99
pageLoadTime 1.05s 40ms 1.03s 1.36s 1.07s 1.36s
domContentLoaded 730ms 38ms 708ms 1.03s 750ms 1.03s
firstPaint 79ms 13ms 60ms 192ms 92ms 192ms
firstContentfulPaint 79ms 13ms 60ms 192ms 92ms 192ms
largestContentfulPaint 0ms 0ms 0ms 0ms 0ms 0ms
Bundle size diffs [🚀 Bundle size reduced!]
  • background: 58 Bytes (0%)
  • ui: -153 Bytes (0%)
  • common: -149 Bytes (0%)

metamaskbot avatar Dec 10 '25 02:12 metamaskbot