metamask-extension icon indicating copy to clipboard operation
metamask-extension copied to clipboard

chore: Update address popover styling

Open amandaye0h opened this issue 1 month ago • 4 comments

Description

This PR refines the hover states and styling of the address popover so the visuals are polished. Designs have been approved by @jakehaugen

Open in GitHub Codespaces

Changelog

CHANGELOG entry: fix: update styling of accounts address popover

Related issues

Fixes:

Manual testing steps

Ensure that hover state works as expected

Screenshots/Recordings

Before

https://github.com/user-attachments/assets/7ce13eb5-69b3-4462-9984-ca753c6c013d

After

https://github.com/user-attachments/assets/37564cdd-e1b9-4c0b-85c3-3296f5f87f14

Pre-merge author checklist

Pre-merge reviewer checklist

  • [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

[!NOTE] Polishes the multichain address hover popover: adjusts spacing/typography, increases popover padding/width, adds a divider and small full-width tertiary “View All” button; updates tests to match UI changes.

  • UI/Styling (multichain address popover)
    • Adjust row spacing and typography in multichain-aggregated-list-row.tsx (smaller gaps, Medium weight, larger copy icon, minWidth for address text).
    • Update popover layout in multichain-hovered-address-rows-hovered-list.tsx (added paddingInline/top/bottom, minWidth 340px, header text size tweak, new top border divider, small full-width tertiary View All button; removed arrow icon).
    • Refine SCSS in index.scss (reduced paddings, add border-radius, new .multichain-address-rows-border, hover radius for ...-view-all-button).
  • Tests
    • Update selectors and expectations in multichain-hovered-address-rows-hovered-list.test.tsx to avoid class-based queries, align with new typography and button changes.

Written by Cursor Bugbot for commit a833cee3571cee3aab0d67df66284524a7ed977f. This will update automatically on new commits. Configure here.

amandaye0h avatar Dec 09 '25 21:12 amandaye0h

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

github-actions[bot] avatar Dec 09 '25 21:12 github-actions[bot]

✨ Files requiring CODEOWNER review ✨

🔑 @MetaMask/accounts-engineers (4 files, +59 -37)
  • 📁 ui/
    • 📁 components/
      • 📁 multichain-accounts/
        • 📁 multichain-address-rows-hovered-list/
          • 📄 index.scss +14 -4
          • 📄 multichain-aggregated-list-row.tsx +6 -6
          • 📄 multichain-hovered-address-rows-hovered-list.test.tsx +17 -10
          • 📄 multichain-hovered-address-rows-hovered-list.tsx +22 -17

metamaskbot avatar Dec 09 '25 22:12 metamaskbot

Builds ready [df7283a]
UI Startup Metrics (1285 ± 117 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyStandard HomeuiStartup12851017159811713571491
load1058863130810011441210
domContentLoaded105085812959911361204
domInteractive2716104212290
firstPaint51296130741310321197
backgroundConnect21519624911221235
firstReactRender4733101145972
getState3919149224380
initialActions106112
loadScripts843655106296927987
setupStore1263251323
numNetworkReqs1368420670
BrowserifyPower User HomeuiStartup18761546225515319792169
load1032860137011911041259
domContentLoaded1021855135811710981251
domInteractive3117226282689
firstPaint68893132941810721272
backgroundConnect258186718117230551
firstReactRender49387065263
getState19714865253213247
initialActions103112
loadScripts81766511261138961046
setupStore1494881335
numNetworkReqs70581452067134
WebpackStandard HomeuiStartup824672126288878956
load659574103976702794
domContentLoaded653570103075694788
domInteractive2616105202381
firstPaint249821042184224685
backgroundConnect1168791229
firstReactRender58332043863156
getState2914101133649
initialActions103112
loadScripts650568102774691779
setupStore1162851422
numNetworkReqs1367919671
WebpackPower User HomeuiStartup14101061186618415661723
load7445961054110835935
domContentLoaded7365891045109825928
domInteractive30161392624102
firstPaint282951050222247834
backgroundConnect88863616670568
firstReactRender49397355059
getState18414236738191266
initialActions102111
loadScripts7335861043108823921
setupStore1575291337
numNetworkReqs70552072465131
FirefoxBrowserifyStandard HomeuiStartup13521107187617714351747
load108193914009611331252
domContentLoaded108093314009611331252
domInteractive70302554087145
firstPaint------
backgroundConnect58222945269174
firstReactRender39317683961
getState157182251129
initialActions103112
loadScripts104892313638510941213
setupStore185179281191
numNetworkReqs1568121878
BrowserifyPower User HomeuiStartup26531673386254431063355
load1648981289550620902374
domContentLoaded1648981289550620902373
domInteractive16332169429587956
firstPaint------
backgroundConnect206221092240205983
firstReactRender543499125977
getState1506897596169248
initialActions218123
loadScripts1553926287447520012272
setupStore5154678845269
numNetworkReqs73491332167124
WebpackStandard HomeuiStartup15811290216617216571934
load12981102169911613661519
domContentLoaded12981102169911613661518
domInteractive802814537111140
firstPaint------
backgroundConnect61212464375145
firstReactRender423297104756
getState177184201647
initialActions108122
loadScripts12651080167710313391448
setupStore216224341588
numNetworkReqs1567720873
WebpackPower User HomeuiStartup27351777375546330893417
load18701141290044522382525
domContentLoaded18701141290044522372524
domInteractive16932937258149898
firstPaint------
backgroundConnect163291052202179918
firstReactRender5739123136184
getState136711246123152251
initialActions2140423
loadScripts17901125287243021452421
setupStore3653446232203
numNetworkReqs72451292269125
📊 Page Load Benchmark Results

Current Commit: df7283a | Date: 12/9/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

  • pageLoadTime-> current mean value: 1.05s (±41ms) 🟡 | historical mean value: 1.04s ⬆️ (historical data)
  • domContentLoaded-> current mean value: 734ms (±38ms) 🟢 | historical mean value: 727ms ⬆️ (historical data)
  • firstContentfulPaint-> current mean value: 79ms (±12ms) 🟢 | historical mean value: 83ms ⬇️ (historical data)

📈 Detailed Results

Metric Mean Std Dev Min Max P95 P99
pageLoadTime 1.05s 41ms 1.02s 1.34s 1.09s 1.34s
domContentLoaded 734ms 38ms 708ms 1.00s 769ms 1.00s
firstPaint 79ms 12ms 60ms 188ms 84ms 188ms
firstContentfulPaint 79ms 12ms 60ms 188ms 84ms 188ms
largestContentfulPaint 0ms 0ms 0ms 0ms 0ms 0ms
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 3.06 KiB (0.06%)
  • ui: -24.79 KiB (-0.32%)
  • common: 8.46 KiB (0.09%)

metamaskbot avatar Dec 09 '25 22:12 metamaskbot

Builds ready [a833cee]
UI Startup Metrics (1335 ± 100 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyStandard HomeuiStartup13351113158710014081485
load108591013399011551242
domContentLoaded107890713308911391234
domInteractive2815108202489
firstPaint4678012653799521171
backgroundConnect23420328516244264
firstReactRender5134133176183
getState44181612749118
initialActions106114
loadScripts8516861081849061007
setupStore1373451524
numNetworkReqs1368119669
BrowserifyPower User HomeuiStartup18911541227415619912191
load1083898142012011531334
domContentLoaded1073893139311911441322
domInteractive3117142232697
firstPaint572106142444010631317
backgroundConnect25420466593241538
firstReactRender47396744956
getState19914767872210245
initialActions102112
loadScripts85568711861169271104
setupStore1493951425
numNetworkReqs70561441768122
WebpackStandard HomeuiStartup830679106282903971
load67657484977744814
domContentLoaded67056984476738799
domInteractive2616109202382
firstPaint22988762146225638
backgroundConnect146169181333
firstReactRender50331993346158
getState281476123853
initialActions104112
loadScripts66756783675729797
setupStore1063141119
numNetworkReqs1368120674
WebpackPower User HomeuiStartup14311107186818515901726
load746595974109859929
domContentLoaded738589964108853922
domInteractive33171282727113
firstPaint28689894206316723
backgroundConnect68766014329547
firstReactRender50427255263
getState19513868578195288
initialActions103011
loadScripts735587962107850913
setupStore1664291437
numNetworkReqs72592282668139
FirefoxBrowserifyStandard HomeuiStartup13721079236418814481667
load109791814169811571287
domContentLoaded109691714169811571287
domInteractive72311623994140
firstPaint------
backgroundConnect6820100110473192
firstReactRender38317283955
getState12696101325
initialActions102122
loadScripts106390313038311121202
setupStore13689121139
numNetworkReqs1567820976
BrowserifyPower User HomeuiStartup25791545366455830133337
load1642947260549020382382
domContentLoaded1641947260549020382382
domInteractive13831105323893948
firstPaint------
backgroundConnect171231149189201459
firstReactRender543696116177
getState145551179113160237
initialActions4064828
loadScripts1548930242245118982257
setupStore3943346344230
numNetworkReqs74551372368127
WebpackStandard HomeuiStartup15461221214016816461849
load12731081160410013391488
domContentLoaded12721081160410013391488
domInteractive68281513592132
firstPaint------
backgroundConnect57192054058163
firstReactRender433389114571
getState166116171446
initialActions105122
loadScripts1244106715069213131426
setupStore196221351357
numNetworkReqs1568320874
WebpackPower User HomeuiStartup27641832519760131343688
load17871234468254822632690
domContentLoaded17871234468254822632690
domInteractive144313047333104440
firstPaint------
backgroundConnect186311174228232947
firstReactRender6041121146393
getState164661118162175257
initialActions218123
loadScripts16831141465651221102507
setupStore625110315741244
numNetworkReqs1084825148133232
📊 Page Load Benchmark Results

Current Commit: a833cee | Date: 12/10/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

  • pageLoadTime-> current mean value: 1.04s (±121ms) 🟡 | historical mean value: 1.04s ⬇️ (historical data)
  • domContentLoaded-> current mean value: 729ms (±131ms) 🟢 | historical mean value: 727ms ⬆️ (historical data)
  • firstContentfulPaint-> current mean value: 95ms (±200ms) 🟢 | historical mean value: 83ms ⬆️ (historical data)

📈 Detailed Results

Metric Mean Std Dev Min Max P95 P99
pageLoadTime 1.04s 121ms 1.01s 2.20s 1.05s 2.20s
domContentLoaded 729ms 131ms 700ms 2.00s 732ms 2.00s
firstPaint 95ms 200ms 60ms 2.09s 84ms 2.09s
firstContentfulPaint 95ms 200ms 60ms 2.09s 84ms 2.09s
largestContentfulPaint 0ms 0ms 0ms 0ms 0ms 0ms
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 58 Bytes (0%)
  • ui: 214 Bytes (0%)
  • common: 20 Bytes (0%)

metamaskbot avatar Dec 10 '25 02:12 metamaskbot