metamask-extension icon indicating copy to clipboard operation
metamask-extension copied to clipboard

chore: Refine hidden accounts icon

Open amandaye0h opened this issue 1 month ago • 3 comments

Description

This PR cleans up the icon for hiding accounts for consistency. It polishes the UI.

Open in GitHub Codespaces

Changelog

CHANGELOG entry: null

Related issues

Fixes:

  • https://consensyssoftware.atlassian.net/browse/MDP-446?atlOrigin=eyJpIjoiZjc5OGFhYmU3ZTc3NDBmYzgyZjNiYWI3ZDVkYzc0YWEiLCJwIjoiaiJ9
  • https://consensyssoftware.atlassian.net/browse/MDP-447?atlOrigin=eyJpIjoiZGUxYjg5ODdhYmM5NGUxNGIwMjk0MDA5MjAxYTU1NWYiLCJwIjoiaiJ9

Manual testing steps

Ensure that icon aligns and size matches

Screenshots/Recordings

Before

Screenshot 2025-12-10 at 9 51 30 AM

After

Screenshot 2025-12-10 at 9 55 31 AM

Pre-merge author checklist

Pre-merge reviewer checklist

  • [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

[!NOTE] Standardizes hidden-accounts section toggles to medium, alternative-colored arrows and increases right padding on the multichain list header.

  • UI/UX
    • Hidden accounts toggles:
      • In ui/components/multichain-accounts/multichain-account-list/multichain-account-list.tsx and ui/components/multichain/account-list-menu/hidden-account-list.js:
        • Update Icon size from IconSize.Sm to IconSize.Md and color from IconColor.iconDefault to IconColor.iconAlternative for IconName.ArrowUp/ArrowDown.
      • In multichain-account-list.tsx: increase paddingRight on hidden header from 4 to 6.

Written by Cursor Bugbot for commit c0675b76836ab255a5a43da17c7e24b803a2c246. This will update automatically on new commits. Configure here.

amandaye0h avatar Dec 09 '25 08:12 amandaye0h

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

github-actions[bot] avatar Dec 09 '25 08:12 github-actions[bot]

✨ Files requiring CODEOWNER review ✨

🔑 @MetaMask/accounts-engineers (2 files, +5 -5)
  • 📁 ui/
    • 📁 components/
      • 📁 multichain/
        • 📁 account-list-menu/
          • 📄 hidden-account-list.js +2 -2
      • 📁 multichain-accounts/
        • 📁 multichain-account-list/
          • 📄 multichain-account-list.tsx +3 -3

👨‍🔧 @MetaMask/core-extension-ux (1 files, +2 -2)
  • 📁 ui/
    • 📁 components/
      • 📁 multichain/
        • 📁 account-list-menu/
          • 📄 hidden-account-list.js +2 -2

metamaskbot avatar Dec 09 '25 08:12 metamaskbot

Builds ready [c0675b7]
UI Startup Metrics (1306 ± 100 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyStandard HomeuiStartup13061077154610013641481
load107388013299211231250
domContentLoaded106687413229211161238
domInteractive24165992443
firstPaint52584125141110521141
backgroundConnect22219726213229249
firstReactRender493294145678
getState361689134461
initialActions105113
loadScripts8526781101889031021
setupStore1372951524
numNetworkReqs86306629
BrowserifyPower User HomeuiStartup18821643218011819702090
load108090912849011511220
domContentLoaded106990312759011291215
domInteractive26166492843
firstPaint58498123042710571177
backgroundConnect25020566386243537
firstReactRender49397375164
getState19414128931212258
initialActions104112
loadScripts8546841046899131002
setupStore1775981538
numNetworkReqs67581091167102
WebpackStandard HomeuiStartup828699112764861944
load64156580157677737
domContentLoaded63656179157672733
domInteractive21153862237
firstPaint21371801169194676
backgroundConnect13570101432
firstReactRender52322993946151
getState24134693043
initialActions103111
loadScripts63355878957670731
setupStore1063651120
numNetworkReqs86336629
WebpackPower User HomeuiStartup14581161198816215991750
load725578108292790897
domContentLoaded718572106591780888
domInteractive251581102647
firstPaint286901077220237772
backgroundConnect60756812741537
firstReactRender48408664960
getState19114233640225259
initialActions102011
loadScripts715570106290778886
setupStore1596891434
numNetworkReqs6658110106695
FirefoxBrowserifyStandard HomeuiStartup12541101167412113261470
load102992213597310721157
domContentLoaded102891713597310721156
domInteractive55342123073102
firstPaint------
backgroundConnect3519182213569
firstReactRender3831144133854
getState1062541022
initialActions105122
loadScripts100690613006510441122
setupStore136282271022
numNetworkReqs86265724
BrowserifyPower User HomeuiStartup27571598414361932323586
load1735998270757322602498
domContentLoaded1734997270757422602498
domInteractive3163414334379501112
firstPaint------
backgroundConnect142221201165161345
firstReactRender5634120145994
getState1447233953167259
initialActions217123
loadScripts1684972256955721762447
setupStore695110916058304
numNetworkReqs70431511867118
WebpackStandard HomeuiStartup15561389186110016191744
load1271113315536513081388
domContentLoaded1271113215536513081388
domInteractive70303024185136
firstPaint------
backgroundConnect48171292252107
firstReactRender4536116124759
getState1274861419
initialActions113122
loadScripts1245111715286412791362
setupStore1375261420
numNetworkReqs86286725
WebpackPower User HomeuiStartup27661769368157332223471
load18671141294655123732561
domContentLoaded18661141294655123732561
domInteractive2832915904182341061
firstPaint------
backgroundConnect132251230204144407
firstReactRender57391221659101
getState1288035650151236
initialActions203123
loadScripts17991120291653622942525
setupStore224481502062
numNetworkReqs70551341668117
📊 Page Load Benchmark Results

Current Commit: c0675b7 | Date: 12/9/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

  • pageLoadTime-> current mean value: 1.05s (±45ms) 🟡 | historical mean value: 1.05s ⬇️ (historical data)
  • domContentLoaded-> current mean value: 732ms (±39ms) 🟢 | historical mean value: 734ms ⬇️ (historical data)
  • firstContentfulPaint-> current mean value: 75ms (±13ms) 🟢 | historical mean value: 79ms ⬇️ (historical data)

📈 Detailed Results

Metric Mean Std Dev Min Max P95 P99
pageLoadTime 1.05s 45ms 1.02s 1.37s 1.09s 1.37s
domContentLoaded 732ms 39ms 705ms 1.05s 753ms 1.05s
firstPaint 75ms 13ms 56ms 188ms 88ms 188ms
firstContentfulPaint 75ms 13ms 56ms 188ms 88ms 188ms
largestContentfulPaint 0ms 0ms 0ms 0ms 0ms 0ms
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 58 Bytes (0%)
  • ui: 8 Bytes (0%)
  • common: 20 Bytes (0%)

metamaskbot avatar Dec 09 '25 09:12 metamaskbot