metamask-extension icon indicating copy to clipboard operation
metamask-extension copied to clipboard

fix: transaction details total rendering

Open n3ps opened this issue 1 month ago • 5 comments

Description

Transaction details total was not rendered in the preferred chain

Open in GitHub Codespaces

Changelog

CHANGELOG entry: fix: transaction detail total rendering

Related issues

Fixes: https://github.com/MetaMask/metamask-extension/issues/35558

Manual testing steps

  1. Select All Popular Networks
  2. Go to Send flow and select Avalanche network
  3. Cancel the send request
  4. Go to Activity tab
  5. Click on a Sent transaction and notice the Total is displayed in AVAX

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

[!NOTE] Pass chainId through currency display components so transaction totals render in the correct chain currency; update tests accordingly.

  • Frontend
    • ui/components/app/transaction-breakdown/transaction-breakdown.component.js
      • Add chainId prop and forward it to UserPreferencedCurrencyDisplay for total (primary/secondary) values.
    • ui/components/app/user-preferenced-currency-display/user-preferenced-currency-display.component.js
      • Accept chainId; pass to useUserPreferencedCurrency and CurrencyDisplay.
  • Tests
    • ui/components/app/transaction-list-item-details/transaction-list-item-details.component.test.js
      • Update expected Total from ETH to POL to reflect chain-aware rendering.

Written by Cursor Bugbot for commit 812e9280155c59fbc147ec7ef179b6cfc811c34c. This will update automatically on new commits. Configure here.

n3ps avatar Dec 09 '25 05:12 n3ps

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

github-actions[bot] avatar Dec 09 '25 05:12 github-actions[bot]

Builds ready [b0ac305]
UI Startup Metrics (1251 ± 77 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyStandard HomeuiStartup1251101514367712971381
load102686012157210681161
domContentLoaded102085512077010571156
domInteractive21154162136
firstPaint52282122940710191152
backgroundConnect21519825712220243
firstReactRender4331211184559
getState3515121193887
initialActions104112
loadScripts81165697868845942
setupStore1273351322
numNetworkReqs86306629
BrowserifyPower User HomeuiStartup18941660252912819682107
load106891013059811631226
domContentLoaded105890013009811521221
domInteractive251675102648
firstPaint4868812973959811182
backgroundConnect266200691117239571
firstReactRender47389574859
getState19714365956207272
initialActions102112
loadScripts8486951092999431016
setupStore1695471535
numNetworkReqs67581081265103
WebpackStandard HomeuiStartup855721114866893968
load65757180159700778
domContentLoaded65256679659695770
domInteractive22175472341
firstPaint24788782193216688
backgroundConnect13575101330
firstReactRender61343034861153
getState251454103148
initialActions103112
loadScripts64856479459692768
setupStore1072231218
numNetworkReqs86316629
WebpackPower User HomeuiStartup14511177232519015291767
load706585106788731887
domContentLoaded699578105286723881
domInteractive2516106122450
firstPaint255104874190225735
backgroundConnect77756213665546
firstReactRender50419995071
getState18414363554190247
initialActions107111
loadScripts696576104286719878
setupStore1494061435
numNetworkReqs6755230196598
FirefoxBrowserifyStandard HomeuiStartup13831153195313314531596
load113098315279111771264
domContentLoaded113098315279111771264
domInteractive67332684085147
firstPaint------
backgroundConnect46251762750117
firstReactRender41337794166
getState1274571128
initialActions102122
loadScripts110296415028611471236
setupStore1278791124
numNetworkReqs86255724
BrowserifyPower User HomeuiStartup25681577345954230083223
load1598925241952521122279
domContentLoaded1597925241952521122279
domInteractive197301048345851035
firstPaint------
backgroundConnect1732111852491731100
firstReactRender533385115878
getState1357730646162215
initialActions203123
loadScripts1513909230449919702247
setupStore3452615634215
numNetworkReqs6749129136794
WebpackStandard HomeuiStartup15111303295519415711795
load12271084269916312691328
domContentLoaded12271084269916312691328
domInteractive6927151014879124
firstPaint------
backgroundConnect4119135194581
firstReactRender39318774051
getState1871763114108
initialActions103112
loadScripts12031069268416212431293
setupStore156126191252
numNetworkReqs86386726
WebpackPower User HomeuiStartup27731803392456032033605
load18431153285952923502553
domContentLoaded18431153285852923502552
domInteractive2143012423521031046
firstPaint------
backgroundConnect143241060175180380
firstReactRender5739123156191
getState1336426849167236
initialActions3039527
loadScripts17831112275250922782470
setupStore244352492064
numNetworkReqs70561251767118
📊 Page Load Benchmark Results

Current Commit: b0ac305 | Date: 12/9/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

  • pageLoadTime-> current mean value: 1.04s (±56ms) 🟡 | historical mean value: 1.05s ⬇️ (historical data)
  • domContentLoaded-> current mean value: 725ms (±70ms) 🟢 | historical mean value: 734ms ⬇️ (historical data)
  • firstContentfulPaint-> current mean value: 89ms (±136ms) 🟢 | historical mean value: 79ms ⬆️ (historical data)

📈 Detailed Results

Metric Mean Std Dev Min Max P95 P99
pageLoadTime 1.04s 56ms 1.01s 1.52s 1.07s 1.52s
domContentLoaded 725ms 70ms 699ms 1.38s 752ms 1.38s
firstPaint 89ms 136ms 60ms 1.44s 88ms 1.44s
firstContentfulPaint 89ms 136ms 60ms 1.44s 88ms 1.44s
largestContentfulPaint 0ms 0ms 0ms 0ms 0ms 0ms
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 58 Bytes (0%)
  • ui: 139 Bytes (0%)
  • common: 20 Bytes (0%)

metamaskbot avatar Dec 09 '25 05:12 metamaskbot

✨ Files requiring CODEOWNER review ✨

👨‍🔧 @MetaMask/core-extension-ux (1 files, +1 -1)
  • 📁 ui/
    • 📁 components/
      • 📁 app/
        • 📁 transaction-list-item-details/
          • 📄 transaction-list-item-details.component.test.js +1 -1

metamaskbot avatar Dec 09 '25 13:12 metamaskbot

Builds ready [20f70d1]
UI Startup Metrics (1288 ± 101 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyStandard HomeuiStartup12881079166410113491433
load105588513328511071188
domContentLoaded104887413248410991179
domInteractive2615159222383
firstPaint53078124740710341150
backgroundConnect21719826012222242
firstReactRender433288114572
getState3817114194277
initialActions104113
loadScripts838666111382880971
setupStore1274861322
numNetworkReqs1367619672
BrowserifyPower User HomeuiStartup19151568225413619562217
load1066877143412411581265
domContentLoaded1057869142912411511257
domInteractive32162513226102
firstPaint4559013503789071175
backgroundConnect265203760128229623
firstReactRender48389585066
getState19714273494194267
initialActions103112
loadScripts84766311991239391054
setupStore1675181535
numNetworkReqs71571492068130
WebpackStandard HomeuiStartup8557191067809021008
load65257684666700785
domContentLoaded64757284166696777
domInteractive2615117222392
firstPaint22282743154206621
backgroundConnect1153161328
firstReactRender53331903256144
getState291562113649
initialActions104112
loadScripts64456983165694770
setupStore1173051420
numNetworkReqs1467920674
WebpackPower User HomeuiStartup17091285228819218052062
load81862911231249361021
domContentLoaded80962411181239301008
domInteractive36181683331125
firstPaint3651091065268489951
backgroundConnect79872816932649
firstReactRender5642102106071
getState22314574585237357
initialActions103112
loadScripts80562211051229271005
setupStore17756101644
numNetworkReqs74582302868135
FirefoxBrowserifyStandard HomeuiStartup13521099193917214351725
load1091925155211511541298
domContentLoaded1090924155211511541297
domInteractive69302234295145
firstPaint------
backgroundConnect59233726153192
firstReactRender38307483856
getState147177181124
initialActions102122
loadScripts1063906151410111251264
setupStore135200201035
numNetworkReqs1668222777
BrowserifyPower User HomeuiStartup25931659347452630513292
load1631971247249620792351
domContentLoaded1631965247249620782350
domInteractive993092215479302
firstPaint------
backgroundConnect1942311652402331037
firstReactRender5839173196097
getState1295930644153216
initialActions207123
loadScripts1529948229745319642209
setupStore4443806853198
numNetworkReqs74571241981117
WebpackStandard HomeuiStartup16801434216018017592095
load13551194161610314181581
domContentLoaded13551189161610314181581
domInteractive803225641111151
firstPaint------
backgroundConnect64182264380173
firstReactRender463710085059
getState178192241531
initialActions103122
loadScripts1323117715749113851506
setupStore2772184215132
numNetworkReqs1668422881
WebpackPower User HomeuiStartup27811757404553131883484
load18971138257246322962461
domContentLoaded18961137257246322962461
domInteractive1342898623182939
firstPaint------
backgroundConnect16324981168198457
firstReactRender553696116174
getState1397099095161232
initialActions2136423
loadScripts18011116254743821932360
setupStore4253526930243
numNetworkReqs75551462277126
📊 Page Load Benchmark Results

Current Commit: 20f70d1 | Date: 12/9/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

  • pageLoadTime-> current mean value: 1.06s (±52ms) 🟡 | historical mean value: 1.06s ⬆️ (historical data)
  • domContentLoaded-> current mean value: 740ms (±50ms) 🟢 | historical mean value: 740ms ⬆️ (historical data)
  • firstContentfulPaint-> current mean value: 79ms (±11ms) 🟢 | historical mean value: 81ms ⬇️ (historical data)

📈 Detailed Results

Metric Mean Std Dev Min Max P95 P99
pageLoadTime 1.06s 52ms 1.03s 1.34s 1.13s 1.34s
domContentLoaded 740ms 50ms 714ms 1.02s 772ms 1.02s
firstPaint 79ms 11ms 60ms 168ms 88ms 168ms
firstContentfulPaint 79ms 11ms 60ms 168ms 88ms 168ms
largestContentfulPaint 0ms 0ms 0ms 0ms 0ms 0ms
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 2.36 KiB (0.04%)
  • ui: 1.14 KiB (0.01%)
  • common: 8.97 KiB (0.1%)

metamaskbot avatar Dec 09 '25 14:12 metamaskbot

Builds ready [812e928]
UI Startup Metrics (1264 ± 112 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyStandard HomeuiStartup12641017149011213581449
load103684912409410981203
domContentLoaded103084212349410891192
domInteractive2616102192278
firstPaint57881120141410301173
backgroundConnect21419524812221240
firstReactRender4732159185578
getState3517114163864
initialActions109113
loadScripts823653102590884990
setupStore1262941323
numNetworkReqs1468220673
BrowserifyPower User HomeuiStartup19451632262417720232334
load1110916176412911771341
domContentLoaded1100908175112911681331
domInteractive32171322428102
firstPaint621117176744511131245
backgroundConnect24620557266244322
firstReactRender50408275164
getState21615571980225314
initialActions104112
loadScripts88070215191289391121
setupStore1764881738
numNetworkReqs71571361768119
WebpackStandard HomeuiStartup9147461294889531062
load692583102282743852
domContentLoaded686576101582736847
domInteractive28161122224100
firstPaint236881023167226759
backgroundConnect13686121332
firstReactRender62342274262170
getState3215102174065
initialActions104112
loadScripts683573100681734837
setupStore1253541320
numNetworkReqs1368018670
WebpackPower User HomeuiStartup14401160188215314951776
load71459092593776893
domContentLoaded70858491893767887
domInteractive31161572925110
firstPaint25792893200249724
backgroundConnect60758310860395
firstReactRender48376354960
getState17913734034190249
initialActions104112
loadScripts70558291592765879
setupStore1374061332
numNetworkReqs71551361968129
FirefoxBrowserifyStandard HomeuiStartup13651119254423514081781
load1097947222418011361261
domContentLoaded1097946222418011361261
domInteractive68342163588137
firstPaint------
backgroundConnect51222874165131
firstReactRender39306374057
getState156161231038
initialActions102012
loadScripts1068929213817011021224
setupStore13698131232
numNetworkReqs16682211475
BrowserifyPower User HomeuiStartup25591579339151929993242
load1549964243649520532277
domContentLoaded1549964243649620532277
domInteractive16931104728295940
firstPaint------
backgroundConnect179241125228182951
firstReactRender523396115678
getState1266731742149220
initialActions207123
loadScripts1477939231646419342217
setupStore3642555340175
numNetworkReqs74541302071119
WebpackStandard HomeuiStartup16101351207715216921937
load12831097157510413401468
domContentLoaded12821097157510413401468
domInteractive70271703799130
firstPaint------
backgroundConnect59152333967139
firstReactRender433392114655
getState197145231560
initialActions103122
loadScripts1251108115509713131432
setupStore185176241565
numNetworkReqs16682211278
WebpackPower User HomeuiStartup361921551105799140174531
load23591409974592227493139
domContentLoaded23581408974492227483138
domInteractive269377260752135973
firstPaint------
backgroundConnect2974211853183341036
firstReactRender78523062684105
getState16110137849191261
initialActions4146635
loadScripts22281380970590825283095
setupStore130121074190116493
numNetworkReqs77571833168171
📊 Page Load Benchmark Results

Current Commit: 812e928 | Date: 12/9/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

  • pageLoadTime-> current mean value: 1.04s (±44ms) 🟡 | historical mean value: 1.05s ⬇️ (historical data)
  • domContentLoaded-> current mean value: 723ms (±41ms) 🟢 | historical mean value: 736ms ⬇️ (historical data)
  • firstContentfulPaint-> current mean value: 77ms (±16ms) 🟢 | historical mean value: 80ms ⬇️ (historical data)

📈 Detailed Results

Metric Mean Std Dev Min Max P95 P99
pageLoadTime 1.04s 44ms 1.01s 1.38s 1.07s 1.38s
domContentLoaded 723ms 41ms 698ms 1.05s 748ms 1.05s
firstPaint 77ms 16ms 60ms 220ms 84ms 220ms
firstContentfulPaint 77ms 16ms 60ms 220ms 84ms 220ms
largestContentfulPaint 0ms 0ms 0ms 0ms 0ms 0ms
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 2.36 KiB (0.04%)
  • ui: 1.58 KiB (0.02%)
  • common: 8.97 KiB (0.1%)

metamaskbot avatar Dec 09 '25 15:12 metamaskbot

Builds ready [afc1298]
UI Startup Metrics (1255 ± 97 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyStandard HomeuiStartup1255104415139713191413
load102886212408110681168
domContentLoaded102285612338010631162
domInteractive251589192183
firstPaint52374119039410181092
backgroundConnect21219727512217235
firstReactRender4729110145275
getState41181502444111
initialActions106112
loadScripts81766299677858964
setupStore1162841321
numNetworkReqs1368619669
BrowserifyPower User HomeuiStartup19101540241317319772278
load1055878145511511451235
domContentLoaded1045870140511311351229
domInteractive2916102202789
firstPaint51311114773969531195
backgroundConnect24920162093233553
firstReactRender47397865059
getState19014568458197258
initialActions102112
loadScripts83467511911109261026
setupStore1674171535
numNetworkReqs73592042370124
WebpackStandard HomeuiStartup85569813441008971021
load686585101285733838
domContentLoaded68057999384727831
domInteractive2716101212492
firstPaint26479799180286704
backgroundConnect1264881331
firstReactRender60343444656152
getState301572133759
initialActions103112
loadScripts67757798982725816
setupStore1265481333
numNetworkReqs1367919671
WebpackPower User HomeuiStartup14311096204319415941799
load7315941137105842894
domContentLoaded7245871125104834889
domInteractive31171202526106
firstPaint2681121142205233685
backgroundConnect88769017160576
firstReactRender50427665265
getState18113727131194253
initialActions102011
loadScripts7215851113103827880
setupStore1665391536
numNetworkReqs73591552269136
FirefoxBrowserifyStandard HomeuiStartup12751074188917413211682
load103389915809910871206
domContentLoaded103389915799910871205
domInteractive59312083685133
firstPaint------
backgroundConnect49222864843172
firstReactRender37297083954
getState12791101130
initialActions102012
loadScripts101088315519410561168
setupStore1255291039
numNetworkReqs1568421875
BrowserifyPower User HomeuiStartup26151531376150630213252
load1639930249947220632362
domContentLoaded1638929249947220632362
domInteractive13731107923688915
firstPaint------
backgroundConnect206221138235213915
firstReactRender5434187185979
getState1313923641155217
initialActions207123
loadScripts1530916232243819222182
setupStore3943146430234
numNetworkReqs76591402284125
WebpackStandard HomeuiStartup16211328282020816792023
load13321135251516713801600
domContentLoaded13321135251516713801600
domInteractive762316236100132
firstPaint------
backgroundConnect58221433173120
firstReactRender4433101114858
getState177138191551
initialActions103122
loadScripts13031117248716313491580
setupStore156114161248
numNetworkReqs1568721877
WebpackPower User HomeuiStartup26491818357346129803401
load18701143270145823182464
domContentLoaded18701143270045823182464
domInteractive16229100325994940
firstPaint------
backgroundConnect169271076222186955
firstReactRender5538121116270
getState1357727450163241
initialActions2133326
loadScripts17751127267743622002413
setupStore3252744931154
numNetworkReqs76571462277127
📊 Page Load Benchmark Results

Current Commit: afc1298 | Date: 12/10/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

  • pageLoadTime-> current mean value: 1.04s (±136ms) 🟡 | historical mean value: 1.04s ⬆️ (historical data)
  • domContentLoaded-> current mean value: 731ms (±161ms) 🟢 | historical mean value: 723ms ⬆️ (historical data)
  • firstContentfulPaint-> current mean value: 90ms (±146ms) 🟢 | historical mean value: 77ms ⬆️ (historical data)

📈 Detailed Results

Metric Mean Std Dev Min Max P95 P99
pageLoadTime 1.04s 136ms 1.00s 2.37s 1.07s 2.37s
domContentLoaded 731ms 161ms 694ms 2.32s 747ms 2.32s
firstPaint 90ms 146ms 56ms 1.54s 88ms 1.54s
firstContentfulPaint 90ms 146ms 56ms 1.54s 88ms 1.54s
largestContentfulPaint 0ms 0ms 0ms 0ms 0ms 0ms
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 58 Bytes (0%)
  • ui: 139 Bytes (0%)
  • common: 20 Bytes (0%)

metamaskbot avatar Dec 10 '25 18:12 metamaskbot