metamask-extension icon indicating copy to clipboard operation
metamask-extension copied to clipboard

feat: add sign permission confirmation for erc20 revocation permission

Open jeffsmale90 opened this issue 1 month ago • 8 comments

Description

Adds confirmation content for the erc20-token-revocation permission type.

Because this is the first permission type that is not a "token spend" type permission, it requires a different title, so this PR also adds this differentiation. Presently this is a simple switch statement. If the collection of titles grows to an unwieldy number, we can decompose it into a helper function, but I've left in place for simplicity.

This PR does not introduce the new permission type. That will be done in a future change that introduces updated permission snaps.

Also updates controllers released in https://github.com/MetaMask/core/pull/7330

Open in GitHub Codespaces

Changelog

CHANGELOG entry: null

Manual testing steps

Test in conjunction with https://github.com/MetaMask/snap-7715-permissions/pull/234

Screenshots/Recordings

image

Pre-merge author checklist

Pre-merge reviewer checklist

  • [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

[!NOTE] Adds confirmation UI and title descriptions for erc20-token-revocation, with i18n, tests, and controller dependency updates.

  • Confirmations UI:
    • Add Erc20TokenRevocationDetails component and render path in typed-sign-permission.tsx for erc20-token-revocation.
    • Use helper getPermissionDescription to select description per permission type in title.tsx.
  • i18n:
    • Add confirmTitleDescERC20Revocation string to app/_locales/en*/messages.json.
  • Tests:
    • New tests for revocation details component.
    • Update gator permissions hook/selectors tests to include erc20-token-revocation in maps.
  • Dependencies:
    • Bump @metamask/gator-permissions-controller to ^0.8.0, @metamask/signature-controller to ^38.0.0, @metamask/shield-controller to ^4.0.0, and related lockfile updates (e.g., @metamask/7715-permission-types@^0.4.0, @metamask/transaction-controller@^62.5.0, @metamask/logging-controller@^7.0.1).

Written by Cursor Bugbot for commit d3c03e7c53f08b5c910994ddc1e4f036701049b7. This will update automatically on new commits. Configure here.

jeffsmale90 avatar Dec 03 '25 03:12 jeffsmale90

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

github-actions[bot] avatar Dec 03 '25 03:12 github-actions[bot]

✨ Files requiring CODEOWNER review ✨

@MetaMask/confirmations (5 files, +105 -2)
  • 📁 ui/
    • 📁 pages/
      • 📁 confirmations/
        • 📁 components/
          • 📁 confirm/
            • 📁 info/
              • 📁 typed-sign/
                • 📁 typed-sign-permission/
                  • 📄 erc20-token-revocation-details.test.tsx +43 -0
                  • 📄 erc20-token-revocation-details.tsx +29 -0
                  • 📄 typed-sign-permission-util.ts +19 -0
                  • 📄 typed-sign-permission.tsx +6 -1
            • 📁 title/
              • 📄 title.tsx +8 -1

📜 @MetaMask/policy-reviewers (5 files, +5 -77)
  • 📁 lavamoat/
    • 📁 browserify/
      • 📁 beta/
        • 📄 policy.json +1 -19
      • 📁 experimental/
        • 📄 policy.json +1 -19
      • 📁 flask/
        • 📄 policy.json +1 -19
      • 📁 main/
        • 📄 policy.json +1 -19
    • 📁 webpack/
      • 📁 mv2/
        • 📄 policy.json +1 -1

[!TIP]
Follow the policy review process outlined in the LavaMoat Policy Review Process doc before expecting an approval from Policy Reviewers.

metamaskbot avatar Dec 03 '25 03:12 metamaskbot

Builds ready [43a6935]
UI Startup Metrics (1250 ± 121 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyStandard HomeuiStartup12501010161012113311480
load1049865141411011371261
domContentLoaded1043856140810911281237
domInteractive2615107192281
firstPaint5068213184079771211
backgroundConnect21619626013221243
firstReactRender30205893251
getState3514110174169
initialActions104112
loadScripts83364911891059041001
setupStore1173841216
numNetworkReqs1257320571
BrowserifyPower User HomeuiStartup20371675259718820892449
load1030914156811710311310
domContentLoaded1015909155211710131295
domInteractive34171302235101
firstPaint55413015564039871298
backgroundConnect24720566880231503
firstReactRender5639106126283
getState204130732107204258
initialActions103112
loadScripts80469913381168041082
setupStore211068102347
numNetworkReqs1406732159203245
WebpackStandard HomeuiStartup8296991108948651041
load64656696789671874
domContentLoaded64156095889664869
domInteractive2715120242296
firstPaint26174888200264715
backgroundConnect1168991118
firstReactRender2820112103339
getState251351103345
initialActions104112
loadScripts63855895587661861
setupStore1062331217
numNetworkReqs1257520572
WebpackPower User HomeuiStartup15371232224720415741984
load6755751217102676930
domContentLoaded6655691213103662925
domInteractive35181752735100
firstPaint28082819175288652
backgroundConnect46863512419518
firstReactRender57448286272
getState17213223118179212
initialActions104112
loadScripts6625681203101660916
setupStore20958102343
numNetworkReqs1636830963221275
FirefoxBrowserifyStandard HomeuiStartup13431083175715514861654
load1110937141410911721320
domContentLoaded1109937141410911721319
domInteractive65302143886157
firstPaint------
backgroundConnect4522183294999
firstReactRender24185162336
getState126100101224
initialActions103022
loadScripts108092013819711411257
setupStore1156281022
numNetworkReqs1257117662
BrowserifyPower User HomeuiStartup26871905545159927754287
load1247991265729712861878
domContentLoaded1247991265729712861877
domInteractive12733521110120419
firstPaint------
backgroundConnect124251044129126352
firstReactRender5635106135982
getState29562937223402756
initialActions207123
loadScripts1207977253427112481748
setupStore15810828189189660
numNetworkReqs915722036104166
WebpackStandard HomeuiStartup15101290199914316031765
load12421065154810513011433
domContentLoaded12411065154710513011432
domInteractive55281412878114
firstPaint------
backgroundConnect47211242546109
firstReactRender26188082636
getState137166171329
initialActions204134
loadScripts1216105215139712771406
setupStore145111131436
numNetworkReqs1156715757
WebpackPower User HomeuiStartup29732079947094829094861
load15441189656966615352868
domContentLoaded15431189656966615342868
domInteractive125311055136118400
firstPaint------
backgroundConnect1852617072711731056
firstReactRender66382373463148
getState247661071207256786
initialActions207123
loadScripts14671170638660614492615
setupStore1556708198187630
numNetworkReqs936131744102196
📊 Page Load Benchmark Results

Current Commit: 43a6935 | Date: 12/3/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

  • pageLoadTime-> current mean value: 1.04s (±42ms) 🟡 | historical mean value: 1.04s ⬆️ (historical data)
  • domContentLoaded-> current mean value: 724ms (±37ms) 🟢 | historical mean value: 722ms ⬆️ (historical data)
  • firstContentfulPaint-> current mean value: 77ms (±12ms) 🟢 | historical mean value: 78ms ⬇️ (historical data)

📈 Detailed Results

Metric Mean Std Dev Min Max P95 P99
pageLoadTime 1.04s 42ms 1.01s 1.35s 1.09s 1.35s
domContentLoaded 724ms 37ms 702ms 1.01s 746ms 1.01s
firstPaint 77ms 12ms 64ms 180ms 88ms 180ms
firstContentfulPaint 77ms 12ms 64ms 180ms 88ms 180ms
largestContentfulPaint 0ms 0ms 0ms 0ms 0ms 0ms
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 502.34 KiB (10.74%)
  • ui: -80 Bytes (0%)
  • common: 188.31 KiB (2.13%)

metamaskbot avatar Dec 03 '25 04:12 metamaskbot

Builds ready [3a31aaf]
UI Startup Metrics (1237 ± 105 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyStandard HomeuiStartup12371026168010512991367
load103485914228810821164
domContentLoaded102785714158710761158
domInteractive2615162242185
firstPaint4678214333789731098
backgroundConnect21819827614222245
firstReactRender311866103757
getState3816151224377
initialActions104112
loadScripts815646120286853953
setupStore1273351421
numNetworkReqs1157017562
BrowserifyPower User HomeuiStartup21251516313130223542641
load1070855187117711261448
domContentLoaded1057847185617611171437
domInteractive35162373330114
firstPaint808109186440210401370
backgroundConnect300186863163266725
firstReactRender5641106106071
getState20814467759227285
initialActions104112
loadScripts83465014601618771207
setupStore1695091541
numNetworkReqs80652583075154
WebpackStandard HomeuiStartup8387031211828701003
load64956299179687803
domContentLoaded64455997378684799
domInteractive2816153242495
firstPaint21586799137204599
backgroundConnect1167081225
firstReactRender28204763340
getState271495123645
initialActions103112
loadScripts64155696576682797
setupStore1163851321
numNetworkReqs1056716560
WebpackPower User HomeuiStartup16431249226126919052145
load66057795889690869
domContentLoaded65157295088682860
domInteractive32171552528101
firstPaint310116854205371723
backgroundConnect1347644217102564
firstReactRender604595106781
getState19714786988195245
initialActions103112
loadScripts64857093886680851
setupStore18950121446
numNetworkReqs80632253073155
FirefoxBrowserifyStandard HomeuiStartup13281091179115714491667
load1098946154410911741299
domContentLoaded1098946154410911741299
domInteractive61311993484133
firstPaint------
backgroundConnect47231843150115
firstReactRender22183752335
getState11674111027
initialActions103122
loadScripts1069930148310011331250
setupStore14519526937
numNetworkReqs1256417763
BrowserifyPower User HomeuiStartup31231956576793640444774
load1449951407857414802534
domContentLoaded1448950407857414802534
domInteractive127312765275110313
firstPaint------
backgroundConnect3252414944084191165
firstReactRender67373174167131
getState3308711612724551025
initialActions204123
loadScripts1270937406043413572241
setupStore1355912211119747
numNetworkReqs75541382275130
WebpackStandard HomeuiStartup15221287206416616121866
load12461073164411613081479
domContentLoaded12461073164411613081479
domInteractive58271903581130
firstPaint------
backgroundConnect50201873055128
firstReactRender28207773035
getState187216331358
initialActions103122
loadScripts12181060158410912861454
setupStore156137211077
numNetworkReqs1256617764
WebpackPower User HomeuiStartup32482041632797541055150
load16491127358757321312744
domContentLoaded16491126358757321312743
domInteractive145301248216121608
firstPaint------
backgroundConnect2282912713122111134
firstReactRender64372403167118
getState318631293294434956
initialActions216122
loadScripts15201098356549515242549
setupStore11061148183112425
numNetworkReqs77601362175127
📊 Page Load Benchmark Results

Current Commit: 3a31aaf | Date: 12/4/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

  • pageLoadTime-> current mean value: 1.03s (±36ms) 🟡 | historical mean value: 1.04s ⬇️ (historical data)
  • domContentLoaded-> current mean value: 714ms (±34ms) 🟢 | historical mean value: 723ms ⬇️ (historical data)
  • firstContentfulPaint-> current mean value: 74ms (±11ms) 🟢 | historical mean value: 78ms ⬇️ (historical data)

📈 Detailed Results

Metric Mean Std Dev Min Max P95 P99
pageLoadTime 1.03s 36ms 999ms 1.29s 1.05s 1.29s
domContentLoaded 714ms 34ms 690ms 970ms 738ms 970ms
firstPaint 74ms 11ms 60ms 168ms 88ms 168ms
firstContentfulPaint 74ms 11ms 60ms 168ms 88ms 168ms
largestContentfulPaint 0ms 0ms 0ms 0ms 0ms 0ms
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 528.28 KiB (11.3%)
  • ui: 5.11 KiB (0.07%)
  • common: 155.08 KiB (1.76%)

metamaskbot avatar Dec 04 '25 02:12 metamaskbot

Builds ready [d8071e3]
📊 Page Load Benchmark Results

Current Commit: d8071e3 | Date: 12/10/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

  • pageLoadTime-> current mean value: 1.04s (±68ms) 🟡 | historical mean value: 1.04s ⬇️ (historical data)
  • domContentLoaded-> current mean value: 727ms (±65ms) 🟢 | historical mean value: 727ms ⬆️ (historical data)
  • firstContentfulPaint-> current mean value: 77ms (±13ms) 🟢 | historical mean value: 83ms ⬇️ (historical data)

📈 Detailed Results

Metric Mean Std Dev Min Max P95 P99
pageLoadTime 1.04s 68ms 1.00s 1.31s 1.26s 1.31s
domContentLoaded 727ms 65ms 695ms 994ms 931ms 994ms
firstPaint 77ms 13ms 60ms 192ms 84ms 192ms
firstContentfulPaint 77ms 13ms 60ms 192ms 84ms 192ms
largestContentfulPaint 0ms 0ms 0ms 0ms 0ms 0ms
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 232.43 KiB (4.4%)
  • ui: 1.84 KiB (0.02%)
  • common: 1.43 KiB (0.02%)

metamaskbot avatar Dec 10 '25 01:12 metamaskbot

Builds ready [756704a]
📊 Page Load Benchmark Results

Current Commit: 756704a | Date: 12/10/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

  • pageLoadTime-> current mean value: 1.03s (±42ms) 🟡 | historical mean value: 1.04s ⬇️ (historical data)
  • domContentLoaded-> current mean value: 714ms (±35ms) 🟢 | historical mean value: 727ms ⬇️ (historical data)
  • firstContentfulPaint-> current mean value: 76ms (±12ms) 🟢 | historical mean value: 83ms ⬇️ (historical data)

📈 Detailed Results

Metric Mean Std Dev Min Max P95 P99
pageLoadTime 1.03s 42ms 1.00s 1.30s 1.06s 1.30s
domContentLoaded 714ms 35ms 694ms 968ms 734ms 968ms
firstPaint 76ms 12ms 56ms 176ms 88ms 176ms
firstContentfulPaint 76ms 12ms 56ms 176ms 88ms 176ms
largestContentfulPaint 0ms 0ms 0ms 0ms 0ms 0ms
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 232.43 KiB (4.4%)
  • ui: 1.82 KiB (0.02%)
  • common: 1.43 KiB (0.02%)

metamaskbot avatar Dec 10 '25 03:12 metamaskbot

Builds ready [d3c03e7]
📊 Page Load Benchmark Results

Current Commit: d3c03e7 | Date: 12/10/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

  • pageLoadTime-> current mean value: 1.05s (±40ms) 🟡 | historical mean value: 1.04s ⬆️ (historical data)
  • domContentLoaded-> current mean value: 734ms (±37ms) 🟢 | historical mean value: 727ms ⬆️ (historical data)
  • firstContentfulPaint-> current mean value: 79ms (±14ms) 🟢 | historical mean value: 82ms ⬇️ (historical data)

📈 Detailed Results

Metric Mean Std Dev Min Max P95 P99
pageLoadTime 1.05s 40ms 1.01s 1.32s 1.10s 1.32s
domContentLoaded 734ms 37ms 701ms 988ms 770ms 988ms
firstPaint 79ms 14ms 60ms 208ms 88ms 208ms
firstContentfulPaint 79ms 14ms 60ms 208ms 88ms 208ms
largestContentfulPaint 0ms 0ms 0ms 0ms 0ms 0ms
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 232.43 KiB (4.4%)
  • ui: 1.82 KiB (0.02%)
  • common: 1.43 KiB (0.02%)

metamaskbot avatar Dec 10 '25 06:12 metamaskbot

Builds ready [f50f51b]
📊 Page Load Benchmark Results

Current Commit: f50f51b | Date: 12/10/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

  • pageLoadTime-> current mean value: 1.04s (±62ms) 🟡 | historical mean value: 1.03s ⬆️ (historical data)
  • domContentLoaded-> current mean value: 727ms (±60ms) 🟢 | historical mean value: 719ms ⬆️ (historical data)
  • firstContentfulPaint-> current mean value: 76ms (±12ms) 🟢 | historical mean value: 77ms ⬇️ (historical data)

📈 Detailed Results

Metric Mean Std Dev Min Max P95 P99
pageLoadTime 1.04s 62ms 1.01s 1.31s 1.24s 1.31s
domContentLoaded 727ms 60ms 696ms 1000ms 925ms 1000ms
firstPaint 76ms 12ms 60ms 176ms 84ms 176ms
firstContentfulPaint 76ms 12ms 60ms 176ms 84ms 176ms
largestContentfulPaint 0ms 0ms 0ms 0ms 0ms 0ms
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 81.48 KiB (1.54%)
  • ui: 8.23 KiB (0.11%)
  • common: 1.25 KiB (0.01%)

metamaskbot avatar Dec 10 '25 20:12 metamaskbot

Builds ready [f50f51b]
📊 Page Load Benchmark Results

Current Commit: f50f51b | Date: 12/10/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

  • pageLoadTime-> current mean value: 1.04s (±62ms) 🟡 | historical mean value: 1.03s ⬆️ (historical data)
  • domContentLoaded-> current mean value: 727ms (±60ms) 🟢 | historical mean value: 718ms ⬆️ (historical data)
  • firstContentfulPaint-> current mean value: 76ms (±12ms) 🟢 | historical mean value: 76ms ⬇️ (historical data)

📈 Detailed Results

Metric Mean Std Dev Min Max P95 P99
pageLoadTime 1.04s 62ms 1.01s 1.31s 1.24s 1.31s
domContentLoaded 727ms 60ms 696ms 1000ms 925ms 1000ms
firstPaint 76ms 12ms 60ms 176ms 84ms 176ms
firstContentfulPaint 76ms 12ms 60ms 176ms 84ms 176ms
largestContentfulPaint 0ms 0ms 0ms 0ms 0ms 0ms
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 81.48 KiB (1.54%)
  • ui: 8.23 KiB (0.11%)
  • common: 1.25 KiB (0.01%)

metamaskbot avatar Dec 11 '25 00:12 metamaskbot

Builds ready [acabce9]
📊 Page Load Benchmark Results

Current Commit: acabce9 | Date: 12/11/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

  • pageLoadTime-> current mean value: 1.04s (±51ms) 🟡 | historical mean value: 1.03s ⬆️ (historical data)
  • domContentLoaded-> current mean value: 725ms (±49ms) 🟢 | historical mean value: 719ms ⬆️ (historical data)
  • firstContentfulPaint-> current mean value: 76ms (±13ms) 🟢 | historical mean value: 76ms ⬇️ (historical data)

📈 Detailed Results

Metric Mean Std Dev Min Max P95 P99
pageLoadTime 1.04s 51ms 1.01s 1.31s 1.10s 1.31s
domContentLoaded 725ms 49ms 698ms 998ms 774ms 998ms
firstPaint 76ms 13ms 56ms 196ms 84ms 196ms
firstContentfulPaint 76ms 13ms 56ms 196ms 84ms 196ms
largestContentfulPaint 0ms 0ms 0ms 0ms 0ms 0ms
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 232.41 KiB (4.53%)
  • ui: 1.84 KiB (0.02%)
  • common: 1.44 KiB (0.02%)

metamaskbot avatar Dec 11 '25 03:12 metamaskbot

Builds ready [40bd711]
UI Startup Metrics (1268 ± 109 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyStandard HomeuiStartup12681041147610913441446
load104385812569211031193
domContentLoaded103685512519110971187
domInteractive2715114222189
firstPaint5227712414039931147
backgroundConnect21619627213223241
firstReactRender443196125268
getState3916123214792
initialActions105112
loadScripts828653104888881986
setupStore1272551522
numNetworkReqs1368420672
BrowserifyPower User HomeuiStartup19261552253115719952220
load1082885158113311901289
domContentLoaded1071877157613311761280
domInteractive32171502627109
firstPaint57791129440310091233
backgroundConnect25019763993232560
firstReactRender48388574962
getState20615075297209284
initialActions103112
loadScripts85967713611329621065
setupStore1775691737
numNetworkReqs70581361967127
WebpackStandard HomeuiStartup801666101775854946
load64756683970697796
domContentLoaded64156183270691790
domInteractive2515102192282
firstPaint25473746176234688
backgroundConnect1163361329
firstReactRender49322342951108
getState291486133853
initialActions104112
loadScripts63855882969689782
setupStore126129121319
numNetworkReqs1367319670
WebpackPower User HomeuiStartup14131129212718715781713
load73459799699815917
domContentLoaded72758999198807906
domInteractive31171272526102
firstPaint27893985223259861
backgroundConnect75759314085555
firstReactRender50417655264
getState18814466958191249
initialActions104112
loadScripts72458798497805904
setupStore17648101639
numNetworkReqs70551582167134
FirefoxBrowserifyStandard HomeuiStartup13651138211617514501730
load1100947178412211491320
domContentLoaded1099947178312211491319
domInteractive70342073489125
firstPaint------
backgroundConnect53223404559154
firstReactRender40326684462
getState137100111230
initialActions103122
loadScripts1070931175611311141217
setupStore13763111238
numNetworkReqs1568722878
BrowserifyPower User HomeuiStartup25841566354153930513385
load1611988255349520792335
domContentLoaded1611988255249520782335
domInteractive17132106227897982
firstPaint------
backgroundConnect199251074235221967
firstReactRender5639109146197
getState1407262467158242
initialActions2138523
loadScripts1517970237346719762286
setupStore484102911542220
numNetworkReqs76571352470129
WebpackStandard HomeuiStartup------
load------
domContentLoaded------
domInteractive------
firstPaint------
backgroundConnect------
firstReactRender------
getState------
initialActions------
loadScripts------
setupStore------
numNetworkReqs------
WebpackPower User HomeuiStartup------
load------
domContentLoaded------
domInteractive------
firstPaint------
backgroundConnect------
firstReactRender------
getState------
initialActions------
loadScripts------
setupStore------
numNetworkReqs------
📊 Page Load Benchmark Results

Current Commit: 40bd711 | Date: 12/11/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

  • pageLoadTime-> current mean value: 1.04s (±65ms) 🟡 | historical mean value: 1.03s ⬆️ (historical data)
  • domContentLoaded-> current mean value: 729ms (±62ms) 🟢 | historical mean value: 719ms ⬆️ (historical data)
  • firstContentfulPaint-> current mean value: 77ms (±14ms) 🟢 | historical mean value: 76ms ⬆️ (historical data)

📈 Detailed Results

Metric Mean Std Dev Min Max P95 P99
pageLoadTime 1.04s 65ms 1.01s 1.36s 1.25s 1.36s
domContentLoaded 729ms 62ms 700ms 1.01s 932ms 1.01s
firstPaint 77ms 14ms 60ms 196ms 88ms 196ms
firstContentfulPaint 77ms 14ms 60ms 196ms 88ms 196ms
largestContentfulPaint 0ms 0ms 0ms 0ms 0ms 0ms
Bundle size diffs [🚀 Bundle size reduced!]
  • background: -21.67 KiB (-0.42%)
  • ui: 1.7 KiB (0.02%)
  • common: 1.14 KiB (0.01%)

metamaskbot avatar Dec 11 '25 04:12 metamaskbot

Builds ready [9a8fe91]
UI Startup Metrics (1270 ± 104 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyStandard HomeuiStartup12701049165210413361450
load103786612958610841173
domContentLoaded103085712758510781169
domInteractive2615110212284
firstPaint48598129239110051141
backgroundConnect21619827113222243
firstReactRender4531226224471
getState3718104184191
initialActions105112
loadScripts821658106482866961
setupStore1153041321
numNetworkReqs1367820671
BrowserifyPower User HomeuiStartup18661549236315519452168
load1060870142011911441269
domContentLoaded1050861140011811331248
domInteractive2916102212592
firstPaint5569414314139991242
backgroundConnect254198608103232570
firstReactRender46376944853
getState19014668158201247
initialActions102012
loadScripts83965811961149211042
setupStore1563971534
numNetworkReqs70561381767123
WebpackStandard HomeuiStartup812676106276856958
load65157582664686790
domContentLoaded64557081964682783
domInteractive2616103182383
firstPaint23783812159222677
backgroundConnect1063141116
firstReactRender50321792553117
getState311490143757
initialActions104112
loadScripts64256881063679775
setupStore1263561526
numNetworkReqs1367318672
WebpackPower User HomeuiStartup14261105203119816131757
load7485851166114861914
domContentLoaded7415781159113853904
domInteractive32181812927101
firstPaint319941168247351843
backgroundConnect76762215942575
firstReactRender50397065363
getState19614572479202280
initialActions105112
loadScripts7385761150112851901
setupStore1674291436
numNetworkReqs71562202465130
FirefoxBrowserifyStandard HomeuiStartup13111069184517714271652
load105689913279911281247
domContentLoaded1055899132710011281247
domInteractive68302313985141
firstPaint------
backgroundConnect53202955147187
firstReactRender36296773755
getState137183191033
initialActions102012
loadScripts102988412678810931186
setupStore145100171151
numNetworkReqs1568021777
BrowserifyPower User HomeuiStartup26331662428656730193474
load16051007249947720662401
domContentLoaded16051007249847720652401
domInteractive15832107026093915
firstPaint------
backgroundConnect200281142249213958
firstReactRender5834186166183
getState1367235654163243
initialActions3141537
loadScripts1524988239144719452305
setupStore685105319740123
numNetworkReqs74531412270130
WebpackStandard HomeuiStartup------
load------
domContentLoaded------
domInteractive------
firstPaint------
backgroundConnect------
firstReactRender------
getState------
initialActions------
loadScripts------
setupStore------
numNetworkReqs------
WebpackPower User HomeuiStartup------
load------
domContentLoaded------
domInteractive------
firstPaint------
backgroundConnect------
firstReactRender------
getState------
initialActions------
loadScripts------
setupStore------
numNetworkReqs------
📊 Page Load Benchmark Results

Current Commit: 9a8fe91 | Date: 12/11/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

  • pageLoadTime-> current mean value: 1.04s (±40ms) 🟡 | historical mean value: 1.03s ⬆️ (historical data)
  • domContentLoaded-> current mean value: 722ms (±37ms) 🟢 | historical mean value: 719ms ⬆️ (historical data)
  • firstContentfulPaint-> current mean value: 77ms (±11ms) 🟢 | historical mean value: 76ms ⬆️ (historical data)

📈 Detailed Results

Metric Mean Std Dev Min Max P95 P99
pageLoadTime 1.04s 40ms 1.01s 1.31s 1.06s 1.31s
domContentLoaded 722ms 37ms 702ms 972ms 737ms 972ms
firstPaint 77ms 11ms 64ms 172ms 88ms 172ms
firstContentfulPaint 77ms 11ms 64ms 172ms 88ms 172ms
largestContentfulPaint 0ms 0ms 0ms 0ms 0ms 0ms
Bundle size diffs [🚀 Bundle size reduced!]
  • background: -21.67 KiB (-0.42%)
  • ui: 1.7 KiB (0.02%)
  • common: 1.14 KiB (0.01%)

metamaskbot avatar Dec 11 '25 07:12 metamaskbot

Builds ready [226f3cd]
UI Startup Metrics (1263 ± 109 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyStandard HomeuiStartup12631055161810913231465
load103487813229010841197
domContentLoaded102787313189010791187
domInteractive261591182279
firstPaint53779123940010021160
backgroundConnect21720127013226241
firstReactRender4532136155072
getState3717109144460
initialActions104112
loadScripts817650105186856975
setupStore1273951323
numNetworkReqs1367819668
BrowserifyPower User HomeuiStartup19221601244917120142261
load1086874134612211841306
domContentLoaded1076868133312111801300
domInteractive3318262322898
firstPaint581107135442110261271
backgroundConnect24819963281239511
firstReactRender483910895064
getState20514776383212294
initialActions103112
loadScripts85966911211199641059
setupStore16798111536
numNetworkReqs71581411968127
WebpackStandard HomeuiStartup816687103478872961
load65457585466685791
domContentLoaded64857184865678783
domInteractive251599192178
firstPaint25884828193228754
backgroundConnect1267891430
firstReactRender50331432162101
getState301586123849
initialActions103112
loadScripts64556983964675781
setupStore1253551519
numNetworkReqs1367720674
WebpackPower User HomeuiStartup14561145229420315801791
load7566041033108851938
domContentLoaded7485961025107844931
domInteractive33181503026123
firstPaint29888941226331841
backgroundConnect86868716665618
firstReactRender52417365465
getState19714635843219291
initialActions103112
loadScripts7455941015106841922
setupStore1664891536
numNetworkReqs71581462166137
FirefoxBrowserifyStandard HomeuiStartup13241085202918714071672
load1058895158711311091269
domContentLoaded1058894158611311031269
domInteractive64312524186140
firstPaint------
backgroundConnect48213434648146
firstReactRender38317593861
getState1174871024
initialActions102112
loadScripts1033878155610310731211
setupStore125124151028
numNetworkReqs1668922877
BrowserifyPower User HomeuiStartup25971699411353229863451
load1641984262249920942375
domContentLoaded1640984262249920942375
domInteractive163311101270105975
firstPaint------
backgroundConnect2482211633102121019
firstReactRender543696125882
getState1297031144157219
initialActions3034524
loadScripts1496969244346919162284
setupStore424102011038129
numNetworkReqs75581482183117
WebpackStandard HomeuiStartup------
load------
domContentLoaded------
domInteractive------
firstPaint------
backgroundConnect------
firstReactRender------
getState------
initialActions------
loadScripts------
setupStore------
numNetworkReqs------
WebpackPower User HomeuiStartup------
load------
domContentLoaded------
domInteractive------
firstPaint------
backgroundConnect------
firstReactRender------
getState------
initialActions------
loadScripts------
setupStore------
numNetworkReqs------
📊 Page Load Benchmark Results

Current Commit: 226f3cd | Date: 12/11/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

  • pageLoadTime-> current mean value: 1.06s (±75ms) 🟡 | historical mean value: 1.04s ⬆️ (historical data)
  • domContentLoaded-> current mean value: 742ms (±70ms) 🟢 | historical mean value: 724ms ⬆️ (historical data)
  • firstContentfulPaint-> current mean value: 78ms (±11ms) 🟢 | historical mean value: 79ms ⬇️ (historical data)

📈 Detailed Results

Metric Mean Std Dev Min Max P95 P99
pageLoadTime 1.06s 75ms 1.02s 1.39s 1.28s 1.39s
domContentLoaded 742ms 70ms 706ms 1.02s 959ms 1.02s
firstPaint 78ms 11ms 60ms 168ms 88ms 168ms
firstContentfulPaint 78ms 11ms 60ms 168ms 88ms 168ms
largestContentfulPaint 0ms 0ms 0ms 0ms 0ms 0ms
Bundle size diffs [🚀 Bundle size reduced!]
  • background: -21.67 KiB (-0.42%)
  • ui: 1.7 KiB (0.02%)
  • common: 1.14 KiB (0.01%)

metamaskbot avatar Dec 11 '25 19:12 metamaskbot

Sorry for the force push here - I ended up going around in circles trying to get the lavamoat policies updated. Made for a much cleaner PR if I collated the changes afresh.

jeffsmale90 avatar Dec 12 '25 00:12 jeffsmale90

Builds ready [faefbbf]
UI Startup Metrics (1234 ± 96 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyStandard HomeuiStartup1234102614729613001380
load101184912368310661169
domContentLoaded100484412218210581157
domInteractive2614112212286
firstPaint57181125740510151132
backgroundConnect21119323710216233
firstReactRender473189145578
getState3817118154564
initialActions104112
loadScripts799650100779850954
setupStore1263951521
numNetworkReqs1467920674
BrowserifyPower User HomeuiStartup18931543247216719822225
load1055878144513011411287
domContentLoaded1045873143313011341279
domInteractive30171462428100
firstPaint601101140442010101277
backgroundConnect260195646111236600
firstReactRender50398585268
getState18514667855191239
initialActions102112
loadScripts83567112031279201071
setupStore1594871334
numNetworkReqs72542252567131
WebpackStandard HomeuiStartup8166661503108835973
load65356585974694800
domContentLoaded64756183173690792
domInteractive2515112202177
firstPaint26785833210225778
backgroundConnect1168291328
firstReactRender54321833159134
getState281458113850
initialActions105111
loadScripts64455982172688785
setupStore1153051221
numNetworkReqs1367819670
WebpackPower User HomeuiStartup13951054202718714791764
load716588985102820896
domContentLoaded709581977101809889
domInteractive30161312625112
firstPaint32977989246404860
backgroundConnect55759810349194
firstReactRender48406145057
getState1766566656179235
initialActions102112
loadScripts706579969100802887
setupStore1564881337
numNetworkReqs71561462167135
FirefoxBrowserifyStandard HomeuiStartup13161048238226013821846
load1058887210620010971212
domContentLoaded1057887210620010961212
domInteractive8731114018082140
firstPaint------
backgroundConnect45202273844158
firstReactRender37295963850
getState227878871131
initialActions103112
loadScripts1035870208419710661172
setupStore146128151143
numNetworkReqs1568221976
BrowserifyPower User HomeuiStartup26071614458456530293374
load1599970268650920652416
domContentLoaded1599969268650920652416
domInteractive13731107922884948
firstPaint------
backgroundConnect203261104244225977
firstReactRender5734193186286
getState1425293497162238
initialActions2139523
loadScripts1492946266146519352281
setupStore56495611843241
numNetworkReqs75551372087120
WebpackStandard HomeuiStartup15901341224515816601895
load13101144167610313531550
domContentLoaded13091144167610313531550
domInteractive813018137110139
firstPaint------
backgroundConnect59202264366176
firstReactRender44328084757
getState14780101431
initialActions103122
loadScripts12801125164910113271520
setupStore176113201367
numNetworkReqs1568620975
WebpackPower User HomeuiStartup26471776427553530223543
load18681151332549623302516
domContentLoaded18681151332549623302516
domInteractive219271070334176977
firstPaint------
backgroundConnect168261063209204961
firstReactRender5636120146095
getState1318126643164213
initialActions2056523
loadScripts17871067255746122572449
setupStore3453435141133
numNetworkReqs75571402282126
📊 Page Load Benchmark Results

Current Commit: faefbbf | Date: 12/12/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

  • pageLoadTime-> current mean value: 1.03s (±68ms) 🟡 | historical mean value: 1.04s ⬇️ (historical data)
  • domContentLoaded-> current mean value: 723ms (±66ms) 🟢 | historical mean value: 730ms ⬇️ (historical data)
  • firstContentfulPaint-> current mean value: 75ms (±11ms) 🟢 | historical mean value: 83ms ⬇️ (historical data)

📈 Detailed Results

Metric Mean Std Dev Min Max P95 P99
pageLoadTime 1.03s 68ms 996ms 1.31s 1.27s 1.31s
domContentLoaded 723ms 66ms 687ms 987ms 939ms 987ms
firstPaint 75ms 11ms 60ms 164ms 84ms 164ms
firstContentfulPaint 75ms 11ms 60ms 164ms 84ms 164ms
largestContentfulPaint 0ms 0ms 0ms 0ms 0ms 0ms
Bundle size diffs [🚀 Bundle size reduced!]
  • background: -21.67 KiB (-0.42%)
  • ui: 1.7 KiB (0.02%)
  • common: 1.14 KiB (0.01%)

metamaskbot avatar Dec 12 '25 01:12 metamaskbot

@mj-kiwi

the number of tests for erc20-token-revocation is much lower than the other permission types. Should we address this in a future PR, or handle it in this one? This is inherently less complex because the only variable field is the expiry - given that I think there's sufficient coverage. LMK if you think there's anything specific missing.

I think we need to update the CHANGELOG entry: as well I've added no-changelog label because there's no end-user facing changes.

jeffsmale90 avatar Dec 12 '25 02:12 jeffsmale90

Builds ready [037f40c]
UI Startup Metrics (1270 ± 111 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyStandard HomeuiStartup12701009151711113501423
load103886112468811061178
domContentLoaded103185412398710991170
domInteractive251495192181
firstPaint57391121442310541154
backgroundConnect21419425111221238
firstReactRender4630104145175
getState3918148244497
initialActions104112
loadScripts824656102184889962
setupStore1263361324
numNetworkReqs1368419670
BrowserifyPower User HomeuiStartup19141535242215620002240
load1093897152213012031318
domContentLoaded1083892151212911881309
domInteractive31171372526109
firstPaint54596152642810291257
backgroundConnect24620260987234550
firstReactRender48397065061
getState20415172681211304
initialActions103112
loadScripts87068513041289761097
setupStore1574161532
numNetworkReqs70591361767122
WebpackStandard HomeuiStartup8426861473106887970
load675583131299714803
domContentLoaded669578130699709796
domInteractive2715113202387
firstPaint237881040183213693
backgroundConnect1163261228
firstReactRender58332164063180
getState3114119154253
initialActions103112
loadScripts666575129898707788
setupStore1275771431
numNetworkReqs1367719672
WebpackPower User HomeuiStartup15051132230521816831859
load7656041199114882928
domContentLoaded7575991190113876920
domInteractive33171572828114
firstPaint311911021232371847
backgroundConnect91867517949621
firstReactRender53427665568
getState19714433144209284
initialActions102011
loadScripts7545971180112869917
setupStore1764691536
numNetworkReqs72581442169134
FirefoxBrowserifyStandard HomeuiStartup15421177281929816422165
load1221978237122012761464
domContentLoaded1221978237122012761463
domInteractive8432126812692163
firstPaint------
backgroundConnect63213845377162
firstReactRender443487114871
getState198182291648
initialActions102122
loadScripts1188958234021612321413
setupStore187140241692
numNetworkReqs1568721875
BrowserifyPower User HomeuiStartup26031666385653129713412
load1598969245747320072312
domContentLoaded1597969245747320072312
domInteractive178321065280100949
firstPaint------
backgroundConnect195251115248201980
firstReactRender5638179185895
getState1347628247159236
initialActions3144627
loadScripts1492952228143718962222
setupStore515101411841233
numNetworkReqs76581372285125
WebpackStandard HomeuiStartup16721402290022217072122
load13721153261317014141599
domContentLoaded13711153261317014141599
domInteractive99291381135126160
firstPaint------
backgroundConnect65222424475147
firstReactRender4536109104559
getState206193311562
initialActions103122
loadScripts13401137259616713871571
setupStore206153271771
numNetworkReqs1568721875
WebpackPower User HomeuiStartup26871773410556131193493
load18901146329951823572548
domContentLoaded18901145329851823572547
domInteractive237301110351150989
firstPaint------
backgroundConnect176231176246185956
firstReactRender5838124146393
getState1357923844168226
initialActions3037628
loadScripts18001128271048322852521
setupStore4543266542191
numNetworkReqs72471312467122
📊 Page Load Benchmark Results

Current Commit: 037f40c | Date: 12/12/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

  • pageLoadTime-> current mean value: 1.04s (±37ms) 🟡 | historical mean value: 1.04s ⬇️ (historical data)
  • domContentLoaded-> current mean value: 721ms (±35ms) 🟢 | historical mean value: 730ms ⬇️ (historical data)
  • firstContentfulPaint-> current mean value: 76ms (±10ms) 🟢 | historical mean value: 82ms ⬇️ (historical data)

📈 Detailed Results

Metric Mean Std Dev Min Max P95 P99
pageLoadTime 1.04s 37ms 1.02s 1.30s 1.07s 1.30s
domContentLoaded 721ms 35ms 702ms 982ms 750ms 982ms
firstPaint 76ms 10ms 60ms 164ms 84ms 164ms
firstContentfulPaint 76ms 10ms 60ms 164ms 84ms 164ms
largestContentfulPaint 0ms 0ms 0ms 0ms 0ms 0ms
Bundle size diffs [🚀 Bundle size reduced!]
  • background: -21.67 KiB (-0.42%)
  • ui: 1.7 KiB (0.02%)
  • common: 1.12 KiB (0.01%)

metamaskbot avatar Dec 12 '25 03:12 metamaskbot

Builds ready [faefbbf]
UI Startup Metrics (1316 ± 127 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyStandard HomeuiStartup13161053176912714071492
load1072889144710611421233
domContentLoaded1064881143410511361222
domInteractive271695202384
firstPaint56787145844110691218
backgroundConnect22020332215226239
firstReactRender4832108175185
getState4014138214876
initialActions107113
loadScripts85167412201019191006
setupStore1273961325
numNetworkReqs1368320671
BrowserifyPower User HomeuiStartup19081525248415219862173
load1089881162713211731314
domContentLoaded1080873161113211611301
domInteractive33182003029111
firstPaint57397161843110221300
backgroundConnect24419962887232565
firstReactRender48397665160
getState20714271190216281
initialActions104112
loadScripts86667513521289501089
setupStore1593871434
numNetworkReqs72591402069134
WebpackStandard HomeuiStartup8596991308949171009
load68359590175730830
domContentLoaded67759089275725819
domInteractive2817119232399
firstPaint23793821169228716
backgroundConnect166236261244
firstReactRender59352173567143
getState311489143962
initialActions104112
loadScripts67458788274723817
setupStore1263351419
numNetworkReqs1467820675
WebpackPower User HomeuiStartup14961160215721216811912
load7676191243116875963
domContentLoaded7596121236116866955
domInteractive32181292727114
firstPaint352108979258632908
backgroundConnect81765015652617
firstReactRender53447155562
getState20114275268215270
initialActions102112
loadScripts7556091223115862952
setupStore1574381436
numNetworkReqs71571452167133
FirefoxBrowserifyStandard HomeuiStartup12671055192117213411622
load1024893156910410661221
domContentLoaded1023892156910410661220
domInteractive52302012964112
firstPaint------
backgroundConnect47192794446150
firstReactRender36305653749
getState126100101123
initialActions103012
loadScripts99987715439510461153
setupStore125183191035
numNetworkReqs1668321879
BrowserifyPower User HomeuiStartup26511665349048630163367
load1648963254349220702433
domContentLoaded1648963254249220702433
domInteractive173301025274177974
firstPaint------
backgroundConnect2182511432742161041
firstReactRender5737110146187
getState1337196193149228
initialActions3142623
loadScripts1537946243845419442274
setupStore454102011538224
numNetworkReqs75531252081119
WebpackStandard HomeuiStartup15731333236516216521848
load1303110916469413561465
domContentLoaded1302110416469413561465
domInteractive71291683590133
firstPaint------
backgroundConnect54212163357127
firstReactRender42358474456
getState197186281566
initialActions104112
loadScripts1276109515698813261438
setupStore16697161549
numNetworkReqs1668221976
WebpackPower User HomeuiStartup27091787426454430923390
load19321129343749823612535
domContentLoaded19321129343749823612534
domInteractive253291117361269981
firstPaint------
backgroundConnect134251113158179314
firstReactRender5538128136080
getState1327932849170223
initialActions2045527
loadScripts18511112264846622562504
setupStore3343185530182
numNetworkReqs73491332275125
📊 Page Load Benchmark Results

Current Commit: faefbbf | Date: 12/12/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

  • pageLoadTime-> current mean value: 1.02s (±38ms) 🟡 | historical mean value: 1.04s ⬇️ (historical data)
  • domContentLoaded-> current mean value: 711ms (±35ms) 🟢 | historical mean value: 727ms ⬇️ (historical data)
  • firstContentfulPaint-> current mean value: 74ms (±13ms) 🟢 | historical mean value: 82ms ⬇️ (historical data)

📈 Detailed Results

Metric Mean Std Dev Min Max P95 P99
pageLoadTime 1.02s 38ms 999ms 1.31s 1.05s 1.31s
domContentLoaded 711ms 35ms 690ms 975ms 733ms 975ms
firstPaint 74ms 13ms 60ms 192ms 80ms 192ms
firstContentfulPaint 74ms 13ms 60ms 192ms 80ms 192ms
largestContentfulPaint 0ms 0ms 0ms 0ms 0ms 0ms
Bundle size diffs [🚀 Bundle size reduced!]
  • background: -21.67 KiB (-0.42%)
  • ui: 1.69 KiB (0.02%)
  • common: 1.18 KiB (0.01%)

metamaskbot avatar Dec 12 '25 07:12 metamaskbot