metamask-extension
metamask-extension copied to clipboard
feat: enhance trust signals integration by scanning spender addresses
Description
Related issues
Fixes:
Manual testing steps
- Go to this page...
Screenshots/Recordings
Before
After
Pre-merge author checklist
- [ ] I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using JSDoc format if applicable
- [ ] I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
Pre-merge reviewer checklist
- [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.
✨ Files requiring CODEOWNER review ✨
✅ @MetaMask/confirmations (3 files, +11 -2)
- 📁 ui/
- 📁 pages/
- 📁 confirmations/
- 📁 components/
- 📁 confirm/
- 📁 info/
- 📁 approve/
- 📁 approve-details/
- 📄
approve-details.tsx+5 -1
- 📄
- 📁 approve-details/
- 📁 set-approval-for-all-info/
- 📁 revoke-set-approval-for-all-static-simulation/
- 📄
revoke-set-approval-for-all-static-simulation.tsx+1 -0
- 📄
- 📁 revoke-set-approval-for-all-static-simulation/
- 📁 typed-sign/
- 📄
typed-sign.tsx+5 -1
- 📄
- 📁 approve/
- 📁 info/
- 📁 confirm/
- 📁 components/
- 📁 confirmations/
- 📁 pages/
Builds ready [07e60b9]
- builds: chrome, firefox
- builds (beta): chrome, firefox
- builds (flask): chrome, firefox
- builds (test): chrome, firefox
- builds (test-flask): chrome, firefox
- build viz: Build System
- bundle size: Bundle Size Stats
- user-actions-benchmark: User Actions Stats
- storybook: Storybook
- typescript migration: Dashboard
- all artifacts
UI Startup Metrics (1237 ± 93 ms)
| Platform | BuildType | Page | Metric | Mean (ms) | Min (ms) | Max (ms) | Std Dev (ms) | P 75 (ms) | P 95 (ms) |
|---|---|---|---|---|---|---|---|---|---|
| Chrome | Browserify | Home | uiStartup | 1237 | 1086 | 1807 | 93 | 1279 | 1374 |
| load | 1075 | 902 | 1614 | 92 | 1118 | 1212 | |||
| domContentLoaded | 1069 | 897 | 1611 | 93 | 1113 | 1205 | |||
| domInteractive | 18 | 14 | 94 | 9 | 16 | 33 | |||
| firstPaint | 746 | 84 | 1212 | 426 | 1097 | 1186 | |||
| backgroundConnect | 7 | 4 | 40 | 5 | 8 | 20 | |||
| firstReactRender | 21 | 15 | 61 | 6 | 21 | 32 | |||
| getState | 13 | 6 | 35 | 7 | 18 | 29 | |||
| initialActions | 0 | 0 | 1 | 0 | 0 | 1 | |||
| loadScripts | 823 | 662 | 1355 | 91 | 865 | 949 | |||
| setupStore | 7 | 4 | 14 | 2 | 8 | 12 | |||
| Webpack | Home | uiStartup | 2007 | 1605 | 2495 | 221 | 2133 | 2381 | |
| load | 1571 | 1263 | 2043 | 183 | 1696 | 1865 | |||
| domContentLoaded | 1566 | 1259 | 2039 | 182 | 1692 | 1856 | |||
| domInteractive | 15 | 11 | 64 | 10 | 12 | 45 | |||
| firstPaint | 165 | 67 | 425 | 60 | 190 | 274 | |||
| backgroundConnect | 19 | 13 | 46 | 6 | 22 | 34 | |||
| firstReactRender | 101 | 45 | 350 | 77 | 95 | 319 | |||
| getState | 10 | 4 | 21 | 3 | 11 | 18 | |||
| initialActions | 5 | 1 | 282 | 28 | 3 | 4 | |||
| loadScripts | 1563 | 1258 | 2029 | 180 | 1689 | 1845 | |||
| setupStore | 56 | 6 | 328 | 105 | 17 | 312 | |||
| Firefox | Browserify | Home | uiStartup | 1288 | 1137 | 1664 | 75 | 1326 | 1405 |
| load | 1150 | 1019 | 1509 | 76 | 1189 | 1284 | |||
| domContentLoaded | 1150 | 1019 | 1509 | 76 | 1188 | 1284 | |||
| domInteractive | 98 | 35 | 166 | 26 | 109 | 144 | |||
| firstPaint | NaN | NaN | NaN | NaN | NaN | NaN | |||
| backgroundConnect | 19 | 13 | 55 | 6 | 20 | 26 | |||
| firstReactRender | 22 | 20 | 28 | 2 | 23 | 26 | |||
| getState | 7 | 4 | 36 | 4 | 8 | 9 | |||
| initialActions | 0 | 0 | 1 | 0 | 0 | 1 | |||
| loadScripts | 1133 | 1006 | 1481 | 74 | 1171 | 1259 | |||
| setupStore | 5 | 3 | 12 | 2 | 6 | 10 | |||
| Webpack | Home | uiStartup | 1530 | 1388 | 1740 | 89 | 1609 | 1706 | |
| load | 1328 | 1197 | 1536 | 90 | 1403 | 1508 | |||
| domContentLoaded | 1328 | 1196 | 1536 | 90 | 1402 | 1508 | |||
| domInteractive | 78 | 36 | 125 | 13 | 85 | 101 | |||
| firstPaint | NaN | NaN | NaN | NaN | NaN | NaN | |||
| backgroundConnect | 21 | 16 | 30 | 3 | 22 | 26 | |||
| firstReactRender | 41 | 31 | 55 | 4 | 44 | 47 | |||
| getState | 10 | 5 | 39 | 7 | 9 | 30 | |||
| initialActions | 0 | 0 | 2 | 1 | 1 | 1 | |||
| loadScripts | 1309 | 1176 | 1519 | 90 | 1386 | 1491 | |||
| setupStore | 9 | 5 | 46 | 7 | 8 | 27 |
Benchmark value 1076 exceeds gate value 1070 for chrome browserify home mean load
Benchmark value 1069 exceeds gate value 1061 for chrome browserify home mean domContentLoaded
Benchmark value 1375 exceeds gate value 1365 for chrome browserify home p95 uiStartup
Benchmark value 1212 exceeds gate value 1190 for chrome browserify home p95 load
Benchmark value 1206 exceeds gate value 1180 for chrome browserify home p95 domContentLoaded
Benchmark value 1187 exceeds gate value 1180 for chrome browserify home p95 firstPaint
Benchmark value 21 exceeds gate value 18 for chrome browserify home p95 backgroundConnect
Benchmark value 950 exceeds gate value 940 for chrome browserify home p95 loadScripts
Benchmark value 57 exceeds gate value 32 for chrome webpack home mean setupStore
Benchmark value 312 exceeds gate value 65 for chrome webpack home p95 setupStore
Benchmark value 41 exceeds gate value 38 for firefox webpack home mean firstReactRender
Sum of mean exceeds: 45ms | Sum of p95 exceeds: 325ms
Sum of all benchmark exceeds: 370ms
This PR has been automatically marked as stale because it has not had recent activity in the last 90 days. It will be closed in 7 days. Thank you for your contributions.
This PR was closed because there has been no follow up activity in 7 days. Thank you for your contributions.