metamask-extension icon indicating copy to clipboard operation
metamask-extension copied to clipboard

feat: enhance trust signals integration by scanning spender addresses

Open AugmentedMode opened this issue 6 months ago • 3 comments

Description

Open in GitHub Codespaces

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

AugmentedMode avatar Jun 16 '25 15:06 AugmentedMode

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

github-actions[bot] avatar Jun 16 '25 15:06 github-actions[bot]

✨ Files requiring CODEOWNER review ✨

@MetaMask/confirmations (3 files, +11 -2)
  • 📁 ui/
    • 📁 pages/
      • 📁 confirmations/
        • 📁 components/
          • 📁 confirm/
            • 📁 info/
              • 📁 approve/
                • 📁 approve-details/
                  • 📄 approve-details.tsx +5 -1
              • 📁 set-approval-for-all-info/
                • 📁 revoke-set-approval-for-all-static-simulation/
                  • 📄 revoke-set-approval-for-all-static-simulation.tsx +1 -0
              • 📁 typed-sign/
                • 📄 typed-sign.tsx +5 -1

metamaskbot avatar Jun 16 '25 15:06 metamaskbot

Builds ready [07e60b9]
UI Startup Metrics (1237 ± 93 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyHomeuiStartup1237108618079312791374
load107590216149211181212
domContentLoaded106989716119311131205
domInteractive18149491633
firstPaint74684121242610971186
backgroundConnect74405820
firstReactRender21156162132
getState1363571829
initialActions001001
loadScripts823662135591865949
setupStore74142812
WebpackHomeuiStartup20071605249522121332381
load15711263204318316961865
domContentLoaded15661259203918216921856
domInteractive151164101245
firstPaint1656742560190274
backgroundConnect19134662234
firstReactRender101453507795319
getState1042131118
initialActions512822834
loadScripts15631258202918016891845
setupStore56632810517312
FirefoxBrowserifyHomeuiStartup1288113716647513261405
load1150101915097611891284
domContentLoaded1150101915097611881284
domInteractive983516626109144
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect19135562026
firstReactRender22202822326
getState7436489
initialActions001001
loadScripts1133100614817411711259
setupStore53122610
WebpackHomeuiStartup1530138817408916091706
load1328119715369014031508
domContentLoaded1328119615369014021508
domInteractive78361251385101
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect21163032226
firstReactRender41315544447
getState105397930
initialActions002111
loadScripts1309117615199013861491
setupStore95467827
Benchmark value 1237 exceeds gate value 1234 for chrome browserify home mean uiStartup
Benchmark value 1076 exceeds gate value 1070 for chrome browserify home mean load
Benchmark value 1069 exceeds gate value 1061 for chrome browserify home mean domContentLoaded
Benchmark value 1375 exceeds gate value 1365 for chrome browserify home p95 uiStartup
Benchmark value 1212 exceeds gate value 1190 for chrome browserify home p95 load
Benchmark value 1206 exceeds gate value 1180 for chrome browserify home p95 domContentLoaded
Benchmark value 1187 exceeds gate value 1180 for chrome browserify home p95 firstPaint
Benchmark value 21 exceeds gate value 18 for chrome browserify home p95 backgroundConnect
Benchmark value 950 exceeds gate value 940 for chrome browserify home p95 loadScripts
Benchmark value 57 exceeds gate value 32 for chrome webpack home mean setupStore
Benchmark value 312 exceeds gate value 65 for chrome webpack home p95 setupStore
Benchmark value 41 exceeds gate value 38 for firefox webpack home mean firstReactRender
Sum of mean exceeds: 45ms | Sum of p95 exceeds: 325ms
Sum of all benchmark exceeds: 370ms

metamaskbot avatar Jun 16 '25 16:06 metamaskbot

This PR has been automatically marked as stale because it has not had recent activity in the last 90 days. It will be closed in 7 days. Thank you for your contributions.

github-actions[bot] avatar Sep 18 '25 00:09 github-actions[bot]

This PR was closed because there has been no follow up activity in 7 days. Thank you for your contributions.

github-actions[bot] avatar Sep 25 '25 00:09 github-actions[bot]