metamask-extension icon indicating copy to clipboard operation
metamask-extension copied to clipboard

feat: remove remote send banner and add tooltip

Open caieu opened this issue 7 months ago • 7 comments

Description

  • Remove send allowance banner and introduce tooltip

Open in GitHub Codespaces

Related issues

Fixes: #33475, #33215

Manual testing steps

  1. Go to metamask-extension/ui/helpers/utils/remote-mode.ts and set the isRemoteModeSupported function to return true (for now, since only EOAs can be the delegator)
  2. Enable Remote Mode for an account and set a Daily Allowance
  3. With remote mode send allowance set
  4. Go to send page
  5. Should see new remote mode icon at top right corner
  • Note to override the vaultRemoteMode feature flag (which will implicitly default to disabled), the configuration steps are available here. Example.manifest-overrides.json:
{
  "_flags": {
    "remoteFeatureFlags": {
      "vaultRemoteMode": true
    }
  }
}

Screenshots/Recordings

Before

Screenshot 2025-06-04 at 17 13 58

After

Screenshot 2025-06-04 at 17 10 39 Screenshot 2025-06-04 at 17 10 44

Pre-merge author checklist

Pre-merge reviewer checklist

  • [X] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • [X] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

caieu avatar Jun 04 '25 22:06 caieu

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

github-actions[bot] avatar Jun 04 '25 22:06 github-actions[bot]

✨ Files requiring CODEOWNER review ✨

🔑 @MetaMask/accounts-engineers (2 files, +12 -17)
  • 📁 ui/
    • 📁 components/
      • 📁 multichain/
        • 📁 pages/
          • 📁 send/
            • 📁 components/
              • 📄 account-picker.tsx +1 -9
              • 📄 send.js +11 -8

@MetaMask/confirmations (2 files, +12 -17)
  • 📁 ui/
    • 📁 components/
      • 📁 multichain/
        • 📁 pages/
          • 📁 send/
            • 📁 components/
              • 📄 account-picker.tsx +1 -9
              • 📄 send.js +11 -8

🖥️ @MetaMask/wallet-ux (2 files, +12 -17)
  • 📁 ui/
    • 📁 components/
      • 📁 multichain/
        • 📁 pages/
          • 📁 send/
            • 📁 components/
              • 📄 account-picker.tsx +1 -9
              • 📄 send.js +11 -8

metamaskbot avatar Jun 04 '25 22:06 metamaskbot

Builds ready [f3cacda]
UI Startup Metrics (1238 ± 67 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyHomeuiStartup1238113014436712841367
load107096612335711031183
domContentLoaded106295212225710951171
domInteractive1814100101732
firstPaint71281120742910751162
backgroundConnect94336925
firstReactRender22164452332
getState1554182029
initialActions001000
loadScripts81170497956846905
setupStore85213812
WebpackHomeuiStartup20741593269625222432456
load16231260192319117671889
domContentLoaded16171256191618917601879
domInteractive15114381339
firstPaint1716133865211314
backgroundConnect23127792638
firstReactRender1274337997113346
getState1144971124
initialActions317134
loadScripts16141254191418817571868
setupStore3163176617291
FirefoxBrowserifyHomeuiStartup13211173173811013841561
load1171103214899712411370
domContentLoaded1171103114899712411369
domInteractive963529941108185
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect2613202302085
firstReactRender23195542329
getState9412913815
initialActions005101
loadScripts1148101514669212131329
setupStore64344611
WebpackHomeuiStartup14921323196610715701669
load1299115315539513691476
domContentLoaded1299115215529513681476
domInteractive75282302277118
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect19134652129
firstReactRender39275954246
getState11419220929
initialActions002111
loadScripts1281113715339413511460
setupStore75203813
Benchmark value 1238 exceeds gate value 1234 for chrome browserify home mean uiStartup
Benchmark value 1062 exceeds gate value 1061 for chrome browserify home mean domContentLoaded
Benchmark value 1368 exceeds gate value 1365 for chrome browserify home p95 uiStartup
Benchmark value 25 exceeds gate value 18 for chrome browserify home p95 backgroundConnect
Benchmark value 2457 exceeds gate value 2454 for chrome webpack home p95 uiStartup
Benchmark value 291 exceeds gate value 65 for chrome webpack home p95 setupStore
Benchmark value 26 exceeds gate value 25 for firefox browserify home mean backgroundConnect
Benchmark value 85 exceeds gate value 70 for firefox browserify home p95 backgroundConnect
Benchmark value 40 exceeds gate value 38 for firefox webpack home mean firstReactRender
Sum of mean exceeds: 8ms | Sum of p95 exceeds: 254ms
Sum of all benchmark exceeds: 262ms

Bundle size diffs [🚀 Bundle size reduced!]
  • background: -106.6 KiB (-2%)
  • ui: 17.38 KiB (0.24%)
  • common: -5.52 KiB (-0.07%)

metamaskbot avatar Jun 05 '25 17:06 metamaskbot

Builds ready [f1c462c]
UI Startup Metrics (1221 ± 71 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyHomeuiStartup1221111014087112651374
load106094512676910991215
domContentLoaded105394012636910901209
domInteractive17137971630
firstPaint71379127243110721180
backgroundConnect84335822
firstReactRender19153232025
getState1563482031
initialActions001001
loadScripts807702100369841958
setupStore75122811
WebpackHomeuiStartup22241700275320123362566
load17401290209116218241994
domContentLoaded17341286208216118151989
domInteractive16126491442
firstPaint1706535860181321
backgroundConnect2511280282549
firstReactRender13645366103116340
getState194337451429
initialActions316144
loadScripts17311284207116018141988
setupStore4173488221316
FirefoxBrowserifyHomeuiStartup1303115117519113311471
load1152103013537011801323
domContentLoaded1152103013527011801323
domInteractive933517126103142
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect20125392047
firstReactRender23195032227
getState12424229832
initialActions002001
loadScripts1134101813417011601310
setupStore74677611
WebpackHomeuiStartup15881372195312816791830
load13871192179712514891611
domContentLoaded13861191179712514891611
domInteractive85333364189144
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect21154252134
firstReactRender41285244448
getState84314814
initialActions102111
loadScripts13681175177712514681590
setupStore75242810
Benchmark value 1374 exceeds gate value 1365 for chrome browserify home p95 uiStartup
Benchmark value 1216 exceeds gate value 1190 for chrome browserify home p95 load
Benchmark value 1210 exceeds gate value 1180 for chrome browserify home p95 domContentLoaded
Benchmark value 22 exceeds gate value 18 for chrome browserify home p95 backgroundConnect
Benchmark value 958 exceeds gate value 940 for chrome browserify home p95 loadScripts
Benchmark value 2224 exceeds gate value 2192 for chrome webpack home mean uiStartup
Benchmark value 1741 exceeds gate value 1711 for chrome webpack home mean load
Benchmark value 1734 exceeds gate value 1704 for chrome webpack home mean domContentLoaded
Benchmark value 1731 exceeds gate value 1699 for chrome webpack home mean loadScripts
Benchmark value 41 exceeds gate value 32 for chrome webpack home mean setupStore
Benchmark value 2566 exceeds gate value 2454 for chrome webpack home p95 uiStartup
Benchmark value 1988 exceeds gate value 1970 for chrome webpack home p95 loadScripts
Benchmark value 316 exceeds gate value 65 for chrome webpack home p95 setupStore
Benchmark value 12 exceeds gate value 11 for firefox browserify home mean getState
Benchmark value 32 exceeds gate value 24 for firefox browserify home p95 getState
Benchmark value 1387 exceeds gate value 1380 for firefox webpack home mean load
Benchmark value 1387 exceeds gate value 1380 for firefox webpack home mean domContentLoaded
Benchmark value 42 exceeds gate value 38 for firefox webpack home mean firstReactRender
Benchmark value 1369 exceeds gate value 1360 for firefox webpack home mean loadScripts
Sum of mean exceeds: 161ms | Sum of p95 exceeds: 476ms
Sum of all benchmark exceeds: 637ms

Bundle size diffs [🚀 Bundle size reduced!]
  • background: -105.42 KiB (-1.98%)
  • ui: 25.68 KiB (0.36%)
  • common: -94.16 KiB (-1.13%)

metamaskbot avatar Jun 06 '25 16:06 metamaskbot

Builds ready [1301d02]
UI Startup Metrics (1223 ± 59 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyHomeuiStartup1223111514025912621305
load106096212696011061144
domContentLoaded105395012606010981137
domInteractive17139791631
firstPaint797150126840111031145
backgroundConnect83416824
firstReactRender21164042134
getState1463172028
initialActions001001
loadScripts807706100360856895
setupStore85203914
WebpackHomeuiStartup20531613248323322522427
load15891256202417617081839
domContentLoaded15831252201717517011830
domInteractive15116191339
firstPaint1636329549201266
backgroundConnect22105882437
firstReactRender1204436995130329
getState184410501229
initialActions315134
loadScripts15801250200717416991820
setupStore55634010319312
FirefoxBrowserifyHomeuiStartup1333118616409613941504
load1180104214518212321342
domContentLoaded1180104214518212321342
domInteractive983534636107136
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect20136992134
firstReactRender23203322429
getState11518525811
initialActions001001
loadScripts1162103114258112131326
setupStore74366612
WebpackHomeuiStartup15891339225115616631882
load13611158164511214571552
domContentLoaded13611157164411214571552
domInteractive77321562284125
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect2815248372341
firstReactRender42295144547
getState145257341030
initialActions102111
loadScripts13381142162710814331528
setupStore16426943870
Benchmark value 24 exceeds gate value 18 for chrome browserify home p95 backgroundConnect
Benchmark value 56 exceeds gate value 32 for chrome webpack home mean setupStore
Benchmark value 312 exceeds gate value 65 for chrome webpack home p95 setupStore
Benchmark value 12 exceeds gate value 11 for firefox browserify home mean getState
Benchmark value 28 exceeds gate value 26 for firefox webpack home mean backgroundConnect
Benchmark value 43 exceeds gate value 38 for firefox webpack home mean firstReactRender
Benchmark value 17 exceeds gate value 13 for firefox webpack home mean setupStore
Benchmark value 70 exceeds gate value 28 for firefox webpack home p95 setupStore
Sum of mean exceeds: 36ms | Sum of p95 exceeds: 295ms
Sum of all benchmark exceeds: 331ms

Bundle size diffs [🚀 Bundle size reduced!]
  • background: -105.42 KiB (-1.98%)
  • ui: 25.68 KiB (0.36%)
  • common: -94.16 KiB (-1.13%)

metamaskbot avatar Jun 06 '25 16:06 metamaskbot

Builds ready [9ea993b]
UI Startup Metrics (1260 ± 71 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyHomeuiStartup1260113414997113011389
load109096212447011371211
domContentLoaded108195812337011261206
domInteractive17144251728
firstPaint795133124641811111201
backgroundConnect104548927
firstReactRender21164242133
getState1464071929
initialActions001000
loadScripts83371597968878955
setupStore85323814
WebpackHomeuiStartup20541579259322422142432
load15901250201217017051870
domContentLoaded15851246200316916981862
domInteractive15115691339
firstPaint1566354467175277
backgroundConnect2310326312336
firstReactRender13544355109268337
getState154298381222
initialActions512902934
loadScripts15821245199216816951851
setupStore4873149416306
FirefoxBrowserifyHomeuiStartup1329117516168613781468
load1181103414658912491337
domContentLoaded1181103414658912491337
domInteractive1023434340112157
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect20136272031
firstReactRender23203022328
getState84394810
initialActions001001
loadScripts1164101714518912311318
setupStore64334610
WebpackHomeuiStartup15281354196712116081737
load13291152168711214081554
domContentLoaded13281152168711214071554
domInteractive77551602081126
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect21155152227
firstReactRender39285444246
getState84325918
initialActions002111
loadScripts13101136166811213831534
setupStore958510828
Benchmark value 1261 exceeds gate value 1234 for chrome browserify home mean uiStartup
Benchmark value 1091 exceeds gate value 1070 for chrome browserify home mean load
Benchmark value 1082 exceeds gate value 1061 for chrome browserify home mean domContentLoaded
Benchmark value 11 exceeds gate value 10 for chrome browserify home mean backgroundConnect
Benchmark value 833 exceeds gate value 830 for chrome browserify home mean loadScripts
Benchmark value 1390 exceeds gate value 1365 for chrome browserify home p95 uiStartup
Benchmark value 1212 exceeds gate value 1190 for chrome browserify home p95 load
Benchmark value 1206 exceeds gate value 1180 for chrome browserify home p95 domContentLoaded
Benchmark value 1201 exceeds gate value 1180 for chrome browserify home p95 firstPaint
Benchmark value 28 exceeds gate value 18 for chrome browserify home p95 backgroundConnect
Benchmark value 955 exceeds gate value 940 for chrome browserify home p95 loadScripts
Benchmark value 48 exceeds gate value 32 for chrome webpack home mean setupStore
Benchmark value 306 exceeds gate value 65 for chrome webpack home p95 setupStore
Benchmark value 40 exceeds gate value 38 for firefox webpack home mean firstReactRender
Sum of mean exceeds: 91ms | Sum of p95 exceeds: 360ms
Sum of all benchmark exceeds: 451ms

Bundle size diffs [🚀 Bundle size reduced!]
  • background: -106.89 KiB (-2.01%)
  • ui: 33.22 KiB (0.46%)
  • common: -100.11 KiB (-1.2%)

metamaskbot avatar Jun 06 '25 21:06 metamaskbot

Builds ready [748b493]
UI Startup Metrics (1218 ± 57 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyHomeuiStartup1218109914905712451308
load104991712685110791138
domContentLoaded104491112635110741133
domInteractive18149891732
firstPaint68084126842210551125
backgroundConnect6423379
firstReactRender21154552138
getState1364181930
initialActions001000
loadScripts795666100450825877
setupStore85162813
WebpackHomeuiStartup20561652257622522092382
load15841282203618717211932
domContentLoaded15791278202618717171927
domInteractive161197121344
firstPaint1536543757172264
backgroundConnect20134352431
firstReactRender1184737190108351
getState145329321221
initialActions923054135
loadScripts15761276201618517151917
setupStore4273178519311
FirefoxBrowserifyHomeuiStartup1487118817839915581663
load1317105416269313851475
domContentLoaded1316105416259313851475
domInteractive1063819025122144
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect24156282639
firstReactRender27216262836
getState1054251022
initialActions001001
loadScripts1295104116079113631455
setupStore74172713
WebpackHomeuiStartup15091328179810316011706
load13151147160210413951524
domContentLoaded13151147160210413941524
domInteractive81321932087121
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect21154452226
firstReactRender40304834246
getState84303911
initialActions002111
loadScripts12971132158410413791505
setupStore85293810
Benchmark value 9 exceeds gate value 7 for chrome webpack home mean initialActions
Benchmark value 43 exceeds gate value 32 for chrome webpack home mean setupStore
Benchmark value 311 exceeds gate value 65 for chrome webpack home p95 setupStore
Benchmark value 1487 exceeds gate value 1405 for firefox browserify home mean uiStartup
Benchmark value 1317 exceeds gate value 1245 for firefox browserify home mean load
Benchmark value 1317 exceeds gate value 1239 for firefox browserify home mean domContentLoaded
Benchmark value 28 exceeds gate value 25 for firefox browserify home mean firstReactRender
Benchmark value 1295 exceeds gate value 1230 for firefox browserify home mean loadScripts
Benchmark value 1663 exceeds gate value 1660 for firefox browserify home p95 uiStartup
Benchmark value 41 exceeds gate value 38 for firefox webpack home mean firstReactRender
Sum of mean exceeds: 316ms | Sum of p95 exceeds: 249ms
Sum of all benchmark exceeds: 565ms

Bundle size diffs [🚀 Bundle size reduced!]
  • background: -39.33 KiB (-0.74%)
  • ui: 16.68 KiB (0.23%)
  • common: -16.69 KiB (-0.2%)

metamaskbot avatar Jun 13 '25 15:06 metamaskbot

This PR has been automatically marked as stale because it has not had recent activity in the last 90 days. It will be closed in 7 days. Thank you for your contributions.

github-actions[bot] avatar Sep 12 '25 00:09 github-actions[bot]

This PR was closed because there has been no follow up activity in 7 days. Thank you for your contributions.

github-actions[bot] avatar Sep 20 '25 00:09 github-actions[bot]