metamask-extension icon indicating copy to clipboard operation
metamask-extension copied to clipboard

test: EIP-5792 methods on Multichain API

Open wenfix opened this issue 7 months ago • 17 comments

Description

We want to ensure there is support for calling EIP-5792 methods via the Multichain API. Adds E2E tests for it.

Open in GitHub Codespaces

Related issues

Fixes https://github.com/MetaMask/MetaMask-planning/issues/4784

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

wenfix avatar May 20 '25 14:05 wenfix

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

github-actions[bot] avatar May 20 '25 14:05 github-actions[bot]

@metamaskbot update-policies

wenfix avatar May 20 '25 14:05 wenfix

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License

View full report

socket-security[bot] avatar May 20 '25 14:05 socket-security[bot]

Policies updated.
👀 Please review the diff for suspicious new powers.

🧠 Learn how: https://lavamoat.github.io/guides/policy-diff/#what-to-look-for-when-reviewing-a-policy-diff

metamaskbot avatar May 20 '25 15:05 metamaskbot

✨ Files requiring CODEOWNER review ✨

🧩 @MetaMask/extension-devs (3 files, +3 -3)
  • 📁 lavamoat/
    • 📁 browserify/
      • 📁 beta/
        • 📄 policy.json +1 -1
      • 📁 flask/
        • 📄 policy.json +1 -1
      • 📁 main/
        • 📄 policy.json +1 -1

📜 @MetaMask/policy-reviewers (3 files, +3 -3)

[!TIP]
Follow the policy review process outlined in the LavaMoat Policy Review Process doc before expecting an approval from Policy Reviewers.

  • 📁 lavamoat/
    • 📁 browserify/
      • 📁 beta/
        • 📄 policy.json +1 -1
      • 📁 flask/
        • 📄 policy.json +1 -1
      • 📁 main/
        • 📄 policy.json +1 -1

🔗 @MetaMask/supply-chain (3 files, +3 -3)
  • 📁 lavamoat/
    • 📁 browserify/
      • 📁 beta/
        • 📄 policy.json +1 -1
      • 📁 flask/
        • 📄 policy.json +1 -1
      • 📁 main/
        • 📄 policy.json +1 -1

metamaskbot avatar May 20 '25 15:05 metamaskbot

@metamaskbot update-policies

wenfix avatar May 21 '25 15:05 wenfix

Policies updated.
👀 Please review the diff for suspicious new powers.

🧠 Learn how: https://lavamoat.github.io/guides/policy-diff/#what-to-look-for-when-reviewing-a-policy-diff

metamaskbot avatar May 21 '25 15:05 metamaskbot

Builds ready [329f6ba]
UI Startup Metrics (1187 ± 64 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyHomeuiStartup1187107015936412131278
load102189914366210461104
domContentLoaded101389214276310411096
domInteractive16133431624
firstPaint797138143737310381092
backgroundConnect94336825
firstReactRender20154762035
getState1455282030
initialActions001001
loadScripts775652117662801851
setupStore84334817
WebpackHomeuiStartup21621732275321823002508
load16681354195115417651896
domContentLoaded16601350193815217601883
domInteractive161258101346
firstPaint1556835051171265
backgroundConnect2710249262951
firstReactRender16942375116309332
getState195303411439
initialActions318145
loadScripts16561348192515117561871
setupStore3863047023279
FirefoxBrowserifyHomeuiStartup13121134177113413331623
load1160992156811812001437
domContentLoaded1160992156811811991437
domInteractive953926531102158
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect19135882040
firstReactRender23205042328
getState11420326813
initialActions005101
loadScripts1144979155411711851420
setupStore9433933611
WebpackHomeuiStartup15881372234416516641905
load13681186193414314411676
domContentLoaded13681186193414314411676
domInteractive80562562386124
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect241571102445
firstReactRender39265454248
getState145237321030
initialActions102111
loadScripts13481172191114314211657
setupStore959310822
Benchmark value 25 exceeds gate value 18 for chrome browserify home p95 backgroundConnect
Benchmark value 39 exceeds gate value 32 for chrome webpack home mean setupStore
Benchmark value 2508 exceeds gate value 2454 for chrome webpack home p95 uiStartup
Benchmark value 279 exceeds gate value 65 for chrome webpack home p95 setupStore
Benchmark value 10 exceeds gate value 9 for firefox browserify home mean setupStore
Benchmark value 39 exceeds gate value 38 for firefox webpack home mean firstReactRender
Benchmark value 1676 exceeds gate value 1660 for firefox webpack home p95 load
Benchmark value 1676 exceeds gate value 1660 for firefox webpack home p95 domContentLoaded
Benchmark value 1657 exceeds gate value 1630 for firefox webpack home p95 loadScripts
Sum of mean exceeds: 9ms | Sum of p95 exceeds: 334ms
Sum of all benchmark exceeds: 343ms

metamaskbot avatar May 21 '25 16:05 metamaskbot

@metamaskbot update-policies

wenfix avatar May 21 '25 16:05 wenfix

Policies updated.
👀 Please review the diff for suspicious new powers.

🧠 Learn how: https://lavamoat.github.io/guides/policy-diff/#what-to-look-for-when-reviewing-a-policy-diff

metamaskbot avatar May 21 '25 16:05 metamaskbot

Builds ready [93b1c7a]
UI Startup Metrics (1189 ± 59 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyHomeuiStartup1189107514095912291284
load102691911865510721107
domContentLoaded101991511825610641100
domInteractive16135551524
firstPaint77491118838710451105
backgroundConnect84356826
firstReactRender21155472139
getState1252771826
initialActions001001
loadScripts78268193055832859
setupStore84314813
WebpackHomeuiStartup22871712271619724132611
load17731351220616818892046
domContentLoaded17631347220016418842012
domInteractive16125481441
firstPaint1706868777181314
backgroundConnect3611351483761
firstReactRender18144365119313352
getState185276272036
initialActions318147
loadScripts17591345219816318812009
setupStore4073107028282
FirefoxBrowserifyHomeuiStartup13031132182013813371577
load1159987167513412161439
domContentLoaded1159986167513412161438
domInteractive933817725101156
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect19135872031
firstReactRender24205662333
getState84627810
initialActions001001
loadScripts1142972166013211791414
setupStore74718611
WebpackHomeuiStartup15761340210814216831803
load13701157189513514851607
domContentLoaded13701157189413514841607
domInteractive79421461985127
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect22155262335
firstReactRender38285154145
getState11524023928
initialActions102111
loadScripts13511141187913614651578
setupStore85284812
cc: @HowardBraham
Benchmark value 26 exceeds gate value 18 for chrome browserify home p95 backgroundConnect
Benchmark value 2288 exceeds gate value 2192 for chrome webpack home mean uiStartup
Benchmark value 1773 exceeds gate value 1711 for chrome webpack home mean load
Benchmark value 1763 exceeds gate value 1704 for chrome webpack home mean domContentLoaded
Benchmark value 1759 exceeds gate value 1699 for chrome webpack home mean loadScripts
Benchmark value 40 exceeds gate value 32 for chrome webpack home mean setupStore
Benchmark value 2611 exceeds gate value 2454 for chrome webpack home p95 uiStartup
Benchmark value 2046 exceeds gate value 2030 for chrome webpack home p95 load
Benchmark value 2012 exceeds gate value 2005 for chrome webpack home p95 domContentLoaded
Benchmark value 2009 exceeds gate value 1970 for chrome webpack home p95 loadScripts
Benchmark value 282 exceeds gate value 65 for chrome webpack home p95 setupStore
Sum of mean exceeds: 285ms | Sum of p95 exceeds: 444ms
Sum of all benchmark exceeds: 729ms

metamaskbot avatar May 21 '25 17:05 metamaskbot

@metamaskbot update-policies

wenfix avatar Jun 12 '25 15:06 wenfix

Policies updated.
👀 Please review the diff for suspicious new powers.

🧠 Learn how: https://lavamoat.github.io/guides/policy-diff/#what-to-look-for-when-reviewing-a-policy-diff

metamaskbot avatar Jun 12 '25 15:06 metamaskbot

@metamaskbot update-policies

wenfix avatar Jun 12 '25 16:06 wenfix

Policies updated.
👀 Please review the diff for suspicious new powers.

🧠 Learn how: https://lavamoat.github.io/guides/policy-diff/#what-to-look-for-when-reviewing-a-policy-diff

metamaskbot avatar Jun 12 '25 16:06 metamaskbot

Builds ready [e392d53]
UI Startup Metrics (1212 ± 63 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyHomeuiStartup1212109614516312401351
load105494812665810751185
domContentLoaded104794512645910701179
domInteractive17144251631
firstPaint809156121638610721123
backgroundConnect84345724
firstReactRender20174532024
getState1363571825
initialActions001001
loadScripts800702102258823922
setupStore85182813
WebpackHomeuiStartup20601527255223822202419
load16041174196419217511884
domContentLoaded15981169195419117451881
domInteractive161153111348
firstPaint1585930853204281
backgroundConnect20106072333
firstReactRender12846374101109351
getState135311301121
initialActions913044234
loadScripts15951168194219017421879
setupStore4373158717308
FirefoxBrowserifyHomeuiStartup1298118315537113311445
load1158103314187511931305
domContentLoaded1157103214177511921305
domInteractive963418525109133
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect18126261928
firstReactRender23205032328
getState749179
initialActions001001
loadScripts1141102013937311721291
setupStore64313610
WebpackHomeuiStartup15301369182611016101756
load13371181163111414161571
domContentLoaded13371181163111414161570
domInteractive79531881785100
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect21164552132
firstReactRender40344634345
getState85294915
initialActions002111
loadScripts13191162161411513991552
setupStore7523289
Benchmark value 809 exceeds gate value 800 for chrome browserify home mean firstPaint
Benchmark value 24 exceeds gate value 18 for chrome browserify home p95 backgroundConnect
Benchmark value 9 exceeds gate value 7 for chrome webpack home mean initialActions
Benchmark value 43 exceeds gate value 32 for chrome webpack home mean setupStore
Benchmark value 308 exceeds gate value 65 for chrome webpack home p95 setupStore
Benchmark value 41 exceeds gate value 38 for firefox webpack home mean firstReactRender
Sum of mean exceeds: 25ms | Sum of p95 exceeds: 249ms
Sum of all benchmark exceeds: 274ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: -2.41 KiB (-0.05%)
  • ui: 2 Bytes (0%)
  • common: 4.37 KiB (0.05%)

metamaskbot avatar Jun 12 '25 16:06 metamaskbot

Builds ready [182eb63]
UI Startup Metrics (1227 ± 68 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyHomeuiStartup1227111916196812601326
load106697013556110991168
domContentLoaded105995313426210951161
domInteractive17143441726
firstPaint83073121138310921148
backgroundConnect84285823
firstReactRender20164242031
getState1353271926
initialActions001001
loadScripts810711108462841922
setupStore85142813
WebpackHomeuiStartup20341592247621321742416
load15721262188916817011840
domContentLoaded15671257187816716971835
domInteractive151160101343
firstPaint1636364377189301
backgroundConnect20124862231
firstReactRender1254536598115335
getState144368361122
initialActions215134
loadScripts15641256186716616951826
setupStore63731811020311
FirefoxBrowserifyHomeuiStartup1306115016667713391448
load1161102615097611991298
domContentLoaded1161102615087611991298
domInteractive933519223102136
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect20134972041
firstReactRender23205642327
getState84375811
initialActions001001
loadScripts1143101214857511821281
setupStore74364611
WebpackHomeuiStartup15101345177010116121696
load13151167158610314161510
domContentLoaded13141167158510314161510
domInteractive83511612088129
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect21154242226
firstReactRender40295744245
getState105507929
initialActions001011
loadScripts12961150156810413981493
setupStore8548589
Benchmark value 831 exceeds gate value 800 for chrome browserify home mean firstPaint
Benchmark value 24 exceeds gate value 18 for chrome browserify home p95 backgroundConnect
Benchmark value 64 exceeds gate value 32 for chrome webpack home mean setupStore
Benchmark value 311 exceeds gate value 65 for chrome webpack home p95 setupStore
Benchmark value 41 exceeds gate value 38 for firefox webpack home mean firstReactRender
Sum of mean exceeds: 66ms | Sum of p95 exceeds: 252ms
Sum of all benchmark exceeds: 318ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: -2.4 KiB (-0.05%)
  • ui: 3.28 KiB (0.05%)
  • common: 5.04 KiB (0.06%)

metamaskbot avatar Jun 13 '25 09:06 metamaskbot