metamask-extension icon indicating copy to clipboard operation
metamask-extension copied to clipboard

feat: adds LocalStorageWithOffScreenStore, to be used in the future as a ba…

Open danjm opened this issue 1 year ago • 4 comments

…ckup of critical data in PersistedStateManager

Description

This PR adds a class that extends the BaseStore and, in a future PR, will be used with the PersistanceManager to backup vault data in a location separate from storage.local. The data store used in this case is the localStorage within the offscreen document. localStorage is not available to us in the service worker, which is why we are using the one available to us in the offscreen document

Open in GitHub Codespaces

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

danjm avatar Feb 11 '25 08:02 danjm

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

github-actions[bot] avatar Feb 11 '25 08:02 github-actions[bot]

Builds ready [eb231bd]
Page Load Metrics (1577 ± 43 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint1403175315768943
domContentLoaded1396171915558440
load1404175715778943
domInteractive23104442814
backgroundConnect106223168
firstReactRender1597522713
getState45812147
initialActions01000
loadScripts1007125511247034
setupStore776212110
uiStartup15522213183315675
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 136 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 100 Bytes (0.00%)

metamaskbot avatar Feb 11 '25 09:02 metamaskbot

Builds ready [a004bbf]
Page Load Metrics (1942 ± 211 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint30337961748716344
domContentLoaded162937321909435209
load163437861942440211
domInteractive27412638239
backgroundConnect972352110
firstReactRender1579342110
getState65917167
initialActions01000
loadScripts121229931447368177
setupStore85315136
uiStartup188540422189447214

metamaskbot avatar Mar 06 '25 16:03 metamaskbot

This PR has been automatically marked as stale because it has not had recent activity in the last 90 days. It will be closed in 7 days. Thank you for your contributions.

github-actions[bot] avatar Jun 16 '25 00:06 github-actions[bot]

This PR was closed because there has been no follow up activity in 7 days. Thank you for your contributions.

github-actions[bot] avatar Jun 23 '25 00:06 github-actions[bot]