MetaMask
[Bug]: ppom failing on RC v12.5 - Ethereum Mainnet
Describe the bug
PPOM failing on Ethereum Mainnet
Expected behavior
PPOM alert should work as expected
Screenshots/Recordings
https://github.com/user-attachments/assets/50cefb40-274d-4b5a-a426-e35901d9abf4
Steps to reproduce
- go to test Dapp
- Switch to Ethereum Mainnet in MetaMask
- Trigger any of the following:
Malicious ERC20 transfer (USDC)
Malicious ERC20 Approval (BUSD)
Malicious Set Approval for All
Malicious ERC 20 Approval with Odd Hex Data
- See error
Error validating JSON RPC using PPOM: Error: simulation: fallback: (code: -32000, message: , data: None)
https://github.com/user-attachments/assets/fa49c57f-ab98-4ff2-bb1a-0068d57899fe
Error messages or log output
No response
Detection stage
During release testing
Version
12.5.0
Build type
Other (please specify exactly where you obtained this build in "Additional Context" section)
Browser
Chrome, Firefox
Operating system
MacOS
Hardware wallet
No response
Additional context
No response
Severity
No response
On Linea network there is no console error, but the malicious transactions are not flagged:
Malicious ERC20 transfer (USDC) - not flagged;
Malicious ERC20 Approval (BUSD) - not flagged;
Malicious Set Approval for All - not flagged
Malicious ERC 20 Approval with Odd Hex Data - not flagged
https://github.com/user-attachments/assets/5bad5945-c904-4c8b-85bc-bca06b784ebe
@Unik0rnMaggie Linea may not be fully supported yet. I see the same behavior in prod and in RC 12.5.0:
Malicious ERC20 transfer (USDC) - not flagged;
Malicious ERC20 Approval (BUSD) - not flagged;
Malicious Set Approval for All - not flagged
Malicious ERC 20 Approval with Odd Hex Data - not flagged
Sign Permit -not flagged
@bschorchit
PPOM works for me in the latest build https://github.com/MetaMask/metamask-extension/pull/27411#issuecomment-2421046991
https://github.com/user-attachments/assets/4f3c1f37-d04b-4053-863b-273b73c8da14
@Unik0rnMaggie closing for now as we have confirmed it's no longer an issue. Please do re-open if you encounter it again.
