metamask-extension icon indicating copy to clipboard operation
metamask-extension copied to clipboard
verified publisher icon MetaMask

feat: add token verification source count and link to block explorer

Open bfullam opened this issue 1 year ago • 15 comments

Description

In a previous redesign, the information about the number of sources a token has been verified on and the link to that token on the relevant block explorer was removed from the swap page. This returns that information.

Open in GitHub Codespaces

Related issues

Fixes:

Manual testing steps

  1. Go to the swap page
  2. Select swap assets and amount
  3. See token verification info and block explorer link

Screenshots/Recordings

Before

Screenshot 2024-10-10 at 14 30 01

After

Screenshot 2024-10-10 at 14 30 21

Pre-merge author checklist

Pre-merge reviewer checklist

  • [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

bfullam avatar Oct 10 '24 12:10 bfullam

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

github-actions[bot] avatar Oct 10 '24 12:10 github-actions[bot]

I have read the CLA Document and I hereby sign the CLA

bfullam avatar Oct 10 '24 12:10 bfullam

Builds ready [5b410dc]
Page Load Metrics (2061 ± 261 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint29526661801560269
domContentLoaded158140282035536258
load159440532061543261
domInteractive26112512311
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: 159 Bytes (0.00%)
  • common: 1 Bytes (0.00%)

metamaskbot avatar Oct 10 '24 13:10 metamaskbot

Looks good. Could we update the copy?

Verified on x sources. You can check on [block explorer].

Can we specify which block explorer? I think we did on Extension before it disappeared. @coreyjanssen does this look ok?

vstern1 avatar Oct 10 '24 15:10 vstern1

Builds ready [8523b5b]
Page Load Metrics (1844 ± 109 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint154323341839229110
domContentLoaded153523231817224108
load154423331844226109
domInteractive2196502311
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: 159 Bytes (0.00%)
  • common: 1 Bytes (0.00%)

metamaskbot avatar Oct 10 '24 15:10 metamaskbot

I noticed something similar to @vstern1

image

In the designs we are using human readable names (Etherscan, PolygonScan, LineaScan, etc.) but in the current implementation we are using human readable URLs instead (etherscan.io, lineascan.build, etc.). Hopefully we have a way to get human readable block explorer names instead

Update: looks like there's not directly in the BlockExplorer component as we have defined. But we could consider including a new enum that maps the chain id to block explorer readable name

jclancy93 avatar Oct 10 '24 15:10 jclancy93

We probably shouldn't show the message for the native token, as this makes a highly trustable token (ETH) look unreliable. Screenshot 2024-10-10 at 10 50 54 AM

martahj avatar Oct 10 '24 15:10 martahj

Looks good to me. Approved by content design.

coreyjanssen avatar Oct 15 '24 15:10 coreyjanssen

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
66.7% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

sonarqubecloud[bot] avatar Oct 16 '24 12:10 sonarqubecloud[bot]

Builds ready [5b010b0]
Page Load Metrics (2038 ± 147 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint27328371935482231
domContentLoaded165327741972268129
load166928332038307147
domInteractive32249724521
backgroundConnect8319598642
firstReactRender462871135225
getState5389478441
initialActions00000
loadScripts120822561486242116
setupStore11188504622
uiStartup186333772352429206
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: 254 Bytes (0.00%)
  • common: 736 Bytes (0.01%)

metamaskbot avatar Oct 16 '24 16:10 metamaskbot

Builds ready [8d00e80]
Page Load Metrics (1808 ± 85 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint16482391180316881
domContentLoaded16272227176513967
load16472414180817685
domInteractive16204504019
backgroundConnect9187444522
firstReactRender472041044120
getState4111162613
initialActions01000
loadScripts11821680132712057
setupStore11145433517
uiStartup182531472084329158
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: 254 Bytes (0.00%)
  • common: 736 Bytes (0.01%)

metamaskbot avatar Oct 16 '24 17:10 metamaskbot

Builds ready [e1fdd68]
Page Load Metrics (1775 ± 60 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint22622601700365175
domContentLoaded16032084174111555
load16112160177512560
domInteractive198246199
backgroundConnect787332914
firstReactRender502921125527
getState45810116
initialActions01000
loadScripts1136152612789445
setupStore1195312713
uiStartup182127572009218104
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: 254 Bytes (0.00%)
  • common: 736 Bytes (0.01%)

metamaskbot avatar Oct 17 '24 07:10 metamaskbot

Ticket description said to display after fetching a quote, but now that you point it out, that does feel a little off.

@vstern1, did you want it to wait until after fetching for a specific reason?

bfullam avatar Oct 17 '24 14:10 bfullam

Builds ready [74ad24c]
Page Load Metrics (1643 ± 50 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint30219091589315151
domContentLoaded1504185416279445
load15131899164310450
domInteractive19190524321
backgroundConnect75018136
firstReactRender42209894421
getState470222512
initialActions00000
loadScripts1074139612037837
setupStore1093202110
uiStartup16572409184216278
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: 262 Bytes (0.00%)
  • common: 736 Bytes (0.01%)

metamaskbot avatar Oct 17 '24 15:10 metamaskbot

Builds ready [dd670b9]
Page Load Metrics (1939 ± 171 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint45826941859434209
domContentLoaded156426381852251120
load156830741939357171
domInteractive2788482010
backgroundConnect67948416780
firstReactRender482041034823
getState4122273014
initialActions00000
loadScripts114722181389237114
setupStore1196292512
uiStartup175632862182379182
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: 427 Bytes (0.01%)
  • common: 730 Bytes (0.01%)

metamaskbot avatar Oct 18 '24 08:10 metamaskbot

Absolutely right, good catch @infiniteflower! Fix made 👌

bfullam avatar Oct 22 '24 06:10 bfullam

Builds ready [8f8d708]
Page Load Metrics (1865 ± 109 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint156224721867229110
domContentLoaded15522315181318187
load156125151865227109
domInteractive25266595124
backgroundConnect9196505527
firstReactRender521991103818
getState4128313718
initialActions01000
loadScripts11321737134414469
setupStore108322199
uiStartup171030772139368177
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: 451 Bytes (0.01%)
  • common: 730 Bytes (0.01%)

metamaskbot avatar Oct 22 '24 07:10 metamaskbot

Builds ready [8eded5d]
Page Load Metrics (1833 ± 94 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint46223071771355170
domContentLoaded15402199180917885
load15502324183319594
domInteractive16277505526
backgroundConnect8128252713
firstReactRender482641024924
getState46612178
initialActions01000
loadScripts11081794134815976
setupStore1073352512
uiStartup169827042067229110
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: 697 Bytes (0.01%)
  • common: 639 Bytes (0.01%)

metamaskbot avatar Oct 23 '24 15:10 metamaskbot

Builds ready [7284081]
Page Load Metrics (2249 ± 120 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint30726931939709340
domContentLoaded178826032213237114
load181527002249249120
domInteractive30190693416
backgroundConnect10106382713
firstReactRender541361032010
getState46422199
initialActions00000
loadScripts128620321669213102
setupStore1184442612
uiStartup202030202490273131
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: 971 Bytes (0.01%)
  • common: 639 Bytes (0.01%)

metamaskbot avatar Oct 30 '24 11:10 metamaskbot