metamask-extension icon indicating copy to clipboard operation
metamask-extension copied to clipboard
verified publisher icon MetaMask

refactor: routes.component.js and creation of ToastMaster

Open HowardBraham opened this issue 1 year ago • 13 comments

Description

This PR is part of the larger effort to add React.lazy to routes.

I would be very surprised if I did not break functionality somewhere, as this was a large and tough refactor. It needs some good QA, and Harika has been doing some testing that has passed.

Summary of what I did:

  • Pulled all Toast-related logic out of routes.component.js and into the new ToastMaster
  • Pulled everything else I could pull out into routes-helpers.js
  • Moved things out of the general selectors.js and actions.ts into toast-master-selectors.ts
  • Simplification of some Pointless Thunks™

For later PRs:

  • Convert routes.component.js to TypeScript
  • Convert routes.component.js to Hooks
  • Convert routes.component.js to react-router v6
  • Eliminate routes.container.js

Open in GitHub Codespaces

Related issues

Progresses: MetaMask/MetaMask-planning#2898

Manual testing steps

Test all the Routes and all the Toasts

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

HowardBraham avatar Oct 09 '24 17:10 HowardBraham

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

github-actions[bot] avatar Oct 09 '24 17:10 github-actions[bot]

Builds ready [0eb601f]
Page Load Metrics (1892 ± 86 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint38321621787347166
domContentLoaded15282425186817684
load15362436189217886
domInteractive14107402110
Bundle size diffs [🚀 Bundle size reduced!]
  • background: 0 Bytes (0.00%)
  • ui: 3.7 KiB (0.05%)
  • common: -2.32 KiB (-0.03%)

metamaskbot avatar Oct 09 '24 18:10 metamaskbot

Builds ready [789eb79]
Page Load Metrics (1815 ± 96 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint42625951754377181
domContentLoaded15892362177318488
load16082450181519996
domInteractive267443168
Bundle size diffs [🚀 Bundle size reduced!]
  • background: 0 Bytes (0.00%)
  • ui: 3.66 KiB (0.05%)
  • common: -2.32 KiB (-0.03%)

metamaskbot avatar Oct 10 '24 17:10 metamaskbot

Builds ready [553bbe2]
Page Load Metrics (1858 ± 70 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint30021461774359172
domContentLoaded1601199118029646
load16252327185814770
domInteractive1884522010
Bundle size diffs [🚀 Bundle size reduced!]
  • background: 0 Bytes (0.00%)
  • ui: 3.66 KiB (0.05%)
  • common: -2.31 KiB (-0.03%)

metamaskbot avatar Oct 12 '24 07:10 metamaskbot

Builds ready [7a54b36]
Page Load Metrics (2010 ± 314 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint48046071876703338
domContentLoaded156444361978650312
load161444972010653314
domInteractive26143502914
Bundle size diffs [🚀 Bundle size reduced!]
  • background: 0 Bytes (0.00%)
  • ui: 6.1 KiB (0.08%)
  • common: -2.68 KiB (-0.04%)

metamaskbot avatar Oct 14 '24 10:10 metamaskbot

Builds ready [2aad6bf]
Page Load Metrics (1779 ± 41 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint1655197617879144
domContentLoaded1644195317567838
load1656196117798541
domInteractive247845189
Bundle size diffs [🚀 Bundle size reduced!]
  • background: 0 Bytes (0.00%)
  • ui: 5.36 KiB (0.07%)
  • common: -2.68 KiB (-0.04%)

metamaskbot avatar Oct 15 '24 07:10 metamaskbot

Builds ready [21a771a]
Page Load Metrics (2057 ± 180 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint37531581957483232
domContentLoaded168425961966226109
load169334652057376180
domInteractive1887512211
backgroundConnect98638918388
firstReactRender472881286330
getState489302613
initialActions01000
loadScripts12231853147118287
setupStore1195342914
uiStartup190336872378403194
Bundle size diffs [🚀 Bundle size reduced!]
  • background: 0 Bytes (0.00%)
  • ui: 5.36 KiB (0.07%)
  • common: -2.67 KiB (-0.04%)

metamaskbot avatar Oct 15 '24 18:10 metamaskbot

Builds ready [2dd77de]
Page Load Metrics (1729 ± 96 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint15092286172519694
domContentLoaded14832008167013866
load14952282172920096
domInteractive17342576732
backgroundConnect9252597134
firstReactRender432071095325
getState4106192914
initialActions01000
loadScripts10781474125210349
setupStore11101493417
uiStartup166131872044394189
Bundle size diffs [🚀 Bundle size reduced!]
  • background: 0 Bytes (0.00%)
  • ui: 5.49 KiB (0.07%)
  • common: -2.67 KiB (-0.04%)

metamaskbot avatar Oct 16 '24 09:10 metamaskbot

Builds ready [640f88a]
Page Load Metrics (2349 ± 335 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint28538872036948455
domContentLoaded163938762302700336
load169138962349698335
domInteractive19165724622
backgroundConnect7165493617
firstReactRender493041156732
getState679272110
initialActions01000
loadScripts120230121744582279
setupStore1176342211
uiStartup184042742646802385
Bundle size diffs [🚀 Bundle size reduced!]
  • background: 0 Bytes (0.00%)
  • ui: 5.54 KiB (0.07%)
  • common: -2.67 KiB (-0.04%)

metamaskbot avatar Oct 16 '24 17:10 metamaskbot

Builds ready [e5bbb59]
Page Load Metrics (1926 ± 171 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint155030371919357171
domContentLoaded153830221890349168
load155430351926356171
domInteractive18132452813
backgroundConnect11138373215
firstReactRender46198873517
getState45812147
initialActions01000
loadScripts111826151441337162
setupStore1172322311
uiStartup175332412145394189
Bundle size diffs [🚀 Bundle size reduced!]
  • background: 0 Bytes (0.00%)
  • ui: 5.48 KiB (0.07%)
  • common: -2.67 KiB (-0.04%)

metamaskbot avatar Oct 16 '24 19:10 metamaskbot

Quality Gate Failed Quality Gate failed

Failed conditions
72.5% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

sonarqubecloud[bot] avatar Oct 17 '24 00:10 sonarqubecloud[bot]

Builds ready [65bbd8c]
Page Load Metrics (1802 ± 84 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint15562177180517685
domContentLoaded15072133177617283
load15602179180217584
domInteractive16212565024
backgroundConnect97724209
firstReactRender433001126230
getState46914199
initialActions01000
loadScripts10231592131114067
setupStore1195272613
uiStartup170425702037247119
Bundle size diffs [🚀 Bundle size reduced!]
  • background: 0 Bytes (0.00%)
  • ui: 5.48 KiB (0.07%)
  • common: -2.67 KiB (-0.03%)

metamaskbot avatar Oct 17 '24 00:10 metamaskbot

Builds ready [bfd7b86]
Page Load Metrics (1828 ± 76 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint15182202183014871
domContentLoaded14732023177611656
load14812215182815976
domInteractive16102512311
backgroundConnect9258556631
firstReactRender512851216230
getState4118283014
initialActions00000
loadScripts1071152713259445
setupStore10122393517
uiStartup166530632147329158
Bundle size diffs [🚀 Bundle size reduced!]
  • background: 0 Bytes (0.00%)
  • ui: 5.48 KiB (0.07%)
  • common: -2.67 KiB (-0.03%)

metamaskbot avatar Oct 17 '24 20:10 metamaskbot

Builds ready [a66fe4f]
Page Load Metrics (1818 ± 98 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint31824661738377181
domContentLoaded15682207177014067
load15822519181820498
domInteractive1595512211
backgroundConnect8259466330
firstReactRender47208914723
getState5171304722
initialActions00000
loadScripts11161660130512158
setupStore11136433416
uiStartup177133072079361173
Bundle size diffs [🚀 Bundle size reduced!]
  • background: 0 Bytes (0.00%)
  • ui: 5.48 KiB (0.07%)
  • common: -2.67 KiB (-0.03%)

metamaskbot avatar Oct 22 '24 06:10 metamaskbot

Builds ready [e82745e]
Page Load Metrics (1794 ± 74 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint35423861659461221
domContentLoaded16512143176110651
load16602385179415574
domInteractive179741188
backgroundConnect9205345024
firstReactRender46211984220
getState494212713
initialActions00000
loadScripts1188154612897837
setupStore10100352814
uiStartup180730412056302145

metamaskbot avatar Oct 22 '24 18:10 metamaskbot