metamask-extension fix: Allow users to remove linea from networks list

Description

Users should be allowed to remove Linea from networks list. When Linea is removed from default network list, it should appear within the Popular Networks section (be suggested to them). So, we need to also add it to FEATURED_RPCS

Related issues

Fixes: https://consensyssoftware.atlassian.net/browse/MMASSETS-387

Manual testing steps

Go to networks list, ensure that you can remove linea, even though it is a default network.

Screenshots/Recordings

Pre-merge author checklist

[x] I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
[x] I've completed the PR template to the best of my ability
[x] I’ve included tests if applicable
[x] I’ve documented my code using JSDoc format if applicable
[x] I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

[ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
[ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Sep 30 '24 21:09 gambinish

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

Sep 30 '24 21:09 github-actions[bot]

Builds ready [8c9bf20]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6
- common: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1848 ± 127 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	280	2266	1659	517	248
		domContentLoaded	1458	2256	1813	260	125
		load	1466	2266	1848	264	127
		domInteractive	24	82	41	19	9

Bundle size diffs

background: 0 Bytes (0.00%)
ui: -39 Bytes (-0.00%)
common: 0 Bytes (0.00%)

Sep 30 '24 21:09 metamaskbot

Let's make sure if linea is deleted, it appears as a popular network so people have the ability to re-add it. The list of popular networks should be defined by FEATURED_RPCS so you can start with trying to add it there and see what breaks.

Oct 02 '24 16:10 bergeron

Builds ready [5755063]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6
- common: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1937 ± 138 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1577	2635	1927	288	138
		domContentLoaded	1561	2491	1885	251	120
		load	1570	2641	1937	288	138
		domInteractive	19	75	42	18	9
		backgroundConnect	9	208	47	50	24
		firstReactRender	72	389	120	64	31
		getState	5	116	23	30	14
		initialActions	0	1	0	0	0
		loadScripts	1139	1803	1402	160	77
		setupStore	12	110	29	26	12
		uiStartup	1742	3142	2198	405	195

Oct 15 '24 16:10 metamaskbot

Let's make sure if linea is deleted, it appears as a popular network so people have the ability to re-add it. The list of popular networks should be defined by FEATURED_RPCS so you can start with trying to add it there and see what breaks.

https://github.com/user-attachments/assets/742db780-91e0-46ab-9f8d-78a21f22c766

As far as I can tell, this is working as expected since Linea is already added as an entry of FEATURED_RPCS

Am I missing something here?

Oct 15 '24 19:10 gambinish

Builds ready [3e25304]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6
- common: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1919 ± 127 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1573	2688	1917	253	121
		domContentLoaded	1563	2679	1875	236	113
		load	1571	2690	1919	265	127
		domInteractive	18	121	47	24	12
		backgroundConnect	8	213	44	57	28
		firstReactRender	47	214	121	57	27
		getState	4	110	23	34	17
		initialActions	0	1	0	0	0
		loadScripts	1140	2190	1405	215	103
		setupStore	10	128	53	37	18
		uiStartup	1815	3208	2257	403	193

Bundle size diffs

background: 0 Bytes (0.00%)
ui: -39 Bytes (-0.00%)
common: 0 Bytes (0.00%)

Oct 15 '24 19:10 metamaskbot

Builds ready [af20158]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6
- common: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1884 ± 103 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1693	2393	1893	203	98
		domContentLoaded	1662	2291	1848	195	94
		load	1670	2394	1884	214	103
		domInteractive	17	246	63	58	28
		backgroundConnect	11	159	39	36	17
		firstReactRender	46	198	92	38	18
		getState	5	87	25	29	14
		initialActions	0	1	0	0	0
		loadScripts	1222	1837	1397	176	84
		setupStore	11	88	27	25	12
		uiStartup	1868	3063	2111	285	137

Bundle size diffs

background: 0 Bytes (0.00%)
ui: -39 Bytes (-0.00%)
common: 0 Bytes (0.00%)

Oct 16 '24 18:10 metamaskbot

My bad. I had the changes to FEATURED_RPCS on my local 😑

Should be updated now.

Oct 16 '24 19:10 gambinish

Builds ready [92e1d89]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6
- common: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (2371 ± 418 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	438	5609	2296	1033	496
		domContentLoaded	1676	4964	2323	833	400
		load	1694	5222	2371	871	418
		domInteractive	17	154	72	42	20
		backgroundConnect	13	323	53	67	32
		firstReactRender	49	563	146	117	56
		getState	6	312	37	66	32
		initialActions	0	1	0	0	0
		loadScripts	1233	3831	1765	688	331
		setupStore	12	105	43	31	15
		uiStartup	1862	6539	2741	1125	540

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 0 Bytes (0.00%)
ui: -39 Bytes (-0.00%)
common: 211 Bytes (0.00%)

Oct 16 '24 20:10 metamaskbot

Builds ready [c21904c]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6
- common: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1978 ± 164 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1715	2793	1975	327	157
		domContentLoaded	1657	2580	1931	289	139
		load	1713	2930	1978	342	164
		domInteractive	19	84	50	18	9
		backgroundConnect	9	379	47	80	39
		firstReactRender	47	215	108	53	25
		getState	5	112	29	33	16
		initialActions	0	1	0	0	0
		loadScripts	1233	1973	1466	221	106
		setupStore	10	198	43	45	22
		uiStartup	1893	4239	2291	588	283

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 0 Bytes (0.00%)
ui: -39 Bytes (-0.00%)
common: 251 Bytes (0.00%)

Oct 16 '24 22:10 metamaskbot

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

Oct 16 '24 23:10 sonarqubecloud[bot]

Builds ready [cc8db41]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6
- common: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1947 ± 147 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1710	2761	1923	278	133
		domContentLoaded	1676	2577	1869	224	107
		load	1714	2859	1947	306	147
		domInteractive	27	85	46	17	8
		backgroundConnect	11	425	75	100	48
		firstReactRender	47	337	124	83	40
		getState	5	192	29	45	22
		initialActions	0	1	0	0	0
		loadScripts	1241	1879	1384	156	75
		setupStore	11	221	52	57	27
		uiStartup	1885	4236	2296	607	292

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 0 Bytes (0.00%)
ui: -39 Bytes (-0.00%)
common: 251 Bytes (0.00%)

Oct 17 '24 01:10 metamaskbot

Builds ready [715d648]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6
- common: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1959 ± 154 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1650	2675	1942	256	123
		domContentLoaded	1626	2207	1874	173	83
		load	1636	3056	1959	322	154
		domInteractive	15	229	74	59	28
		backgroundConnect	8	792	80	173	83
		firstReactRender	46	218	110	46	22
		getState	4	134	22	35	17
		initialActions	0	0	0	0	0
		loadScripts	1193	1688	1404	149	72
		setupStore	11	109	41	32	16
		uiStartup	1837	3299	2239	433	208

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 0 Bytes (0.00%)
ui: -39 Bytes (-0.00%)
common: 251 Bytes (0.00%)

Oct 17 '24 21:10 metamaskbot

Builds ready [b356c50]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6
- common: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1976 ± 172 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	600	3033	1839	535	257
		domContentLoaded	1622	3006	1943	337	162
		load	1632	3036	1976	357	172
		domInteractive	26	119	53	25	12
		backgroundConnect	7	242	37	51	25
		firstReactRender	45	117	89	23	11
		getState	4	95	19	25	12
		initialActions	0	1	0	0	0
		loadScripts	1169	2015	1441	249	120
		setupStore	11	62	27	20	10
		uiStartup	1794	3255	2190	398	191

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 0 Bytes (0.00%)
ui: -39 Bytes (-0.00%)
common: 251 Bytes (0.00%)

Oct 21 '24 21:10 metamaskbot

Builds ready [b356c50]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6
- common: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1976 ± 172 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	600	3033	1839	535	257
		domContentLoaded	1622	3006	1943	337	162
		load	1632	3036	1976	357	172
		domInteractive	26	119	53	25	12
		backgroundConnect	7	242	37	51	25
		firstReactRender	45	117	89	23	11
		getState	4	95	19	25	12
		initialActions	0	1	0	0	0
		loadScripts	1169	2015	1441	249	120
		setupStore	11	62	27	20	10
		uiStartup	1794	3255	2190	398	191

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 0 Bytes (0.00%)
ui: -39 Bytes (-0.00%)
common: 251 Bytes (0.00%)

Oct 21 '24 21:10 metamaskbot

Builds ready [bf5f6d2]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6
- common: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (2279 ± 89 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	296	2571	2078	603	289
		domContentLoaded	1943	2509	2242	171	82
		load	1949	2559	2279	186	89
		domInteractive	31	93	55	21	10
		backgroundConnect	9	123	38	31	15
		firstReactRender	73	291	129	55	26
		getState	6	74	31	23	11
		initialActions	0	1	0	0	0
		loadScripts	1400	1845	1654	140	67
		setupStore	12	96	37	23	11
		uiStartup	2238	3163	2587	239	115

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 0 Bytes (0.00%)
ui: -39 Bytes (-0.00%)
common: 251 Bytes (0.00%)

Oct 22 '24 17:10 metamaskbot