metamask-extension icon indicating copy to clipboard operation
metamask-extension copied to clipboard

chore: MMI Fixes passing the state to route using history.push

Open zone-live opened this issue 1 year ago • 2 comments

Description

Passing the state to route using history.push in order to get these values in the final view. They were not arriving before.

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

zone-live avatar Aug 28 '24 15:08 zone-live

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

github-actions[bot] avatar Aug 28 '24 15:08 github-actions[bot]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 70.08%. Comparing base (c3069ee) to head (4e870c4). Report is 12 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #26722      +/-   ##
===========================================
+ Coverage    70.05%   70.08%   +0.03%     
===========================================
  Files         1414     1414              
  Lines        49317    49330      +13     
  Branches     13780    13781       +1     
===========================================
+ Hits         34546    34570      +24     
+ Misses       14771    14760      -11     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Aug 29 '24 09:08 codecov[bot]

Builds ready [4e870c4]
Page Load Metrics (102 ± 23 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint703411346129
domContentLoaded54252994823
load542531024823
domInteractive12129352512
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

metamaskbot avatar Aug 29 '24 09:08 metamaskbot