metamask-extension icon indicating copy to clipboard operation
metamask-extension copied to clipboard

chore(cherry-pick): cherry picks Bitcoin related fixes/changes for V12.2.0

Open ccharly opened this issue 1 year ago • 4 comments

Description

Cherry picks Bitcoin related fixes/changes.

Open in GitHub Codespaces

Related issues

Fixes: https://github.com/MetaMask/accounts-planning/issues/535

Screenshots/Recordings

Before

N/A

After

N/A

Pre-merge author checklist

Pre-merge reviewer checklist

  • [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

ccharly avatar Jul 25 '24 09:07 ccharly

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

github-actions[bot] avatar Jul 25 '24 09:07 github-actions[bot]

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@metamask/[email protected] network 0 1.02 MB metamaskbot

🚮 Removed packages: npm/@metamask/[email protected])

View full report↗︎

socket-security[bot] avatar Jul 25 '24 09:07 socket-security[bot]

🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎

To accept the risk, merge this PR and you will not be notified again.

Alert Package NoteSourceCI
Network access npm/@metamask/[email protected] 🚫
Network access npm/@metamask/[email protected] 🚫

View full report↗︎

Next steps

What is network access?

This module accesses the network.

Packages should remove all network access that is functionally unnecessary. Consumers should audit network access to ensure legitimate use.

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/[email protected] or ignore all packages with @SocketSecurity ignore-all

socket-security[bot] avatar Jul 25 '24 09:07 socket-security[bot]

Screenshots

Here are some screenshots to make sure the fixes are working as expect on top of the v12.2.0:

Bitcoin balance showing properly:

Screenshot 2024-08-27 at 09 56 09


Pre-installed Bitcoin Snap not showing:

Screenshot 2024-08-27 at 09 56 18


Account connection screen filters Bitcoin accounts:

Screenshot 2024-08-27 at 10 00 32 Screenshot 2024-08-27 at 10 00 49 Screenshot 2024-08-27 at 10 01 06


Cannot send to Bitcoin accounts while sending from an Ethereum account:

Screenshot 2024-08-27 at 10 01 26


Here's the link when you click on the "survey form" from the experimental tab:

  • https://www.getfeedback.com/r/yG6FbiW5/

Bitcoin Snap version is 0.3.0:

  • https://github.com/MetaMask/metamask-extension/blob/5ededb38f94075848fa2eeac5641410feb8f4eba/package.json#L297

ccharly avatar Aug 27 '24 08:08 ccharly

All those commits have been merged to the v12.2.0 already (using multiple PRs).

ccharly avatar Sep 03 '24 19:09 ccharly