metamask-extension icon indicating copy to clipboard operation
metamask-extension copied to clipboard

fix: asset picker bug

Open salimtb opened this issue 8 months ago • 2 comments

Description

the goal of this PR is to fix some v12.1 bugs related to balance display and asset picker modal:

  • The symbols no longer show for each list item
  • Blocked token symbols (e.g., BNB on Ethereum Mainnet) are no longer greyed out in the UI despite still being inert
  • Token names are not truncated
  • Fiat and crypto balance are inverted on the wallet view
  • Token symbol is USD instead of ETH on the asset picker modal

Open in GitHub Codespaces

Related issues

Fixes: #25575

Manual testing steps

  1. Go to the wallet view and check crypto and fiat value for native token
  2. Select Ethereum Mainnet
  3. Go to Send page
  4. Click on destination asset picker
  5. Observe that symbols are not present and names are not truncated
  6. Search for "CHZ"
  7. Observe that it is not styled as a disabled button

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

salimtb avatar Jun 30 '24 12:06 salimtb