metamask-extension icon indicating copy to clipboard operation
metamask-extension copied to clipboard

fix: add method call validator

Open shanejonas opened this issue 1 year ago • 3 comments

Description

I'm getting an error using this library, looks like its erroring on a require to a diff module

image

Open in GitHub Codespaces

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

shanejonas avatar Jun 28 '24 20:06 shanejonas

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

github-actions[bot] avatar Jun 28 '24 20:06 github-actions[bot]

New dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@open-rpc/[email protected] filesystem Transitive: network +13 428 kB belfordz

View full report↗︎

socket-security[bot] avatar Jun 28 '24 20:06 socket-security[bot]

Oh nice. do we need to do our own params validation still if we use this?

jiexi avatar Jun 28 '24 22:06 jiexi

shmeval

jiexi avatar Jul 02 '24 16:07 jiexi