metamask-extension icon indicating copy to clipboard operation
metamask-extension copied to clipboard

refactor: :recycle: fix the event names used to track notifications

Open matteoscurati opened this issue 1 year ago • 2 comments

Description

This PR modifies the names of some tracked events to monitor the use of notifications, ensuring they adhere to the conventions used.

Open in GitHub Codespaces

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • [x] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • [x] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

matteoscurati avatar Jun 26 '24 10:06 matteoscurati

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

github-actions[bot] avatar Jun 26 '24 10:06 github-actions[bot]

Builds ready [d7c77cd]
Page Load Metrics (227 ± 226 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint602971064924
domContentLoaded9105292311
load411763227471226
domInteractive9105292311
Bundle size diffs [🚀 Bundle size reduced!]
  • background: 102 Bytes (0.00%)
  • ui: -771 Bytes (-0.01%)
  • common: -976 Bytes (-0.01%)

metamaskbot avatar Jul 26 '24 10:07 metamaskbot

Codecov Report

Attention: Patch coverage is 33.33333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 69.95%. Comparing base (b27dd2b) to head (d7c77cd).

Files Patch % Lines
...ation-detail-button/notification-detail-button.tsx 0.00% 1 Missing :warning:
ui/pages/notifications/notifications-list-item.tsx 0.00% 1 Missing :warning:
Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #25521      +/-   ##
===========================================
+ Coverage    69.94%   69.95%   +0.01%     
===========================================
  Files         1409     1409              
  Lines        49794    49779      -15     
  Branches     13773    13767       -6     
===========================================
- Hits         34826    34818       -8     
+ Misses       14968    14961       -7     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Jul 26 '24 10:07 codecov[bot]

Builds ready [5a7ea8e]
Page Load Metrics (60 ± 7 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint6111487136
domContentLoaded85324126
load409760147
domInteractive85324126
Bundle size diffs [🚀 Bundle size reduced!]
  • background: 102 Bytes (0.00%)
  • ui: -771 Bytes (-0.01%)
  • common: -976 Bytes (-0.01%)

metamaskbot avatar Jul 26 '24 11:07 metamaskbot