metamask-extension icon indicating copy to clipboard operation
metamask-extension copied to clipboard

feat: Add new content on the STX status page

Open dan437 opened this issue 1 year ago • 1 comments

Description

On the STX status page you will now see this text for a pending dapp transaction: You may close this window anytime.

TODOs:

  • Add tests

Related issues

Fixes:

Manual testing steps

  1. Go to a dapp and submit a transaction with STX enabled
  2. On the STX status page you will see this text for a pending dapp transaction: You may close this window anytime.
  3. The text will be replaced with the Close extension button when the transaction is not pending anymore

Screenshots/Recordings

Pre-merge author checklist

  • [ ] I’ve followed MetaMask Coding Standards.
  • [ ] I've completed the PR template to the best of my ability
  • [ ] I’ve included tests if applicable
  • [ ] I’ve documented my code using JSDoc format if applicable
  • [ ] I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

  • [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

dan437 avatar May 24 '24 14:05 dan437

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

github-actions[bot] avatar May 24 '24 14:05 github-actions[bot]

Builds ready [d2aa0b6]
Page Load Metrics (169 ± 203 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint6412586147
domContentLoaded8391173
load532013169423203
domInteractive8391173
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: 305 Bytes (0.00%)
  • common: 65 Bytes (0.00%)

metamaskbot avatar May 27 '24 12:05 metamaskbot

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 65.78%. Comparing base (82fe51c) to head (ca36630).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #24772      +/-   ##
===========================================
+ Coverage    65.77%   65.78%   +0.01%     
===========================================
  Files         1366     1366              
  Lines        54238    54244       +6     
  Branches     14108    14109       +1     
===========================================
+ Hits         35670    35680      +10     
+ Misses       18568    18564       -4     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar May 28 '24 14:05 codecov[bot]

Builds ready [ad7d112]
Page Load Metrics (679 ± 509 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint73150922210
domContentLoaded9201131
load6031016791061509
domInteractive9201131
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: 278 Bytes (0.00%)
  • common: 65 Bytes (0.00%)

metamaskbot avatar May 28 '24 15:05 metamaskbot

Builds ready [ca36630]
Page Load Metrics (544 ± 455 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint67183993216
domContentLoaded9251352
load552646544947455
domInteractive9251352
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: 278 Bytes (0.00%)
  • common: 65 Bytes (0.00%)

metamaskbot avatar May 28 '24 17:05 metamaskbot

Missing release label release-11.16.1 on PR. Adding release label release-11.16.1 on PR and removing other release labels(release-11.18.0), as PR was cherry-picked in branch 11.16.1.

metamaskbot avatar May 29 '24 00:05 metamaskbot