MetaMask
feat: Implement the "Manage in settings" variation for the STX Opt In modal
Description
Slight variation for the STX Opt In modal: Add a link to "Manage in settings"
Related issues
Fixes:
Manual testing steps
- Install the extension from scratch
- After the initial setup you will see the STX Opt In modal
- It will show the "Manage in settings" link. After clicking on it we opt out a user from Smart Transactions, but they will be redirected to Advanced Settings, where they can turn it on if they want or just close the Settings
Screenshots/Recordings
STX Opt In modal:
Advanced Settings with STX:
Pre-merge author checklist
- [ ] I’ve followed MetaMask Coding Standards.
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using JSDoc format if applicable
- [ ] I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
Pre-merge reviewer checklist
- [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
Builds ready [1113c78]
- builds: chrome, firefox
- builds (beta): chrome
- builds (flask): chrome, firefox
- builds (MMI): chrome, firefox
- builds (test): chrome, firefox
- builds (test-flask): chrome, firefox
- build viz: Build System
- mv3: Background Module Init Stats
- mv3: UI Init Stats
- mv3: Module Load Stats
- mv3: Bundle Size Stats
- mv2: E2e Actions Stats
- code coverage: Report
- storybook: Storybook
- typescript migration: Dashboard
- all artifacts
Page Load Metrics (1403 ± 581 ms)
| Platform | Page | Metric | Min (ms) | Max (ms) | Average (ms) | StandardDeviation (ms) | MarginOfError (ms) |
|---|---|---|---|---|---|---|---|
| Chrome | Home | firstPaint | 64 | 183 | 107 | 32 | 16 |
| domContentLoaded | 10 | 30 | 14 | 5 | 2 | ||
| load | 51 | 2701 | 1403 | 1211 | 581 | ||
| domInteractive | 10 | 30 | 14 | 5 | 2 |
Bundle size diffs [🚀 Bundle size reduced!]
- background: 0 Bytes (0.00%)
- ui: 298 Bytes (0.00%)
- common: -21 Bytes (-0.00%)
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 65.72%. Comparing base (
3af209b) to head (8448fe2). Report is 1 commits behind head on develop.
Additional details and impacted files
@@ Coverage Diff @@
## develop #24771 +/- ##
===========================================
+ Coverage 65.69% 65.72% +0.03%
===========================================
Files 1360 1360
Lines 54081 54083 +2
Branches 14051 14051
===========================================
+ Hits 35525 35542 +17
+ Misses 18556 18541 -15
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
![codecov[bot] avatar](https://avatars.githubusercontent.com/in/254?v=4 "Published by a pub.dev verified publisher"){kind=small}
Builds ready [8448fe2]
- builds: chrome, firefox
- builds (beta): chrome
- builds (flask): chrome, firefox
- builds (MMI): chrome, firefox
- builds (test): chrome, firefox
- builds (test-flask): chrome, firefox
- build viz: Build System
- mv3: Background Module Init Stats
- mv3: UI Init Stats
- mv3: Module Load Stats
- mv3: Bundle Size Stats
- mv2: E2e Actions Stats
- code coverage: Report
- storybook: Storybook
- typescript migration: Dashboard
- all artifacts
Page Load Metrics (751 ± 498 ms)
| Platform | Page | Metric | Min (ms) | Max (ms) | Average (ms) | StandardDeviation (ms) | MarginOfError (ms) |
|---|---|---|---|---|---|---|---|
| Chrome | Home | firstPaint | 66 | 179 | 103 | 28 | 13 |
| domContentLoaded | 9 | 38 | 14 | 8 | 4 | ||
| load | 54 | 2574 | 751 | 1038 | 498 | ||
| domInteractive | 9 | 38 | 14 | 8 | 4 |
Bundle size diffs [🚀 Bundle size reduced!]
- background: 0 Bytes (0.00%)
- ui: 298 Bytes (0.00%)
- common: -21 Bytes (-0.00%)
Builds ready [05bcec5]
- builds: chrome, firefox
- builds (beta): chrome
- builds (flask): chrome, firefox
- builds (MMI): chrome, firefox
- builds (test): chrome, firefox
- builds (test-flask): chrome, firefox
- build viz: Build System
- mv3: Background Module Init Stats
- mv3: UI Init Stats
- mv3: Module Load Stats
- mv3: Bundle Size Stats
- mv2: E2e Actions Stats
- code coverage: Report
- storybook: Storybook
- typescript migration: Dashboard
- all artifacts
Page Load Metrics (834 ± 499 ms)
| Platform | Page | Metric | Min (ms) | Max (ms) | Average (ms) | StandardDeviation (ms) | MarginOfError (ms) |
|---|---|---|---|---|---|---|---|
| Chrome | Home | firstPaint | 60 | 177 | 99 | 28 | 13 |
| domContentLoaded | 8 | 46 | 12 | 8 | 4 | ||
| load | 49 | 2400 | 834 | 1040 | 499 | ||
| domInteractive | 8 | 46 | 12 | 8 | 4 |
Bundle size diffs [🚀 Bundle size reduced!]
- background: 0 Bytes (0.00%)
- ui: 298 Bytes (0.00%)
- common: -21 Bytes (-0.00%)
Builds ready [c419b85]
- builds: chrome, firefox
- builds (beta): chrome
- builds (flask): chrome, firefox
- builds (MMI): chrome, firefox
- builds (test): chrome, firefox
- builds (test-flask): chrome, firefox
- build viz: Build System
- mv3: Background Module Init Stats
- mv3: UI Init Stats
- mv3: Module Load Stats
- mv3: Bundle Size Stats
- mv2: E2e Actions Stats
- code coverage: Report
- storybook: Storybook
- typescript migration: Dashboard
- all artifacts
Page Load Metrics (846 ± 504 ms)
| Platform | Page | Metric | Min (ms) | Max (ms) | Average (ms) | StandardDeviation (ms) | MarginOfError (ms) |
|---|---|---|---|---|---|---|---|
| Chrome | Home | firstPaint | 70 | 180 | 102 | 25 | 12 |
| domContentLoaded | 9 | 17 | 11 | 2 | 1 | ||
| load | 58 | 2462 | 846 | 1050 | 504 | ||
| domInteractive | 9 | 17 | 11 | 2 | 1 |
Bundle size diffs [🚀 Bundle size reduced!]
- background: 0 Bytes (0.00%)
- ui: 314 Bytes (0.00%)
- common: -21 Bytes (-0.00%)
Missing release label release-11.16.1 on PR. Adding release label release-11.16.1 on PR and removing other release labels(release-11.18.0), as PR was cherry-picked in branch 11.16.1.