metamask-extension icon indicating copy to clipboard operation
metamask-extension copied to clipboard
verified publisher icon MetaMask

feat: Notifications analytics

Open matteoscurati opened this issue 1 year ago • 6 comments

Description

This PR is about the events to track for the use of notifications.

Open in GitHub Codespaces

Related issues

Fixes:

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

  • [x] I’ve followed MetaMask Coding Standards.
  • [x] I've completed the PR template to the best of my ability
  • [x] I’ve included tests if applicable
  • [x] I’ve documented my code using JSDoc format if applicable
  • [x] I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

  • [x] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • [x] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

matteoscurati avatar May 23 '24 17:05 matteoscurati

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

github-actions[bot] avatar May 23 '24 17:05 github-actions[bot]

Builds ready [029d52f]
Page Load Metrics (1723 ± 586 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint761931183919
domContentLoaded105816105
load62304517231220586
domInteractive105816105
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: 7.04 KiB (0.10%)
  • common: 860 Bytes (0.01%)

metamaskbot avatar May 23 '24 18:05 metamaskbot

Codecov Report

Attention: Patch coverage is 55.81395% with 19 lines in your changes are missing coverage. Please review.

Project coverage is 65.99%. Comparing base (de2f656) to head (d3e79ac). Report is 1 commits behind head on develop.

Files Patch % Lines
...ns-settings/notifications-settings-per-account.tsx 0.00% 4 Missing :warning:
...ications-settings/notifications-settings-types.tsx 0.00% 4 Missing :warning:
...k-notifications/turn-on-metamask-notifications.tsx 50.00% 2 Missing :warning:
...i/components/multichain/global-menu/global-menu.js 33.33% 2 Missing :warning:
...ngs/notifications-settings-allow-notifications.tsx 50.00% 2 Missing :warning:
ui/pages/notifications/notifications-list-item.tsx 0.00% 2 Missing :warning:
...ation-detail-button/notification-detail-button.tsx 66.67% 1 Missing :warning:
...tifications/notifications-list-read-all-button.tsx 50.00% 1 Missing :warning:
...tions/notifications-list-turn-on-notifications.tsx 50.00% 1 Missing :warning:
Additional details and impacted files 
@@             Coverage Diff             @@
##           develop   #24751      +/-   ##
===========================================
- Coverage    66.00%   65.99%   -0.01%     
===========================================
  Files         1348     1348              
  Lines        52503    52546      +43     
  Branches     13494    13498       +4     
===========================================
+ Hits         34651    34674      +23     
- Misses       17852    17872      +20

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar May 24 '24 09:05 codecov[bot]

Builds ready [9ddae7c]
Page Load Metrics (796 ± 540 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint68161922411
domContentLoaded9281353
load5632597961124540
domInteractive9281353
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: 7.01 KiB (0.10%)
  • common: 860 Bytes (0.01%)

metamaskbot avatar May 24 '24 11:05 metamaskbot

Builds ready [fe22bc8]
Page Load Metrics (757 ± 507 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint6112893199
domContentLoaded9211342
load4925657571055507
domInteractive9211342
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: 7.01 KiB (0.10%)
  • common: 860 Bytes (0.01%)

metamaskbot avatar May 24 '24 14:05 metamaskbot

Builds ready [6aff85d]
Page Load Metrics (1019 ± 567 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint59201933416
domContentLoaded8341363
load46280710191181567
domInteractive8341363
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: 7.01 KiB (0.10%)
  • common: 860 Bytes (0.01%)

metamaskbot avatar May 24 '24 16:05 metamaskbot

Builds ready [10be306]
Page Load Metrics (785 ± 479 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint55149882412
domContentLoaded86413126
load442701785997479
domInteractive86413126
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: 7.01 KiB (0.10%)
  • common: 860 Bytes (0.01%)

metamaskbot avatar May 27 '24 10:05 metamaskbot