metamask-extension icon indicating copy to clipboard operation
metamask-extension copied to clipboard

chore(deps): bump eth-snap-keyring to 3.0.0

Open montelaidev opened this issue 1 year ago • 7 comments

Description

This PR bumps the @metamask/eth-snap-keyring to 3.0.0

Related issues

Manual testing steps

Screenshots/Recordings

Pre-merge author checklist

  • [x] I’ve followed MetaMask Coding Standards.
  • [x] I've completed the PR template to the best of my ability
  • [x] I’ve included tests if applicable
  • [x] I’ve documented my code using JSDoc format if applicable
  • [x] I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

  • [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

montelaidev avatar May 23 '24 08:05 montelaidev

@metamaskbot update-policies

montelaidev avatar May 23 '24 08:05 montelaidev

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

github-actions[bot] avatar May 23 '24 08:05 github-actions[bot]

Policies updated

metamaskbot avatar May 23 '24 08:05 metamaskbot

New dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@metamask/[email protected] None +1 348 kB metamaskbot

View full report↗︎

socket-security[bot] avatar May 23 '24 08:05 socket-security[bot]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 66.01%. Comparing base (38199bb) to head (0b2f5c3).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop   #24735   +/-   ##
========================================
  Coverage    66.01%   66.01%           
========================================
  Files         1348     1348           
  Lines        52499    52499           
  Branches     13493    13493           
========================================
  Hits         34652    34652           
  Misses       17847    17847           

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar May 23 '24 14:05 codecov[bot]

Builds ready [0b2f5c3]
Page Load Metrics (704 ± 529 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint64166972512
domContentLoaded104618126
load5129567041102529
domInteractive94618126
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 126.43 KiB (3.57%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

metamaskbot avatar May 23 '24 15:05 metamaskbot

Builds ready [c302e1e]
Page Load Metrics (982 ± 600 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint732151094119
domContentLoaded108721199
load5833599821250600
domInteractive108621199
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 126.43 KiB (3.57%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

metamaskbot avatar May 24 '24 06:05 metamaskbot

No longer needed because its bumped in this pr https://github.com/MetaMask/metamask-extension/pull/24130

montelaidev avatar Jun 04 '24 14:06 montelaidev