metamask-extension icon indicating copy to clipboard operation
metamask-extension copied to clipboard
verified publisher icon MetaMask

style: Improve style notification items

Open matteoscurati opened this issue 1 year ago • 5 comments

Description

This PR introduces some style improvements and fixes for typos related to notifications.

Open in GitHub Codespaces

Related issues

Fixes:

Manual testing steps

Screenshots/Recordings

Before

After

Figma: https://www.figma.com/design/c7GgNw2kScGrVyRGAPhwEd/Notifications?node-id=6271%3A37657&t=VBIEJhBc9M0linw8-1

Pre-merge author checklist

  • [x] I’ve followed MetaMask Coding Standards.
  • [x] I've completed the PR template to the best of my ability
  • [x] I’ve included tests if applicable
  • [x] I’ve documented my code using JSDoc format if applicable
  • [x] I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

  • [x] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • [x] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

matteoscurati avatar May 23 '24 06:05 matteoscurati

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

github-actions[bot] avatar May 23 '24 06:05 github-actions[bot]

Builds ready [4bd4ea3]
Page Load Metrics (1452 ± 551 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint711391012211
domContentLoaded9431684
load58297414521147551
domInteractive9431684
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: 1.94 KiB (0.03%)
  • common: 88 Bytes (0.00%)

metamaskbot avatar May 23 '24 17:05 metamaskbot

Builds ready [880e0df]
Page Load Metrics (993 ± 543 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint692221134220
domContentLoaded107019147
load5625729931131543
domInteractive107019147
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: 2.21 KiB (0.03%)
  • common: 88 Bytes (0.00%)

metamaskbot avatar May 24 '24 13:05 metamaskbot

Builds ready [a7c6794]
Page Load Metrics (805 ± 539 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint641811073316
domContentLoaded95521136
load5130288051124539
domInteractive95521136
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: 2.21 KiB (0.03%)
  • common: 88 Bytes (0.00%)

metamaskbot avatar May 24 '24 15:05 metamaskbot

Builds ready [dbf4019]
Page Load Metrics (516 ± 431 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint6711684147
domContentLoaded95117115
load542503516898431
domInteractive95117115
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: 2.21 KiB (0.03%)
  • common: 88 Bytes (0.00%)

metamaskbot avatar May 25 '24 08:05 metamaskbot

Builds ready [5cbe5da]
Page Load Metrics (751 ± 506 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint61163892613
domContentLoaded9181221
load5025007511053506
domInteractive9181221
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: 2.21 KiB (0.03%)
  • common: 88 Bytes (0.00%)

metamaskbot avatar May 27 '24 10:05 metamaskbot