Modify smart-swap and swap-eth scenarios based on current feature change

[benjisclowder]

Smart Swap has changed from a swap setting screen toggle to Smart Transactions in Settings toggle. This PR reflects that change.

[github-actions[bot]]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[metamaskbot]

Builds ready [659a94e]

• builds: chrome, firefox
• builds (beta): chrome
• builds (flask): chrome, firefox
• builds (MMI): chrome, firefox
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• build viz: Build System
• mv3: Background Module Init Stats
• mv3: UI Init Stats
• mv3: Module Load Stats
• mv3: Bundle Size Stats
• mv2: E2e Actions Stats
• code coverage: Report
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4, 5, 6
  • common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
  • content-script: 0
  • ui: 0, 1, 10, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1599 ± 613 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	63	178	111	37	18
		domContentLoaded	9	55	16	10	5
		load	48	3203	1599	1278	613
		domInteractive	9	55	16	10	5

Bundle size diffs

• background: 0 Bytes (0.00%)
• ui: 0 Bytes (0.00%)
• common: 0 Bytes (0.00%)

[chloeYue]

LGTM!

[benjisclowder]

@seaona @chloeYue. There was another scenario that needed changes - the ENS one, to reflect the fact that ENS name resolution only works on Ethereum Mainnet. Potentially related to: Resolve ENS Names on L2 chains. I have updated this since Customer Success always mentions this scenario not working with Sepolia as indicated in the test steps. Should this change in the future, we will update the scenario again once it's done. So this needs also to be reviewed. Thank you

[codecov[bot]]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 65.85%. Comparing base (50fdee3) to head (412be75).

Additional details and impacted files

@@           Coverage Diff            @@
##           develop   #24711   +/-   ##
========================================
  Coverage    65.85%   65.85%           
========================================
  Files         1363     1363           
  Lines        54254    54254           
  Branches     14114    14114           
========================================
  Hits         35725    35725           
  Misses       18529    18529           

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

[metamaskbot]

Builds ready [412be75]

• builds: chrome, firefox
• builds (beta): chrome
• builds (flask): chrome, firefox
• builds (MMI): chrome, firefox
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• build viz: Build System
• mv3: Background Module Init Stats
• mv3: UI Init Stats
• mv3: Module Load Stats
• mv3: Bundle Size Stats
• mv2: E2e Actions Stats
• code coverage: Report
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4, 5
  • common: 0, 1, 2, 3, 4, 5, 6, 7, 8
  • content-script: 0
  • ui: 0, 1, 10, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1371 ± 572 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	72	161	114	30	14
		domContentLoaded	9	64	19	16	7
		load	60	3167	1371	1191	572
		domInteractive	9	64	19	16	7

Bundle size diffs

• background: 0 Bytes (0.00%)
• ui: 0 Bytes (0.00%)
• common: 0 Bytes (0.00%)