metamask-extension icon indicating copy to clipboard operation
metamask-extension copied to clipboard
verified publisher icon MetaMask

fix: Notifications platform links

Open matteoscurati opened this issue 1 year ago • 5 comments

Description

This PR introduces the logic to handle links within notifications to support the different platforms on which we can use the extension.

Open in GitHub Codespaces

Related issues

Fixes:

Manual testing steps

  1. Open the notifications list page
  2. Click on a product announcement
  3. Check the link in the detail page

Screenshots/Recordings

Before

After

Pre-merge author checklist

  • [x] I’ve followed MetaMask Coding Standards.
  • [x] I've completed the PR template to the best of my ability
  • [x] I’ve included tests if applicable
  • [x] I’ve documented my code using JSDoc format if applicable
  • [x] I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

  • [x] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • [x] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

matteoscurati avatar May 22 '24 12:05 matteoscurati

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

github-actions[bot] avatar May 22 '24 12:05 github-actions[bot]

Builds ready [4fe125f]
Page Load Metrics (894 ± 544 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint64159912411
domContentLoaded10391473
load5126338941132544
domInteractive10391473
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 151 Bytes (0.00%)
  • ui: 107 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

metamaskbot avatar May 23 '24 16:05 metamaskbot

Codecov Report

Attention: Patch coverage is 70.00000% with 6 lines in your changes missing coverage. Please review.

Project coverage is 65.75%. Comparing base (47706eb) to head (c991bd2). Report is 1 commits behind head on develop.

Files Patch % Lines
...sk-notifications/services/feature-announcements.ts 0.00% 3 Missing :warning:
...rm-notifications/utils/get-notification-message.ts 66.67% 1 Missing :warning:
...tton/notification-detail-block-explorer-button.tsx 92.31% 1 Missing :warning:
...ents/feature-announcement/feature-announcement.tsx 0.00% 1 Missing :warning:
Additional details and impacted files 
@@             Coverage Diff             @@
##           develop   #24708      +/-   ##
===========================================
+ Coverage    65.72%   65.75%   +0.03%     
===========================================
  Files         1360     1361       +1     
  Lines        54043    54072      +29     
  Branches     14036    14025      -11     
===========================================
+ Hits         35518    35552      +34     
+ Misses       18525    18520       -5

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar May 23 '24 21:05 codecov[bot]

Builds ready [341ea4b]
Page Load Metrics (727 ± 488 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint63137852010
domContentLoaded10351473
load5123687271016488
domInteractive9351473
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 151 Bytes (0.00%)
  • ui: 107 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

metamaskbot avatar May 24 '24 11:05 metamaskbot

Builds ready [c67e024]
Page Load Metrics (1317 ± 607 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint651621062914
domContentLoaded95118126
load53338113171265607
domInteractive95118126
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 151 Bytes (0.00%)
  • ui: 107 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

metamaskbot avatar May 24 '24 13:05 metamaskbot

Builds ready [460864c]
Page Load Metrics (732 ± 494 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint69175902713
domContentLoaded9201232
load5726617321029494
domInteractive9201232
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 151 Bytes (0.00%)
  • ui: 107 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

metamaskbot avatar May 27 '24 10:05 metamaskbot

Builds ready [5ac245e]
Page Load Metrics (1316 ± 596 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint821491122010
domContentLoaded95217115
load68294613161241596
domInteractive95217115
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 22 Bytes (0.00%)
  • ui: 1.9 KiB (0.03%)
  • common: 1 Bytes (0.00%)

metamaskbot avatar May 29 '24 17:05 metamaskbot

Missing release label release-12.0.0 on PR. Adding release label release-12.0.0 on PR and removing other release labels(release-12.1.0), as PR was cherry-picked in branch 12.0.0.

metamaskbot avatar Jun 12 '24 17:06 metamaskbot