metamask-extension icon indicating copy to clipboard operation
metamask-extension copied to clipboard

[Bug]: MV3 - Signatures - Personal Sign not working with Ledger

Open seaona opened this issue 1 year ago • 2 comments

Describe the bug

Whenever I try to perform a Personal Sign with a ledger device using an MV3 build, I can see how it does not trigger anything in my ledger device.

Expected behavior

I should see the signature prompt into my ledger device

Screenshots/Recordings

https://github.com/MetaMask/metamask-extension/assets/54408225/11a059a9-6630-42af-940e-2f2da69e9873

Steps to reproduce

  1. Build MV3
  2. Import a ledger
  3. Go to the test dapp
  4. Try a Personal Sign
  5. Accept in MM
  6. See nothing happens in ledger

Error messages or log output

No response

Version

develop MV3 build

Build type

None

Browser

Chrome

Operating system

Linux

Hardware wallet

No response

Additional context

No response

Severity

No response

seaona avatar May 17 '24 13:05 seaona

@seaona Do other signature types work with ledger on mv3?

danjm avatar May 17 '24 15:05 danjm

so:

  • :green_circle: typed v4: works on Ledger
  • :white_circle: typed v3 , typed (v1): don't work but because they are not supported by Ledger, so that's expected
  • :red_circle: personal sign: doesn't work
  • :red_circle: eth_sign: doesn't work, but since it's being deprecated I didn't open an issue for that one

seaona avatar May 20 '24 08:05 seaona

Missing release label release-11.16.6 on issue. Adding release label release-11.16.6 on issue, as issue is linked to PR #24622 which has this release label.

metamaskbot avatar Jun 04 '24 20:06 metamaskbot